.

[Tt112233]

.

 

[luorax]

function fire takes nothing returns nothing
    local unit caster=GetTriggerUnit()
    local group g=CreateGroup()
    local group temp=CreateGroup()
    local player owner=GetOwningPlayer(caster)
    local unit for
    call GroupEnumUnitsInRange(temp,GetUnitX(caster),GetUnitY(caster),500,null)
    loop
        set for=FirstOfGroup(temp)
        exitwhen for==null
        if IsUnitAlly(for,owner) then
            call GroupAddUnit(g,for)
        endif
        call GroupRemoveUnit(temp,for)
    endloop
    ...
endfunction

//or -->

globals
    private player Owner
endglobals

function filter takes nothing returns boolean
    return IsUnitAlly(GetFilterUnit(),Owner)
endfunction

function fire takes nothing returns nothing
    local unit caster=GetTriggerUnit
    local group g=CreateGroup()
    set Owner=GetOwningPlayer(caster)
    call GroupEnumUnitsInRange(g,GetUnitX(caster),GetUnitY(caster),500,function filter)
    ...
endfunction

 

[Dirac]

function fire takes nothing returns nothing
    local unit caster=GetTriggerUnit()
    local group g=CreateGroup()
    local group temp=CreateGroup()
    local player owner=GetOwningPlayer(caster)
    local unit for
    call GroupEnumUnitsInRange(temp,GetUnitX(caster),GetUnitY(caster),500,null)
    loop
        set for=FirstOfGroup(temp)
        exitwhen for==null
        if IsUnitAlly(for,owner) then
            call GroupAddUnit(g,for) //<--- this makes no sense
        endif
        call GroupRemoveUnit(temp,for) //<--- the unit gets removed here anyways
    endloop
    ...
endfunction

Use luorax's second suggestion.

 

[luorax]

Check it again, it has two groups

 

[Dirac]

I missed that (commonly you should use [ljass]bj_lastCreatedGroup[/ljass] for fast enumeration)
The first suggestion is better then because in the second you have to declare a global, a function, you have a global variable read (slower than local read), you have to reffer to the unit as [ljass]GetFilterUnit()[/ljass] and it creates a new thread for each unit enumerated

 

[Sgqvur]

>Dirac: and it creates a new thread for each unit enumerated

It doesn't because you can't use TSA. It says it in the GUI as a "documentation". And I am really curious about the definition
of a "thread" in the context of Jass, while the jass's interpreter is single threaded.