A Misfiring Trigger

Somatic

You can change this now in User CP.
Reaction score
84
I had a problem with this Trigger. Please do not start comment on its untidyness or not using Vjass and stuff like that.

JASS:
function Trig_Air_ship_Support_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A068' ) ) then
        return false
    endif
    return true
endfunction

function dsadsa_Func001001 takes nothing returns boolean
    return ( GetUnitTypeId(GetFilterUnit()) == 'h02P' )
endfunction

function dsadsa_Func001002 takes nothing returns boolean
    return ( GetUnitTypeId(GetFilterUnit()) == 'h01E' )
endfunction

function dsadsa_Conditions takes nothing returns boolean
    if ( not GetBooleanOr( dsadsa_Func001001(), dsadsa_Func001002() ) ) then
        return false
    endif
    return true
endfunction

function Contain_Airship takes unit Apache, location Temp_Point returns boolean
    return ( RectContainsUnit(RectFromCenterSizeBJ(Temp_Point, 500.00, 500.00), Apache) == true )
endfunction

function Trig_Air_ship_Support_Actions takes nothing returns nothing
    local unit Gun_Ship_1
    local unit Gun_Ship_2
    local unit Gun_Ship_3
    local unit f
    local real cy
    local real cx
    local location Temp_Point2
    local group Temp_Group = CreateGroup()

    local unit Caster = GetSpellAbilityUnit()
    local location Temp_Point = GetSpellTargetLoc()
    local location Start_Point = PolarProjectionBJ(Temp_Point, 1400.00, GetRandomDirectionDeg())
    local player Players = GetOwningPlayer(Caster)
    set cx = GetLocationX(Temp_Point)
    set cy = GetLocationY(Temp_Point)
    call DisplayTextToForce( GetForceOfPlayer(GetOwningPlayer(Caster)), ( "|c00808000" + ( "Gunship Operator" + ( "|r" + " : Coordinates Received" ) ) ) )
    if ( Player_Checker(Players) ) then
    call CreateNUnitsAtLoc( 1, 'h02P', Player(0), Start_Point, bj_UNIT_FACING )
    set Gun_Ship_1 = GetLastCreatedUnit()
    call BJDebugMsg("Gun Ship 1 Reporting")
    call IssuePointOrderLocBJ( Gun_Ship_1, "move", Temp_Point )
    call CreateNUnitsAtLoc( 1, 'h02P', Player(0), Start_Point, bj_UNIT_FACING )
    set Gun_Ship_2 = GetLastCreatedUnit()
    call BJDebugMsg("Gun Ship 2 Reporting")
    call IssuePointOrderLocBJ( Gun_Ship_2, "move", Temp_Point )
    call CreateNUnitsAtLoc( 1, 'h01E', Player(0), Start_Point, bj_UNIT_FACING )
    set Gun_Ship_3 = GetLastCreatedUnit()
    call BJDebugMsg("Gun Ship 3 Reporting")
    call IssuePointOrderLocBJ( Gun_Ship_3, "move", Temp_Point )
    call GroupEnumUnitsInRange(Temp_Group, cx, cy, 1000.00, Condition(function dsadsa_Conditions))
    call BJDebugMsg("Gun Ship Grouped")
    else
    call CreateNUnitsAtLoc( 1, 'h02P', Player(6), Start_Point, bj_UNIT_FACING )
    set Gun_Ship_1 = GetLastCreatedUnit()
    call BJDebugMsg("Gun Ship 4 Reporting")
    call IssuePointOrderLocBJ( Gun_Ship_1, "move", Temp_Point )
    call CreateNUnitsAtLoc( 1, 'h02P', Player(6), Start_Point, bj_UNIT_FACING )
    set Gun_Ship_2 = GetLastCreatedUnit()
    call BJDebugMsg("Gun Ship 5 Reporting")
    call IssuePointOrderLocBJ( Gun_Ship_2, "move", Temp_Point )
    call CreateNUnitsAtLoc( 1, 'h01E', Player(6), Start_Point, bj_UNIT_FACING )
    set Gun_Ship_3 = GetLastCreatedUnit()
    call BJDebugMsg("Gun Ship 6 Reporting")
    call IssuePointOrderLocBJ( Gun_Ship_3, "move", Temp_Point )
    call GroupEnumUnitsInRange(Temp_Group, cx, cy, 1000.00, Condition(function dsadsa_Conditions))
    call BJDebugMsg("Gun Ship Grouped 2")
    endif
    call TriggerSleepAction( 5.00 )
    loop
        call BJDebugMsg("Set Up Gunship")
        set f = FirstOfGroup(Temp_Group)
        exitwhen f == null
        call BJDebugMsg("Reached Location")
        call DisplayTextToForce( GetPlayersAll(), UnitId2StringBJ(GetUnitTypeId(f)) )
        set Temp_Point2 = PolarProjectionBJ(Temp_Point, GetRandomReal(400.00, 600.00), GetRandomDirectionDeg())
        call IssuePointOrderLocBJ( f, "patrol", Temp_Point2 )
        call BJDebugMsg("Issuing Order")
        call RemoveLocation(Temp_Point2)
        call GroupRemoveUnit(Temp_Group,f)
    endloop
    call TriggerSleepAction( 120.00 )
    call DisplayTextToForce( GetForceOfPlayer(GetOwningPlayer(Caster)), ( "|c00808000" + ( "Gunship Operator" + ( "|r" + " : We're Leaving the rest to You, Good Luck" ) ) ) )
    call IssuePointOrderLocBJ( Gun_Ship_1, "move", GetRectCenter(gg_rct_Gun_Ship_Kill_Zone) )
    call IssuePointOrderLocBJ( Gun_Ship_2, "move", GetRectCenter(gg_rct_Gun_Ship_Kill_Zone) )
    call IssuePointOrderLocBJ( Gun_Ship_3, "move", GetRectCenter(gg_rct_Gun_Ship_Kill_Zone) )
    call TriggerSleepAction( 15.00 )
    call RemoveUnit( Gun_Ship_1 )
    call RemoveUnit( Gun_Ship_2 )
    call RemoveUnit( Gun_Ship_3 )
    call RemoveLocation(Temp_Point)
    call RemoveLocation(Temp_Point2)
    call RemoveLocation(Start_Point)
    call DestroyGroup (Temp_Group)
endfunction

//===========================================================================
function InitTrig_Air_ship_Support takes nothing returns nothing
    set gg_trg_Air_ship_Support = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Air_ship_Support, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Air_ship_Support, Condition( function Trig_Air_ship_Support_Conditions ) )
    call TriggerAddAction( gg_trg_Air_ship_Support, function Trig_Air_ship_Support_Actions )
endfunction


My problem is that on my first cast, it only works till the "Set Up Gunship". My Second Cast works, but when i abuse it thought the third time, it starts to malfunction, as the actions work, it becomes the previous group of Gunships moving, and not the third group, it happends all the way as i start to abuse "thedudeabides" Any way of trouble shooting this problem? :banghead:
 

Builder Bob

Live free or don't
Reaction score
249
Edit: I did a small test in the WE and found out that what I suggested was not the issue, I'll look through the code again and see if I can find anything.

It would be helpful if you specified what the trigger is supposed to do though. So we can know what is not working right.

Edit 2: I noticed that you enumerate every unit within 1000 of Temp_Point, while you create all the units (that I am assuming you want to enumerate), 1400 away from this point. Is this the cause of your problem?
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top