About to launch beta

E

Edward

New Member
Reaction score
2
In this map all COMMON memory leaks have been fixed thanks to a lot of help here.

However, before I protect a copy of the map and launch a beta, I want to have these last few triggers reviewed. Each posted trigger is a sample of many of like triggers. I post each sample in the order of which I think is most likely to have leaks to that which is least likely.

Here we create something called "Visibility Modifier."

Trigger:
  • Alliance Left Vision
    • Events
      • Time - Elapsed game time is 5.00 seconds
    • Conditions
    • Actions
      • Visibility - Create an initially Enabled visibility modifier for Player 1 (Red) emitting Visibility across Alliance Left Vision <gen>
      • Visibility - Create an initially Enabled visibility modifier for Player 2 (Blue) emitting Visibility across Alliance Left Vision <gen>
      • Visibility - Create an initially Enabled visibility modifier for Player 3 (Teal) emitting Visibility across Alliance Left Vision <gen>
      • Visibility - Create an initially Enabled visibility modifier for Player 4 (Purple) emitting Visibility across Alliance Left Vision <gen>
      • Visibility - Create an initially Enabled visibility modifier for Player 5 (Yellow) emitting Visibility across Alliance Left Vision <gen>
      • Visibility - Create an initially Enabled visibility modifier for Player 6 (Orange) emitting Visibility across Alliance Left Vision <gen>


This is periodic.

Trigger:
  • Periodic Gold
    • Events
      • Time - Every 15.00 seconds of game time
    • Conditions
    • Actions
      • Player - Add 25 to Player 1 (Red) Current gold
      • Player - Add 25 to Player 2 (Blue) Current gold
      • Player - Add 25 to Player 3 (Teal) Current gold
      • Player - Add 25 to Player 4 (Purple) Current gold
      • Player - Add 25 to Player 5 (Yellow) Current gold
      • Player - Add 25 to Player 6 (Orange) Current gold
      • Player - Add 25 to Player 7 (Green) Current gold
      • Player - Add 25 to Player 8 (Pink) Current gold
      • Player - Add 25 to Player 9 (Gray) Current gold
      • Player - Add 25 to Player 10 (Light Blue) Current gold
      • Player - Add 25 to Player 11 (Dark Green) Current gold
      • Player - Add 25 to Player 12 (Brown) Current gold


String leak?

Trigger:
  • Open Horde North Gate
    • Events
      • Player - Player 7 (Green) types a chat message containing -open north as An exact match
      • Player - Player 8 (Pink) types a chat message containing -open north as An exact match
      • Player - Player 9 (Gray) types a chat message containing -open north as An exact match
      • Player - Player 10 (Light Blue) types a chat message containing -open north as An exact match
      • Player - Player 11 (Dark Green) types a chat message containing -open north as An exact match
      • Player - Player 12 (Brown) types a chat message containing -open north as An exact match
    • Conditions
    • Actions
      • Destructible - Open Iron Gate (Vertical) 0297 <gen>


Destructible Leak?

Trigger:
  • Respawn Horde North Gate
    • Events
      • Destructible - Iron Gate (Vertical) 0297 <gen> dies
    • Conditions
    • Actions
      • Wait 60.00 game-time seconds
      • Destructible - Resurrect Iron Gate (Vertical) 0297 <gen> with (Max life of Iron Gate (Vertical) 0297 <gen>) life and Hide birth animation


Possible point leak or region leak?
Trigger:
  • Red Suicide
    • Events
      • Unit - A unit enters Suicide 1 Red <gen>
    • Conditions
      • (Owner of (Triggering unit)) Equal to Player 1 (Red)
    • Actions
      • Unit - Kill (Triggering unit)


I doubt this leaks.

Trigger:
  • Respawn Waygate 1
    • Events
      • Unit - Way Gate 0064 <gen> Takes damage
    • Conditions
    • Actions
      • Unit - Hide Way Gate 0064 <gen>
      • Unit - Hide Way Gate 0065 <gen>
      • Wait 60.00 game-time seconds
      • Unit - Unhide Way Gate 0064 <gen>
      • Unit - Unhide Way Gate 0065 <gen>


You'll get a rep bonus for this. :)
 
tommerbob

tommerbob

Minecraft. :D
Reaction score
110
Well I personally don't see any memory leaks, but for your adding 25 gold to each player, you could simplify it by using 1 action to add 25 gold to every player, instead of 12 different actions.
 
Yoshii

Yoshii

New Member
Reaction score
74
Edward said:
Here we create something called "Visibility Modifier."

Trigger:
  • Alliance Left Vision
    • Events
      • Time - Elapsed game time is 5.00 seconds
    • Conditions
    • Actions
      • Visibility - Create an initially Enabled visibility modifier for Player 1 (Red) emitting Visibility across Alliance Left Vision <gen>
      • Visibility - Create an initially Enabled visibility modifier for Player 2 (Blue) emitting Visibility across Alliance Left Vision <gen>
      • Visibility - Create an initially Enabled visibility modifier for Player 3 (Teal) emitting Visibility across Alliance Left Vision <gen>
      • Visibility - Create an initially Enabled visibility modifier for Player 4 (Purple) emitting Visibility across Alliance Left Vision <gen>
      • Visibility - Create an initially Enabled visibility modifier for Player 5 (Yellow) emitting Visibility across Alliance Left Vision <gen>
      • Visibility - Create an initially Enabled visibility modifier for Player 6 (Orange) emitting Visibility across Alliance Left Vision <gen>

^^ This could spell trouble not leak but map code; you have no variable array that keep track of last created vision modifier for player but it could also be fine depending on your map.The problem could arise when they are destroyed

This is periodic.

Trigger:
  • Periodic Gold
    • Events
      • Time - Every 15.00 seconds of game time
    • Conditions
    • Actions
      • Player - Add 25 to Player 1 (Red) Current gold
      • Player - Add 25 to Player 2 (Blue) Current gold
      • Player - Add 25 to Player 3 (Teal) Current gold
      • Player - Add 25 to Player 4 (Purple) Current gold
      • Player - Add 25 to Player 5 (Yellow) Current gold
      • Player - Add 25 to Player 6 (Orange) Current gold
      • Player - Add 25 to Player 7 (Green) Current gold
      • Player - Add 25 to Player 8 (Pink) Current gold
      • Player - Add 25 to Player 9 (Gray) Current gold
      • Player - Add 25 to Player 10 (Light Blue) Current gold
      • Player - Add 25 to Player 11 (Dark Green) Current gold
      • Player - Add 25 to Player 12 (Brown) Current gold


Why not use Pick all player and add 25 gold to picked player thats 1 line

Trigger:
  • Open Horde North Gate
    • Events
      • Player - Player 7 (Green) types a chat message containing -open north as An exact match
      • Player - Player 8 (Pink) types a chat message containing -open north as An exact match
      • Player - Player 9 (Gray) types a chat message containing -open north as An exact match
      • Player - Player 10 (Light Blue) types a chat message containing -open north as An exact match
      • Player - Player 11 (Dark Green) types a chat message containing -open north as An exact match
      • Player - Player 12 (Brown) types a chat message containing -open north as An exact match
    • Conditions
    • Actions
      • Destructible - Open Iron Gate (Vertical) 0297 <gen>


Destructible Leak?

Trigger:
  • Respawn Horde North Gate
    • Events
      • Destructible - Iron Gate (Vertical) 0297 <gen> dies
    • Conditions
    • Actions
      • Wait 60.00 game-time seconds
      • Destructible - Resurrect Iron Gate (Vertical) 0297 <gen> with (Max life of Iron Gate (Vertical) 0297 <gen>) life and Hide birth animation


Possible point leak or region leak?
Trigger:
  • Red Suicide
    • Events
      • Unit - A unit enters Suicide 1 Red <gen>
    • Conditions
      • (Owner of (Triggering unit)) Equal to Player 1 (Red)
    • Actions
      • Unit - Kill (Triggering unit)


I doubt this leaks.

Trigger:
  • Respawn Waygate 1
    • Events
      • Unit - Way Gate 0064 <gen> Takes damage
    • Conditions
    • Actions
      • Unit - Hide Way Gate 0064 <gen>
      • Unit - Hide Way Gate 0065 <gen>
      • Wait 60.00 game-time seconds
      • Unit - Unhide Way Gate 0064 <gen>
      • Unit - Unhide Way Gate 0065 <gen>


You'll get a rep bonus for this. :)
Click to expand...
I see nothing that leak, i dont see any region being used or unit group
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • WildTurkey WildTurkey:
    is there a stephen green in the house?
     +1
  • The Helper The Helper:
    What is up WildTurkey?
  • The Helper The Helper:
    Looks like Google fixed whatever mistake that made the recipes on the site go crazy and we are no longer trending towards a recipe site lol - I don't care though because it motivated me to spend alot of time on the site improving it and at least now the content people are looking at is not stupid and embarrassing like it was when I first got back into this like 5 years ago.
  • The Helper The Helper:
    Plus - I have a pretty bad ass recipe collection now! That section of the site is 10 thousand times better than it was before
  • The Helper The Helper:
    We now have a web designer at my job. A legit talented professional! I am going to get him to redesign the site theme. It is time.
  • Varine Varine:
    I got one more day of community service and then I'm free from this nonsense! I polished a cop car today for a funeral or something I guess
  • Varine Varine:
    They also were digging threw old shit at the sheriff's office and I tried to get them to give me the old electronic stuff, but they said no. They can't give it to people because they might use it to impersonate a cop or break into their network or some shit? idk but it was a shame to see them take a whole bunch of radios and shit to get shredded and landfilled
  • The Helper The Helper:
    whatever at least you are free
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?

      The Helper Discord

      Staff online

      Members online

      Online now:
      360 (members: 1, guests: 359)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top