Another Omnislash. vJass

Z

Zeth

Member
Reaction score
3
Ok, i know there are a lot of Omnislash spells encoded, but only found one approved in THW, and it's GUI. Anyway, i'm not going to send this as a resource because people don't like repeated spells :D

Requirements:

GT - Jesus4Lyf

TimerUtils - Vexorian

Here's a test map, wich has the dummy spell (i used Channel)

http://www.epicwar.com/maps/156575/

And the code:

JASS:
scope Omnislash // requires TimerUtils, GT

    globals
        private constant integer SPELL_ID        = 'A000' // The ID of the ability
        private constant real    AREA            = 450.   // Range of the ennumeration
        private constant real    LOOP            = .4     // Period
        private constant string  SFX             = "Abilities\\Weapons\\PhoenixMissile\\Phoenix_Missile_mini.mdl" // Principal SFX
        private constant string  SFX2            = "Abilities\\Spells\\NightElf\\Blink\\BlinkCaster.mdl"          // SFX created in each slash
        private constant string  SFXATTACH       = "weapon" 
        private constant string SFX2ATTACH       = "chest"
        private constant string  ATTACKSTG       = "attack" // You can change it to "attack slam" if you want
        private constant boolean INVULNERABLE    = true     // Dooes Yurnero becomes invulnerable while omnislashing?
        private constant attacktype ATTACKTYPE   = ATTACK_TYPE_HERO
        private constant damagetype DAMAGETYPE   = DAMAGE_TYPE_NORMAL
        private          group      Enum_Group   = CreateGroup() // Group for the enum, is always empty
        private constant integer MAX_ENUM_UNITS  = 30 // Max size of the array... 
    endglobals

private struct OmniStruct
 
        private effect sfx // Phoenix effect
        private player p   // Owning player of casting unit
        private unit c     // Casting unit
        private unit t     // Target unit
        private integer lvl
        private integer cnt// Number of slashes
        private timer tm   
        private real ang   // Angle used to define a random position around the target
        private real cX    
        private real cY
        private real tX
        private real tY
        private real dmg   // Damage, it's a random number between 150 and 250 in each slash
        private integer num=2 // Number of actual slashes
    
        private static unit array targets[MAX_ENUM_UNITS] // Used for group the targets and select a random one from there
        private static integer index=0 

    method Slashes takes integer level returns integer
       return R2I(0.50*level*level+0.50*level+2.00)
    endmethod
    
    method onDestroy takes nothing returns nothing
        local integer i=0
        call DestroyEffect(.sfx)
        call SetUnitVertexColor(.c,255,255,255,255)
        call SetUnitInvulnerable(.c,false)
        call SetUnitPathing(.c,true)
        call ReleaseTimer(.tm)
        loop
            exitwhen i>30
            set .targets<i>=null // Set all the targets to null
            set i=i+1
        endloop
        set .sfx=null
        set .p=null
        set .c=null
        set .t=null
        set .tm=null
    endmethod

    method Slash takes nothing returns nothing
        set .ang=GetRandomReal(1.,360.) 
        set .tX=GetUnitX(.t)+50.*Cos(.ang*bj_DEGTORAD)
        set .tY=GetUnitY(.t)+50.*Sin(.ang*bj_DEGTORAD)
        call SetUnitFacing(.c,Atan2(.tY-.cY,.tX-.cX)*bj_RADTODEG)
        set .dmg=GetRandomReal(150.,250.) 
        call SetUnitX(.c,.tX)
        call SetUnitY(.c,.tY)
        call SetUnitAnimation(.c,ATTACKSTG)
        call DestroyEffect(AddSpecialEffectTarget(SFX2,.c,SFX2ATTACH))
        call UnitDamageTarget(.c,.t,.dmg,true,true,ATTACKTYPE,DAMAGETYPE,null)
        call IssueTargetOrder(.c,ATTACKSTG,.t)   
    endmethod
        
    static method Filter takes nothing returns boolean
        local thistype this=GetTimerData(GetExpiredTimer())
        set .t=GetFilterUnit()
        if IsUnitEnemy(.t,.p) and GetWidgetLife(.t)&gt;.405 and not IsUnitType(.t,UNIT_TYPE_STRUCTURE) and IsUnitVisible(.t,.p) then
            set .targets[.index]=.t // If the conditions are true, then add the filter unit to the array
            set .index=.index+1
        endif
        return false // No unit enters the group
    endmethod
    
    static method onLoop takes nothing returns nothing
        local thistype this=GetTimerData(GetExpiredTimer())
        local integer i=0
        if .num&gt;.cnt then 
            call .destroy() 
        else
            set .num=.num+1
            call GroupEnumUnitsInRange(Enum_Group,.tX,.tY,AREA,Condition(function thistype.Filter))
            set .t=.targets[GetRandomInt(0,.index-1)]
            if .t!=null then
                call .Slash()
                set .index=0
                loop
                   exitwhen i&gt;MAX_ENUM_UNITS
                   set .targets<i>=null // Cleaning the array
                   set i=i+1
                endloop
            else
                call .destroy()
            endif
        endif
    endmethod

    static method create takes nothing returns thistype
        local thistype this=.allocate()
        set .tm=NewTimer()
        set .c=GetTriggerUnit()
        set .cX=GetUnitX(.c)
        set .cY=GetUnitY(.c)
        set .t=GetSpellTargetUnit()
        set .p=GetOwningPlayer(.c)
        set .lvl=GetUnitAbilityLevel(.c,SPELL_ID)
        set .cnt=Slashes(.lvl)
        call SetUnitVertexColor(.c,255,255,255,125)
        call SetUnitPathing(.c,false)
        call SetUnitInvulnerable(.c,INVULNERABLE)
        call .Slash()
        set .sfx=AddSpecialEffectTarget(SFX,.c,SFXATTACH)
        call SetTimerData(.tm,this)
        call TimerStart(.tm,LOOP,true,function thistype.onLoop)
        return this
    endmethod
endstruct

private function Execute takes nothing returns nothing
        call OmniStruct.create()
endfunction
    
public function InitTrig takes nothing returns nothing
    local trigger t=CreateTrigger()
    call GT_RegisterStartsEffectEvent(t,SPELL_ID)
    call TriggerAddAction(t,function Execute)
    set t=null
endfunction
endscope</i></i>


Recommendations? :p

Updates:

15/12/10 : Added method to calculate number of slashs, thanks Carnerox.
 
Carnerox

Carnerox

The one and only.
Reaction score
84
You should do Slashes like this, instead of doing the If Level =.

JASS:
method Slashes takes integer level returns real
   return 0.50*level*level+0.50*level+2.00
endmethod
 
Bo-Bo

Bo-Bo

New Member
Reaction score
8
Hey!

I got a few questions:

JASS:
static method Filter takes nothing returns boolean
    local thistype this=GetTimerData(GetExpiredTimer())
    set .t=GetFilterUnit()
    if IsUnitEnemy(.t,.p) and GetWidgetLife(.t)&gt;.405 and not IsUnitType(.t,UNIT_TYPE_STRUCTURE) and IsUnitVisible(.t,.p) then
        set .targets[.index]=.t // If the conditions are true, then add the filter unit to the array
        set .index=.index+1
    endif
    return false // No unit enters the group
endmethod


1. Why does this work?
The Filter function isn't called by a timer!? So how can you get an expired timer?
Or can you use this, because the Filter function is called by the GroupEnumUnitsInRange function?

2. I still don't get which is better:
JASS:
GetWidgetLife(.t)&gt;.405
or
JASS:
IsUnitType(.t, UNIT_TYPE_DEAD)
 
Z

Zeth

Member
Reaction score
3
1. Because the Filter function is called by GroupEnumUnitsInRange, that function is called inside onLoop function, onLoop function IS called by a timer. :p

2. the first is the best, also you can use UnitAlive

Carnerox said:
You should do Slashes like this, instead of doing the If Level =.
Click to expand...

Thanks man, that's great!!!
 
Darthfett

Darthfett

Aerospace/Cybersecurity Software Engineer
Reaction score
615
Bo-Bo said:
2. I still don't get which is better:
JASS:
GetWidgetLife(.t)&gt;.405
or
JASS:
IsUnitType(.t, UNIT_TYPE_DEAD)
Click to expand...

I don't quite remember. I think the GetWidgetLife and 0.405 life has problems with stuff like reincarnation (or maybe it's the other one). However, Blizzard implemented the [ljass]UnitAlive[/ljass] native (click that for link), which is as simple as declaring the native.
 
Bo-Bo

Bo-Bo

New Member
Reaction score
8
Zeth said:
1. Because the Filter function is called by GroupEnumUnitsInRange, that function is called inside onLoop function, onLoop function IS called by a timer. :p
Click to expand...

Haha^^
Ok, that's cool, thanks!
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      No members online now.
      Online now:
      78 (members: 2, guests: 76)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top