Could someone fix up my leaks ? (if its not too much to ask)

[marvey323]

My map has been crashing incessantly whenever I have more than a few players playing and I know its beacuse of poor coding. I was wondering if anyone could take some time and fix up the obvious leaks it has. Map size is slightly over the forum allowed limit to upload so I've uploaded it to rapidshare if anyone wants to take a shot at it.

The map is not even 1% done as you can tell so any help right now would really be appreciated to get me going in the right direction.

Map:
http://rapidshare.com/files/198659227/vhMAP_v2.w3x.html


Thanks in advance.

 

[Stryke]

Just use the 56kers Leak Checker, it gets rid of most of the leaks. you can find it on the hiveworkshop probably.

 

[marvey323]

That would show me where I leak right and that's about it :x

 

[vypur85]

Crashing is not usually caused by leak, at least at early game.


> if its not too much to ask

It could be much. You should learn yourself. Show your triggers and I may help to fix some, while you fix the rest yourself.

 

[WolfieeifloW]

Here's some tutorials on leak checking / removal.
They're the two I used to learn.
One
Two
No need to read them in order;
Either or will do (although I recommend reading both) .

 

[Igor_Z]

If u need leak removing. Check out the programs below. Btw can u show the triggers, its too much time to open the map...

 

[marvey323]

Well.. the reason why I uploaded the map is because there's more than 30 triggers in total, some of them are over 100 lines each so which am I supposd to post.. I think they are all equally leak-able.


In any case, I'll update this thread in the morning and try to post as much of my trigger code as possible.

Thanks for the links btw.

 

[Igor_Z]

Oh, i didn't knew that... Don't waste so much time.. I'll check it and see later or myb some 1 else will. Btw i thought that u have 1 spell to fix the leaks..

 

[Ryuu]

Use the Link checker the identify your leaks.
The most common leaks that people always have (at least for me):

Point leaks:
Custom script: call RemoveLocation(udg_Variable)

Unit Group leaks:
Custom script: call DestroyGroup(udg_Variable)

Player Group leaks:
Custom script: call DestroyForce(udg_Variable)

Special Effect leaks:
Special Effect - Destroy (Variable)

 

[Dregonx]

Use the Link checker the identify your leaks.
The most common leaks that people always have (at least for me):

Point leaks:
Custom script: call RemoveLocation(udg_Variable)

Unit Group leaks:
Custom script: call DestroyGroup(udg_Variable)

Player Group leaks:
Custom script: call DestroyForce(udg_Variable)

Special Effect leaks:
Special Effect - Destroy (Variable)

Wow, I never knew player groups leaked... greaaaat... :banghead:

 

[vypur85]

> I never knew player groups leaked

Not 'All players' though. It doesn't leak. And it's not a good idea to destroy All players. The others would leak.

 

[Dregonx]

> I never knew player groups leaked

Not 'All players' though. It doesn't leak. And it's not a good idea to destroy All players. The others would leak.

Oh so, like Player Group - Player 1 (Red) / Player 1 (Red) etc?

 

[Sp3tZn4z]

...

 

[marvey323]

I'm not gonna fix any of the leaks I find because it would take more work then i'm rdy to put into it, i'm working on my own map wich still needs alot of work.

In the Category - Bosses there are lots of location and unit group leaks.

Also the trigger under Category - Creep Item Drop called "Item Drop lvl 1to10" has location leaks.

Under Category - Creep Patrol the trigger "Patrol Start" has tons of unit group leaks.

Under Category - Town Unit Patrol the trigger named "Guard Patrol Main Start" and "Guard Patrol Start South" have Unit group and a Location leaks.

It's safe to say that most or all are gonna be location and unit group leaks.
Haven't checked the rest of the triggers.... because I think there are tons more.
One more reason why I don't wanna fix them is because if you gonna do more to this map you're gonna get more leaks and you should learn to fix them when you make the triggers.

--------------------------------------------------------------------------------

Thanks. At least you told me where to start. And thanks to the rest too for the links.

 

[Sp3tZn4z]

...

 

[marvey323]

Okay so in my attempt to fix my leaks.. here's one that I thougth I fixed...

• Repicking
  • Events
    • Player - Player 1 (Red) types a chat message containing -repick as An exact match
    • Player - Player 2 (Blue) types a chat message containing -repick as An exact match
    • Player - Player 3 (Teal) types a chat message containing -repick as An exact match
    • Player - Player 4 (Purple) types a chat message containing -repick as An exact match
    • Player - Player 5 (Yellow) types a chat message containing -repick as An exact match
    • Player - Player 6 (Orange) types a chat message containing -repick as An exact match
  • Conditions
    • Repick[(Player number of (Triggering player))] Equal to 0
    • (Number of units in (Units owned by (Triggering player) matching (((Matching unit) is A Hero) Equal to True))) Equal to 2
  • Actions
    • Game - Display to (All allies of (Triggering player)) the text: A player has repick...
    • Set RepickingArea = (Center of RepickingArea <gen>)
    • Camera - Pan camera for (Triggering player) to RepickingArea over 0.00 seconds
    • Unit Group - Pick every unit in (Units owned by (Triggering player)) and do (Actions)
      • Loop - Actions
        • Unit - Remove (Picked unit) from the game
    • Unit - Create 1 Hero Chooser for (Triggering player) at RepickingArea facing Default building facing degrees
    • Set Repick[(Player number of (Triggering player))] = 1
    • Custom script: call RemoveLocation(udg_RepickingArea)
    • Custom script: set bj_wantDestroyGroup = true

Here's what leak checker shows when I run the analysis:

(Line: 11 ) (Word: 5 ) Unit Group Leak
(Number of units in (Units owned by (Triggering player) matching (((Matching unit) is A Hero) Equal to True))) Equal to 2
(Number of units in ^Leak
(Suggested fix) Custom Script: set bj_wantDestroyGroup = true
(Suggested fix) (Number of units in (Units owned by (Triggering player) matching (((Matching unit) is A Hero) Equal to True))) Equal to 2

(Line: 16 ) (Word: 8 ) Unit Group Leak
Unit Group - Pick every unit in (Units owned by (Triggering player)) and do (Actions)
Unit Group - Pick every unit in ^Leak
(Suggested fix) Custom Script: set bj_wantDestroyGroup = true
(Suggested fix) Unit Group - Pick every unit in (Units owned by (Triggering player)) and do (Actions)

Location variable has not been removed:

Completed
Total amount of leaks: 2
Leak Rating: Good

Is it just a bug in leak checker? Its suggested fixes are already done in my trigger yet it says I haven't done so.

 

[Sp3tZn4z]

...