Critic my Spell, Please.

tooltiperror

tooltiperror

Super Moderator
Reaction score
231
Would anyone mind criticizing my Spell, telling me if there's a bug, if it leaks, or if I need to fix something?

Swap places with an enemy unit, then deal 125 damage. Targets Land and Air units.​

Trigger:
  • Swap
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to Swap
    • Actions
      • Set Caster = (Position of (Casting unit))
      • Set Target = (Position of (Target unit of ability being cast))
      • Set CasterUnit = (Casting unit)
      • Set TargetUnit = (Target unit of ability being cast)
      • Unit - Pause CasterUnit
      • Unit - Pause TargetUnit
      • Unit - Move TargetUnit instantly to Caster
      • Unit - Move CasterUnit instantly to Target
      • Unit - Make CasterUnit face Target over 0.00 seconds
      • Unit - Make TargetUnit face Caster over 0.00 seconds
      • Unit - Unpause TargetUnit
      • Unit - Unpause CasterUnit
      • Unit - Set life of TargetUnit to ((Life of TargetUnit) - 125.00)
      • Special Effect - Create a special effect at Caster using Abilities\Spells\Human\MassTeleport\MassTeleportCaster.mdl
      • Wait 1.00 seconds
      • Special Effect - Destroy (Last created special effect)
      • Custom script: call RemoveLocation (udg_Target)
      • Custom script: call RemoveLocation (udg_Caster)
 
N

Nighthawk

New Member
Reaction score
9
Don't see a reason to pause the units since you have no wait period between the pause/unpause actions, could be wrong though. Also it might look cooler if you placed the special effect on both units.

Instead of changing health of the target you can use the (Unit - damage unit) action. The advantage of this, is that if the unit dies via the action then he/she will get credit for the kill.

Trigger:
  • Swap
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to Swap
    • Actions
      • Set Swap_Target_Unit = (Target unit of ability being cast)
      • Set Swap_Caster_Unit = (Triggering unit)
      • Set Swap_Target_Position = (Position of Swap_Target_Unit)
      • Set Swap_Caster_Position = (Position of Swap_Caster_Unit)
      • Unit - Move Swap_Target_Unit instantly to Swap_Caster_Position
      • Unit - Move Swap_Caster_Unit instantly to Swap_Target_Position
      • Unit - Make Swap_Target_Unit face Swap_Caster_Unit over 0.00 seconds
      • Unit - Make Swap_Caster_Unit face Swap_Target_Unit over 0.00 seconds
      • Unit - Cause Swap_Caster_Unit to damage Swap_Target_Unit, dealing 125.00 damage of attack type Spells and damage type Normal
      • Special Effect - Create a special effect attached to the origin of Swap_Target_Unit using Abilities\Spells\Human\MassTeleport\MassTeleportCaster.mdl
      • Special Effect - Create a special effect attached to the origin of Swap_Caster_Unit using Abilities\Spells\Human\MassTeleport\MassTeleportCaster.mdl
 
tooltiperror

tooltiperror

Super Moderator
Reaction score
231
Don't see a reason to pause the units since you have no wait period between the pause/unpause actions, could be wrong though. Also it might look cooler if you placed the special effect on both units.

Instead of changing health of the target you can use the (Unit - damage unit) action. The advantage of this, is that if the unit dies via the action then he/she will get credit for the kill.
​

Thanks!

Also, how would I go about making this into MUI? I read a tutorial, but I do not see how to do it.
 
S

Sarj14

New Member
Reaction score
9
Besides what Nighthawk said it looks fine to me. Good luck! About the MUI stuff, I have no clue, sorry!
 
tooltiperror

tooltiperror

Super Moderator
Reaction score
231
Besides what Nighthawk said it looks fine to me. Good luck! About the MUI stuff, I have no clue, sorry!
​

Oh, well, thanks anyway! [:

Oh, god, sorry, forgot to +Rep Nighthawk!

Edit: Oh, wait, yes I did >.<
 
tooltiperror

tooltiperror

Super Moderator
Reaction score
231
No you didn't *cough*
​

That doesn't work on me anymore.
 
Z

zxczxzczx

New Member
Reaction score
2
to make it mui you should remove the waits or add local variables then use the waits.

Trigger:
  • Untitled Trigger 001
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to Swap
    • Actions
      • Custom script: local unit Swap_Target_Unit
      • Custom script: local unit Swap_Caster_Unit
      • Custom script: local location Swap_Target_Position
      • Custom script: local location Swap_Caster_Position
      • Custom script: local effect SFX1
      • Custom script: local effect SFX2
      • Custom script: set Swap_Caster_Unit = GetTriggerUnit()
      • Custom script: set Swap_Target_Unit = GetSpellTargetUnit()
      • Custom script: set Swap_Caster_Position = GetUnitLoc(Swap_Caster_Unit)
      • Custom script: set Swap_Target_Position = GetUnitLoc(Swap_Target_Unit)
      • Custom script: call SetUnitPositionLoc( Swap_Target_Unit, Swap_Caster_Position )
      • Custom script: call SetUnitPositionLoc( Swap_Caster_Unit, Swap_Target_Position )
      • Custom script: call SetUnitFacingToFaceUnitTimed( Swap_Caster_Unit, Swap_Target_Unit, 0 )
      • Custom script: call SetUnitFacingToFaceUnitTimed( Swap_Target_Unit, Swap_Caster_Unit, 0 )
      • Custom script: call UnitDamageTargetBJ( Swap_Caster_Unit, Swap_Target_Unit, 125, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
      • Custom script: call AddSpecialEffectTargetUnitBJ( &quot;origin&quot;, Swap_Caster_Unit, &quot;Abilities\\Spells\\Human\\MassTeleport\\MassTeleportCaster.mdl&quot; )
      • Custom script: set SFX1 = GetLastCreatedEffectBJ()
      • Custom script: call AddSpecialEffectTargetUnitBJ( &quot;origin&quot;, Swap_Target_Unit, &quot;Abilities\\Spells\\Human\\MassTeleport\\MassTeleportCaster.mdl&quot; )
      • Custom script: set SFX2 = GetLastCreatedEffectBJ()
      • Custom script: call PolledWait( 1.00 )
      • Custom script: call DestroyEffectBJ( SFX1 )
      • Custom script: call DestroyEffectBJ( SFX2 )
      • Custom script: call RemoveLocation (Swap_Target_Position)
      • Custom script: call RemoveLocation (Swap_Caster_Position)
      • Custom script: set Swap_Caster_Unit = null
      • Custom script: set Swap_Target_Unit = null


or just remove the waits :)
 
tooltiperror

tooltiperror

Super Moderator
Reaction score
231
to make it mui you should remove the waits or add local variables then use the waits.
or just remove the waits :)
​

So if I remove the Wait, it is MUI?
 
Z

zxczxzczx

New Member
Reaction score
2
yes, but GUI is very limited interms of making a spell MUI, it will come to the point that when you create a complicated spell you would need jass. hehehe
 
tooltiperror

tooltiperror

Super Moderator
Reaction score
231
zxczxzczx said:
yes, but GUI is very limited interms of making a spell MUI, it will come to the point that when you create a complicated spell you would need jass. hehehe
Click to expand...

I'm in the process of learning, but I'm kind of lazy at it, taking it in bits.
 
Z

zxczxzczx

New Member
Reaction score
2
hehe, i have a suggestion for the skill, why not add more eye candies and you could add a slow effect around the area of the 2 swaped units. :rolleyes: and make the area wave a little so that it would look like gravity did it
 
tooltiperror

tooltiperror

Super Moderator
Reaction score
231
zxczxzczx said:
hehe, i have a suggestion for the skill, why not add more eye candies and you could add a slow effect around the area of the 2 swaped units. :rolleyes: and make the area wave a little so that it would look like gravity did it
Click to expand...

Been thinking of a lot of effects, thanks for the ideas.
 
Ph[o]bia

Ph[o]bia

New Member
Reaction score
7
ToolTipError said:
Would anyone mind criticizing my Spell, telling me if there's a bug, if it leaks, or if I need to fix something?

Swap places with an enemy unit, then deal 125 damage. Targets Land and Air units.​

Trigger:
  • Swap
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to Swap
    • Actions
      • Set Caster = (Position of (Casting unit))
      • Set Target = (Position of (Target unit of ability being cast))
      • Set CasterUnit = (Casting unit)
      • Set TargetUnit = (Target unit of ability being cast)
      • Unit - Pause CasterUnit
      • Unit - Pause TargetUnit
      • Unit - Move TargetUnit instantly to Caster
      • Unit - Move CasterUnit instantly to Target
      • Unit - Make CasterUnit face Target over 0.00 seconds
      • Unit - Make TargetUnit face Caster over 0.00 seconds
      • Unit - Unpause TargetUnit
      • Unit - Unpause CasterUnit
      • Unit - Set life of TargetUnit to ((Life of TargetUnit) - 125.00)
      • Special Effect - Create a special effect at Caster using Abilities\Spells\Human\MassTeleport\MassTeleportCaster.mdl
      • Wait 1.00 seconds
      • Special Effect - Destroy (Last created special effect)
      • Custom script: call RemoveLocation (udg_Target)
      • Custom script: call RemoveLocation (udg_Caster)
Click to expand...

1.
Trigger:
  • Unit - Set life of TargetUnit to ((Life of TargetUnit) - 125.00)

Instead of this, maybe you should use
Trigger:
  • Unit - Cause CasterUnit to damage TargetUnit. Dealing 125.00 damage of type Spells and damage type Normal
 
tooltiperror

tooltiperror

Super Moderator
Reaction score
231
Instead of this, maybe you should use
Trigger:
  • Unit - Cause CasterUnit to damage TargetUnit. Dealing 125.00 damage of type Spells and damage type Normal

Already did that, but thanks!

Edit: I had an idea to make three variations of this spell, doing different things.

Do you think that would be sufficient for a Spellpack, or do they have to be big and fancy and stuff?
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      No members online now.
      Online now:
      84 (members: 1, guests: 83)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top