CSCache not storing local unit... i guess

H

hoeyad

New Member
Reaction score
3
This spell is supposed to create a boomerang and send it in a outward spiral around the caster. The boomerang gets made but does not move. I put in game messages and floating text to help debug, and they work fine (it says "running" for several seconds and then "the end", and the floating text does not pop up above the boomerang, it pops up at 0,0 on the map), so it seems like it is just not saving the local variable boom. This is the second time i have used this CSCache system by Vexorian, and the first time it was fine.

So the problem is that the boomerang does not move, and also it does not go away once the loop ends (when "the end" pops up). I think it is because the local variable boom is not set or stored to the cache correctly.

Here's where I think the problem is:
JASS:
function Boomerang_Effects takes nothing returns nothing
    local timer t = GetExpiredTimer()
    local string s = GetAttachmentTable(t)
    local trigger trig
    local string strig
    local unit caster = GetTableUnit(s,"caster")
    local unit boom = GetTableUnit(s,"boom")
    local real boomloop = GetTableReal(s,"boomloop")
    
    call CreateTextTagUnitBJ( "Boomerang", boom, 0, 10, 100, 100, 100, 0 )
    call DisplayTimedTextToForce( GetPlayersAll(), 1.00, "running" )
    call SetUnitPosition(boom, (GetLocationX(GetUnitLoc(caster))+(50+(7.5*(boomloop)))*Cos((8 * (boomloop))*bj_DEGTORAD)),(GetLocationY(GetUnitLoc(caster))+(50+(7.5*(boomloop)))*Sin((8 * (boomloop))*bj_DEGTORAD)))
    set boomloop = boomloop + 1
    
    if boomloop>=200 or GetUnitState(caster,UNIT_STATE_LIFE)<=0 then
        call DisplayTimedTextToForce( GetPlayersAll(), 30.00, "the end" )
        call RemoveUnit(boom)
        set trig = GetTableTrigger(s,"trig")
        set strig = GetAttachmentTable(trig)
        call TriggerRemoveAction(trig,GetTableTriggerAction(strig,"ta"))
        call ClearTable(strig)
        call DestroyTrigger(trig)
        set trig = null
        call ClearTable(s)
        call PauseTimer(t)
        call DestroyTimer(t)
    else
        call SetTableReal(s,"boomloop",boomloop)
    endif
    
    set caster = null
    set boom = null
endfunction
    
function Trig_Boomerang_Actions takes nothing returns nothing
    local unit caster = GetTriggerUnit()
    local real x = GetUnitX(caster)
    local real y = GetUnitY(caster)
    local location boomloc = Location(x + 50, y)
    local trigger trig = CreateTrigger()
    local string strig = GetAttachmentTable(trig)
    local timer t = CreateTimer()
    local string s = GetAttachmentTable(t)
    local unit boom
    
    call CreateUnitAtLoc(GetOwningPlayer(GetTriggerUnit()), 'u001', boomloc, bj_UNIT_FACING)
    set boom = bj_lastCreatedUnit
    
    call TriggerRegisterUnitInRange(trig,boom,150,null)
    call TriggerAddCondition(trig, Condition(function Boomerang_Dam_Cond))
    call SetTableObject(strig,"ta", TriggerAddAction(trig, function Boomerang_Dam))
    call SetTableObject(strig,"boom",boom)
    
    call SetTableReal(s,"boomloop",1)
    call SetTableObject(s,"caster",caster)    
    call SetTableObject(s,"boom",boom)
    call SetTableObject(s,"trig",trig)
    call TimerStart(t,.03,true,function Boomerang_Effects)
    
    set caster = null
    call RemoveLocation(boomloc)
    set boomloc = null
    set trig = null
endfunction


And here's the whole trigger

JASS:
function Trig_Boomerang_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A00G'
endfunction
          
function Boomerang_Dam_Cond takes nothing returns boolean
    local string s = GetAttachmentTable(GetTriggeringTrigger())
    return IsUnitEnemy(GetFilterUnit(),GetOwningPlayer(GetTableUnit(s,"boom")))==true and GetUnitState(GetFilterUnit(),UNIT_STATE_LIFE)>0
endfunction

function Boomerang_Dam takes nothing returns nothing
    local string s = GetAttachmentTable(GetTriggeringTrigger())
    local unit boom = GetTableUnit(s,"boom")
    local unit enemy = GetTriggerUnit()
    local real dam = 150
    
    call UnitDamageTarget(boom,enemy,dam,false,false,ATTACK_TYPE_NORMAL,DAMAGE_TYPE_NORMAL,null)
    call DestroyEffect(AddSpecialEffectTarget("Objects\\Spawnmodels\\Human\\HumanBlood\\BloodElfSpellThiefBlood.mdl",enemy,"overhead"))

    set boom = null
    set enemy = null
endfunction
    
function Boomerang_Effects takes nothing returns nothing
    local timer t = GetExpiredTimer()
    local string s = GetAttachmentTable(t)
    local trigger trig
    local string strig
    local unit caster = GetTableUnit(s,"caster")
    local unit boom = GetTableUnit(s,"boom")
    local real boomloop = GetTableReal(s,"boomloop")
    
    call CreateTextTagUnitBJ( "Boomerang", boom, 0, 10, 100, 100, 100, 0 )
    call DisplayTimedTextToForce( GetPlayersAll(), 1.00, "running" )
    call SetUnitPosition(boom, (GetLocationX(GetUnitLoc(caster))+(50+(7.5*(boomloop)))*Cos((8 * (boomloop))*bj_DEGTORAD)),(GetLocationY(GetUnitLoc(caster))+(50+(7.5*(boomloop)))*Sin((8 * (boomloop))*bj_DEGTORAD)))
    set boomloop = boomloop + 1
    
    if boomloop>=200 or GetUnitState(caster,UNIT_STATE_LIFE)<=0 then
        call DisplayTimedTextToForce( GetPlayersAll(), 30.00, "the end" )
        call RemoveUnit(boom)
        set trig = GetTableTrigger(s,"trig")
        set strig = GetAttachmentTable(trig)
        call TriggerRemoveAction(trig,GetTableTriggerAction(strig,"ta"))
        call ClearTable(strig)
        call DestroyTrigger(trig)
        set trig = null
                call ClearTable(s)
        call PauseTimer(t)
        call DestroyTimer(t)
    else
        call SetTableReal(s,"boomloop",boomloop)
    endif
    
    set caster = null
    set boom = null
endfunction
    
function Trig_Boomerang_Actions takes nothing returns nothing
    local unit caster = GetTriggerUnit()
    local real x = GetUnitX(caster)
    local real y = GetUnitY(caster)
    local location boomloc = Location(x + 50, y)
    local trigger trig = CreateTrigger()
    local string strig = GetAttachmentTable(trig)
    local timer t = CreateTimer()
    local string s = GetAttachmentTable(t)
    local unit boom
    
    call CreateUnitAtLoc(GetOwningPlayer(GetTriggerUnit()), 'u001', boomloc, bj_UNIT_FACING)
    set boom = bj_lastCreatedUnit
    
    call TriggerRegisterUnitInRange(trig,boom,150,null)
    call TriggerAddCondition(trig, Condition(function Boomerang_Dam_Cond))
    call SetTableObject(strig,"ta", TriggerAddAction(trig, function Boomerang_Dam))
    call SetTableObject(strig,"boom",boom)
    
    call SetTableReal(s,"boomloop",1)
    call SetTableObject(s,"caster",caster)    
    call SetTableObject(s,"boom",boom)
    call SetTableObject(s,"trig",trig)
    call TimerStart(t,.03,true,function Boomerang_Effects)
    
    set caster = null
    call RemoveLocation(boomloc)
    set boomloc = null
    set trig = null
endfunction


//===========================================================================
function InitTrig_Boomerang takes nothing returns nothing
    set gg_trg_Boomerang = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Boomerang, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Boomerang, Condition( function Trig_Boomerang_Conditions ) )
    call TriggerAddAction( gg_trg_Boomerang, function Trig_Boomerang_Actions )
    call Preload("Objects\\Spawnmodels\\Human\\HumanBlood\\BloodElfSpellThiefBlood.mdl")
endfunction



This is taken and adapted from Emjlr3's dash spell tutorial, btw

If there is other crap that I did inefficiently feel free to let me know :)
Thanks for the help.
 
E

emjlr3

Change can be a good thing
Reaction score
395
a few thoughts

  • use a timer stack
  • use JNGP if you can, then you don't need GC at all
  • you can create and store you unit at the same time
  • use trigger condition only, they do not leak, and you can do all your actions in it alone
  • your leaking two locs everytime you update the position of your boom

the method in that tutorial is still fairly sound, but new advents have made it possible to improve upon the GC and timer useage

you should check it out
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      81 (members: 0, guests: 81)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top