Did I remove the leaks properly

afisakov

afisakov

You can change this now in User CP.
Reaction score
37
Ok, I found a map I like and am trying to clean up some memory leaks in it to make it run smoother. The question is, did I effectively remove the leaks from this trigger and will it still do what it is supposed to do?

trigger supposed function: every 5 seconds damage every unit (not building) on the map by 80 damage for every pestilence unit that has at least 100 mana. I included the original trigger as a reference.

my version
Code: 
Pestilence 2
    Events
        Time - Every 5.00 seconds of game time
    Conditions
    Actions
        Set Temp_Group = (Units of type Pestilence)
        Unit Group - Pick every unit in Temp_Group and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Integer((Mana of (Picked unit)))) Greater than or equal to 100
                    Then - Actions
                        Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - 100.00)
                        Set Pest = (Units in (Playable map area))
                        Unit Group - Pick every unit in Pest and do (Actions)
                            Loop - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        ((Picked unit) is A structure) Equal to False
                                        ((Picked unit) is alive) Equal to True
                                    Then - Actions
                                        Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 80.00)
                                        Special Effect - Create a special effect attached to the overhead of (Triggering unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
                                        Special Effect - Destroy (Last created special effect)
                                    Else - Actions
                        Custom script:   call DestroyGroup(udg_Regen)
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0001 <gen> to ((Life of Mage 0001 <gen>) - 80.00)) else do (Do nothing)
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0004 <gen> to (Real(Life_before_Reverse))) else do (Do nothing)
                    Else - Actions
        Custom script:   call DestroyGroup(udg_Temp_Group)

original trigger
Code: 
Pestilence Auto
    Events
        Time - Every 5.00 seconds of game time
    Conditions
        (Number of units in (Units of type Pestilence)) Greater than 0
    Actions
        Unit Group - Pick every unit in (Units of type Pestilence) and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Integer((Mana of (Picked unit)))) Greater than or equal to 100
                    Then - Actions
                        Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - 100.00)
                        Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
                            Loop - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        ((Picked unit) is A structure) Equal to False
                                        ((Picked unit) is alive) Equal to True
                                    Then - Actions
                                        Unit Group - Add (Picked unit) to Pest
                                    Else - Actions
                        Unit Group - Pick every unit in (Units of type Pestilence) and do (Actions)
                            Loop - Actions
                                Unit Group - Pick every unit in Pest and do (Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 80.00))
                                Unit Group - Pick every unit in Pest and do (Special Effect - Create a special effect attached to the overhead of (Picked unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl)
                                If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0001 <gen> to ((Life of Mage 0001 <gen>) - 80.00)) else do (Do nothing)
                                If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0004 <gen> to (Real(Life_before_Reverse))) else do (Do nothing)
                                Unit Group - Remove all units from Pest
                    Else - Actions
 
afisakov

afisakov

You can change this now in User CP.
Reaction score
37
If setting a unit group to units in map area leaks then how do I remove the leak? I thought the unit group would solve that leak? or is there a third unit group being used somewhere that I failed to spot. Can u please point out the spot if that is the case.
 
Tru_Power22

Tru_Power22

You can change this now in User CP.
Reaction score
144
Set a variable (Units in playable map area) to something. Then use that instead of units in playable map area.
 
afisakov

afisakov

You can change this now in User CP.
Reaction score
37
I thought I did, only see one in the code, did I not do it properly
Code: 
Pestilence 2
    Events
        Time - Every 5.00 seconds of game time
    Conditions
    Actions
        Set Temp_Group = (Units of type Pestilence)
        Unit Group - Pick every unit in Temp_Group and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Integer((Mana of (Picked unit)))) Greater than or equal to 100
                    Then - Actions
                        Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - 100.00)
                        [B]Set Pest = (Units in (Playable map area))
                        Unit Group - Pick every unit in Pest and do (Actions)[/B]
                            Loop - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        ((Picked unit) is A structure) Equal to False
                                        ((Picked unit) is alive) Equal to True
                                    Then - Actions
                                        Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 80.00)
                                        Special Effect - Create a special effect attached to the overhead of (Triggering unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
                                        Special Effect - Destroy (Last created special effect)
                                    Else - Actions
                        Custom script:   call DestroyGroup(udg_Regen)
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0001 <gen> to ((Life of Mage 0001 <gen>) - 80.00)) else do (Do nothing)
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0004 <gen> to (Real(Life_before_Reverse))) else do (Do nothing)
                    Else - Actions
        Custom script:   call DestroyGroup(udg_Temp_Group)
 
afisakov

afisakov

You can change this now in User CP.
Reaction score
37
oops, good catch. I copied and modified another trigger and forgot to change the text from "Regen" to "Pest". Removed it now
Code: 
Pestilence 2
    Events
        Time - Every 5.00 seconds of game time
    Conditions
    Actions
        Set Temp_Group = (Units of type Pestilence)
        Unit Group - Pick every unit in Temp_Group and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Integer((Mana of (Picked unit)))) Greater than or equal to 100
                    Then - Actions
                        Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - 100.00)
                        Set Pest = (Units in (Playable map area))
                        Unit Group - Pick every unit in Pest and do (Actions)
                            Loop - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        ((Picked unit) is A structure) Equal to False
                                        ((Picked unit) is alive) Equal to True
                                    Then - Actions
                                        Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 80.00)
                                        Special Effect - Create a special effect attached to the overhead of (Triggering unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
                                        Special Effect - Destroy (Last created special effect)
                                    Else - Actions
                        Custom script:   call DestroyGroup(udg_[B]Pest[/B])
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0001 <gen> to ((Life of Mage 0001 <gen>) - 80.00)) else do (Do nothing)
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0004 <gen> to (Real(Life_before_Reverse))) else do (Do nothing)
                    Else - Actions
        Custom script:   call DestroyGroup(udg_Temp_Group)
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1

      The Helper Discord

      Members online

      No members online now.
      Online now:
      82 (members: 3, guests: 79)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top