Did I remove the leaks properly

afisakov

afisakov

You can change this now in User CP.
Reaction score
37
Ok, I found a map I like and am trying to clean up some memory leaks in it to make it run smoother. The question is, did I effectively remove the leaks from this trigger and will it still do what it is supposed to do?

trigger supposed function: every 5 seconds damage every unit (not building) on the map by 80 damage for every pestilence unit that has at least 100 mana. I included the original trigger as a reference.

my version
Code: 
Pestilence 2
    Events
        Time - Every 5.00 seconds of game time
    Conditions
    Actions
        Set Temp_Group = (Units of type Pestilence)
        Unit Group - Pick every unit in Temp_Group and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Integer((Mana of (Picked unit)))) Greater than or equal to 100
                    Then - Actions
                        Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - 100.00)
                        Set Pest = (Units in (Playable map area))
                        Unit Group - Pick every unit in Pest and do (Actions)
                            Loop - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        ((Picked unit) is A structure) Equal to False
                                        ((Picked unit) is alive) Equal to True
                                    Then - Actions
                                        Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 80.00)
                                        Special Effect - Create a special effect attached to the overhead of (Triggering unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
                                        Special Effect - Destroy (Last created special effect)
                                    Else - Actions
                        Custom script:   call DestroyGroup(udg_Regen)
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0001 <gen> to ((Life of Mage 0001 <gen>) - 80.00)) else do (Do nothing)
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0004 <gen> to (Real(Life_before_Reverse))) else do (Do nothing)
                    Else - Actions
        Custom script:   call DestroyGroup(udg_Temp_Group)

original trigger
Code: 
Pestilence Auto
    Events
        Time - Every 5.00 seconds of game time
    Conditions
        (Number of units in (Units of type Pestilence)) Greater than 0
    Actions
        Unit Group - Pick every unit in (Units of type Pestilence) and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Integer((Mana of (Picked unit)))) Greater than or equal to 100
                    Then - Actions
                        Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - 100.00)
                        Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
                            Loop - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        ((Picked unit) is A structure) Equal to False
                                        ((Picked unit) is alive) Equal to True
                                    Then - Actions
                                        Unit Group - Add (Picked unit) to Pest
                                    Else - Actions
                        Unit Group - Pick every unit in (Units of type Pestilence) and do (Actions)
                            Loop - Actions
                                Unit Group - Pick every unit in Pest and do (Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 80.00))
                                Unit Group - Pick every unit in Pest and do (Special Effect - Create a special effect attached to the overhead of (Picked unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl)
                                If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0001 <gen> to ((Life of Mage 0001 <gen>) - 80.00)) else do (Do nothing)
                                If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0004 <gen> to (Real(Life_before_Reverse))) else do (Do nothing)
                                Unit Group - Remove all units from Pest
                    Else - Actions
 
If setting a unit group to units in map area leaks then how do I remove the leak? I thought the unit group would solve that leak? or is there a third unit group being used somewhere that I failed to spot. Can u please point out the spot if that is the case.
 
Set a variable (Units in playable map area) to something. Then use that instead of units in playable map area.
 
I thought I did, only see one in the code, did I not do it properly
Code: 
Pestilence 2
    Events
        Time - Every 5.00 seconds of game time
    Conditions
    Actions
        Set Temp_Group = (Units of type Pestilence)
        Unit Group - Pick every unit in Temp_Group and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Integer((Mana of (Picked unit)))) Greater than or equal to 100
                    Then - Actions
                        Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - 100.00)
                        [B]Set Pest = (Units in (Playable map area))
                        Unit Group - Pick every unit in Pest and do (Actions)[/B]
                            Loop - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        ((Picked unit) is A structure) Equal to False
                                        ((Picked unit) is alive) Equal to True
                                    Then - Actions
                                        Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 80.00)
                                        Special Effect - Create a special effect attached to the overhead of (Triggering unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
                                        Special Effect - Destroy (Last created special effect)
                                    Else - Actions
                        Custom script:   call DestroyGroup(udg_Regen)
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0001 <gen> to ((Life of Mage 0001 <gen>) - 80.00)) else do (Do nothing)
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0004 <gen> to (Real(Life_before_Reverse))) else do (Do nothing)
                    Else - Actions
        Custom script:   call DestroyGroup(udg_Temp_Group)
 
oops, good catch. I copied and modified another trigger and forgot to change the text from "Regen" to "Pest". Removed it now
Code: 
Pestilence 2
    Events
        Time - Every 5.00 seconds of game time
    Conditions
    Actions
        Set Temp_Group = (Units of type Pestilence)
        Unit Group - Pick every unit in Temp_Group and do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Integer((Mana of (Picked unit)))) Greater than or equal to 100
                    Then - Actions
                        Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - 100.00)
                        Set Pest = (Units in (Playable map area))
                        Unit Group - Pick every unit in Pest and do (Actions)
                            Loop - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        ((Picked unit) is A structure) Equal to False
                                        ((Picked unit) is alive) Equal to True
                                    Then - Actions
                                        Unit - Set life of (Picked unit) to ((Life of (Picked unit)) - 80.00)
                                        Special Effect - Create a special effect attached to the overhead of (Triggering unit) using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
                                        Special Effect - Destroy (Last created special effect)
                                    Else - Actions
                        Custom script:   call DestroyGroup(udg_[B]Pest[/B])
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0001 <gen> to ((Life of Mage 0001 <gen>) - 80.00)) else do (Do nothing)
                        If ((ReverseDamage effect <gen> is on) Equal to True) then do (Unit - Set life of Mage 0004 <gen> to (Real(Life_before_Reverse))) else do (Do nothing)
                    Else - Actions
        Custom script:   call DestroyGroup(udg_Temp_Group)
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Cool Chicken Pasta recipe - Rattlesnake Pasta https://www.thehelper.net/threads/recipe-rattlesnake-pasta.194694/
  • The Helper The Helper:
    News portal has been retired. Main page of site goes to Headline News forum now
  • The Helper The Helper:
    Added the visually stunning Galaxy Cocktail https://www.thehelper.net/threads/cocktail-galaxy-cocktail.194703/
  • The Helper The Helper:
    I am working on getting access to the old news portal under a different URL for those that would rather use that for news before we get a different news view.
  • Ghan Ghan:
    Easily done
     +1
  • The Helper The Helper:
    https://www.thehelper.net/pages/news/ is a link to the old news portal - i will integrate it into the interface somewhere when i figure it out
  • Ghan Ghan:
    Need to try something
  • Ghan Ghan:
    Hopefully this won't cause problems.
  • Ghan Ghan:
    Hmm
  • Ghan Ghan:
    I have converted the Headline News forum to an Article type forum. It will now show the top 20 threads with more detail of each thread.
  • Ghan Ghan:
    See how we like that.
  • The Helper The Helper:
    I do not see a way to go past the 1st page of posts on the forum though
  • The Helper The Helper:
    It is OK though for the main page to open up on the forum in the view it was before. As long as the portal has its own URL so it can be viewed that way I do want to try it as a regular forum view for a while
  • Ghan Ghan:
    Yeah I'm not sure what the deal is with the pagination.
  • Ghan Ghan:
    It SHOULD be there so I think it might just be an artifact of having an older style.
  • Ghan Ghan:
    I switched it to a "Standard" article forum. This will show the thread list like normal, but the threads themselves will have the first post set up above the rest of the "comments"
  • The Helper The Helper:
    I don't really get that article forum but I think it is because I have never really seen it used on a multi post thread
  • Ghan Ghan:
    RpNation makes more use of it right now as an example: https://www.rpnation.com/news/
  • The Helper The Helper:
    Ok
  • The Helper The Helper:
    www.thehelper.net

    Latest News

    The Helper News Feed
    www.thehelper.net www.thehelper.net
  • The Helper The Helper:
    What do you think Tom?
  • tom_mai78101 tom_mai78101:
    I will have to get used to this.
  • tom_mai78101 tom_mai78101:
    The latest news feed looks good
  • The Helper The Helper:
    I would like to see it again like Ghan had it the first time with pagination though - without the pagination that view will not work but with pagination it just might...
  • The Helper The Helper:
    This drink recipe I have had more than a few times back in the day! Mind Eraser https://www.thehelper.net/threads/cocktail-mind-eraser.194720/

      The Helper Discord

      Staff online

      Members online

      Online now:
      140 (members: 2, guests: 138)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top