Does it leak?

[simonake]

I created a Unit spawn and i wanted to know if the locations leaks. I use the same locations each seconds and they're set at the map initialization. Triggers

zSpawn_UnitType = Unit Type Variable
zTempSpawnPoint = The Location

• Spawning
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 8, do (Actions)
      • Loop - Actions
        • Unit - Create 1 zSpawn_UnitType for Player 12 (Brown) at zTempSpawnPoint[(Integer A)] facing 0.00 degrees

 

[naughty]

no, it doesn't leak but i'm curios why don't u just make create 8 units instead for each integer from 1 to 8?

woops, my mistake i didn't saw that your location is Array. nvm. it doesn't leak

 

[simonake]

It creates 8 units in 8 different points.

nm.

Thx

 

[jig7c]

im curious to know how did you setup your location in the map init trigger...
can you post please...

 

[simonake]

-deleted.

 

[Sneakster]

Wouldn't you have to have:

Custom Script call RemoveLocation (udg_zTempSpawnPoint[1])
Custom Script call RemoveLocation (udg_zTempSpawnPoint[2])
Custom Script call RemoveLocation (udg_zTempSpawnPoint[3])
Custom Script call RemoveLocation (udg_zTempSpawnPoint[4])
Custom Script call RemoveLocation (udg_zTempSpawnPoint[5])
Custom Script call RemoveLocation (udg_zTempSpawnPoint[6])
Custom Script call RemoveLocation (udg_zTempSpawnPoint[7])
Custom Script call RemoveLocation (udg_zTempSpawnPoint[8])

to make it leakless??

 

[Tyrulan]

Yes, but no it's easier.

call RemoveLocation (udg_zTempSpawnPoint[GetForLoopIndexA()])

Throw that in your loop. Lol

 

[Sneakster]

lol ooops

 

[Komaqtion]

No don't remove the location, since it's every second either create the locations each time, or just let them be... this will leak, but only one time

 

[kingkingyyk3]

Loop is slower. Copy and paste 8 actions is faster.

 

[Renendaru]

Afaik, a loop should be faster, but I have been away from GUI for awhile. I'm certain in Jass loops are faster then CnP.

 

[Komaqtion]

I pretty sure this action creates a loop, either way:

• Unit - Create 1 zSpawn_UnitType for Player 12 (Brown) at zTempSpawnPoint[(Integer A)] facing 0.00 degrees

function CreateNUnitsAtLoc takes integer count, integer unitId, player whichPlayer, location loc, real face returns group
    call GroupClear(bj_lastCreatedGroup)
    loop
        set count = count - 1
        exitwhen count < 0
        call CreateUnitAtLocSaveLast(whichPlayer, unitId, loc, face)
        call GroupAddUnit(bj_lastCreatedGroup, bj_lastCreatedUnit)
    endloop
    return bj_lastCreatedGroup
endfunction

That's the converted function, and it creates a loop, so if you use a GUI loop then use a JASS function to create the units then it's even more efficient