Feedback on AoS Spawn system

Bribe

vJass errors are legion
Reaction score
67
I don't hate function interfaces because of how bad the performance is, I hate them because they duplicate your functions! Function interfaces and stub/interface methods in general should be discouraged.

This:

JASS:
library FunctionInterface initializer Init
    
    private function interface FI takes integer arg returns nothing
    
    globals
        private FI array fiStack
        private integer fiCount = 0
    endglobals
    
    function RegisterFI takes FI fi returns nothing
        set fiStack[fiCount] = fi
        set fiCount = fiCount + 1
    endfunction
    
    private function Fire takes nothing returns nothing
        local integer i = fiCount
        loop
            set i = i - 1
            call fiStack[fiCount].execute(GetRandomInt(1, 10))
            exitwhen i == 0
        endloop
    endfunction
    
    private function WallOfText takes integer arg returns nothing
        local integer i = 5
        loop
            set i = i - 1
            call DoNothing()
            call DoNothing()
            call DoNothing()
            call DoNothing()
            call DoNothing()
            exitwhen i == 0
        endloop
    endfunction
    
    private function Init takes nothing returns nothing
        call RegisterFI(WallOfText)
    endfunction
    
endlibrary


Outputs this:

JASS:
globals
constant boolean LIBRARY_FunctionInterface=true
integer array FunctionInterface___fiStack
        integer FunctionInterface___fiCount = 0
trigger array st___prototype1
integer f__arg_integer1
endglobals

function sc___prototype1_execute takes integer i,integer a1 returns nothing
    set f__arg_integer1=a1

    call TriggerExecute(st___prototype1<i>)
endfunction
function sc___prototype1_evaluate takes integer i,integer a1 returns nothing
    set f__arg_integer1=a1

    call TriggerEvaluate(st___prototype1<i>)

endfunction
    
    function RegisterFI takes integer fi returns nothing
        set FunctionInterface___fiStack[FunctionInterface___fiCount]=fi
        set FunctionInterface___fiCount=FunctionInterface___fiCount + 1
    endfunction
    
    function FunctionInterface___Fire takes nothing returns nothing
        local integer i= FunctionInterface___fiCount
        loop
            set i=i - 1
            call sc___prototype1_execute(FunctionInterface___fiStack[FunctionInterface___fiCount],GetRandomInt(1, 10))
            exitwhen i == 0
        endloop
    endfunction
    
    function FunctionInterface___WallOfText takes integer arg returns nothing
        local integer i= 5
        loop
            set i=i - 1
            call DoNothing()
            call DoNothing()
            call DoNothing()
            call DoNothing()
            call DoNothing()
            exitwhen i == 0
        endloop
    endfunction
    
    function FunctionInterface___Init takes nothing returns nothing
        call RegisterFI((1))
    endfunction
    
function sa___prototype1_FunctionInterface___WallOfText takes nothing returns boolean
 local integer arg=f__arg_integer1

        local integer i= 5
        loop
            set i=i - 1
            call DoNothing()
            call DoNothing()
            call DoNothing()
            call DoNothing()
            call DoNothing()
            exitwhen i == 0
        endloop
    return true
endfunction

function jasshelper__initstructs2334779884 takes nothing returns nothing
    set st___prototype1[1]=CreateTrigger()
    call TriggerAddAction(st___prototype1[1],function sa___prototype1_FunctionInterface___WallOfText)
    call TriggerAddCondition(st___prototype1[1],Condition(function sa___prototype1_FunctionInterface___WallOfText))
endfunction</i></i>


Instead of this:

JASS:
library FunctionInterface initializer Init
    
    globals
        private trigger codeTrigger = CreateTrigger()
        private integer eventVar
    endglobals
    
    function RegisterCode takes code c returns nothing
        call TriggerAddAction(codeTrigger, c)
    endfunction
    
    function GetEventVar takes nothing returns integer
        return eventVar
    endfunction
    
    private function Fire takes nothing returns nothing
        set eventVar = GetRandomInt(1, 10)
        call TriggerExecute(codeTrigger)
    endfunction
    
    private function WallOfText takes nothing returns nothing
        local integer arg = GetEventVar()
        local integer i = 5
        loop
            set i = i - 1
            call DoNothing()
            call DoNothing()
            call DoNothing()
            call DoNothing()
            call DoNothing()
            exitwhen i == 0
        endloop
    endfunction
    
    private function Init takes nothing returns nothing
        call RegisterCode(function WallOfText)
    endfunction
    
endlibrary


Which outputs no "ghost code" or senselessly duplicated code.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top