Final trigger, does it leak?

[Edward]

This is the last trigger I will be adding to my map. I would like to know if there are any memory leaks I didn't fix (can sounds leak)?

• Alliance Battle Cry
  • Events
    • Time - Every 600.00 seconds of game time
  • Conditions
  • Actions
    • Countdown Timer - Start AllianceTime as a Repeating timer that will expire in 600.00 seconds
    • Countdown Timer - Create a timer window for AllianceTime with title Alliance Battle Cry...
    • Game - Display to (All players) the text: For Lordearon, For ...
    • Sound - Stop music Immediately
    • Sound - Stop the currently playing music theme
    • Sound - Play 1812at12miuntes36seconds <gen>
    • Set AllianceBattleCry = (Units owned by Player 1 (Red))
    • Set AllianceBattleCry2 = (Units owned by Player 2 (Blue))
    • Set AllianceBattleCry3 = (Units owned by Player 3 (Teal))
    • Set AllianceBattleCry4 = (Units owned by Player 4 (Purple))
    • Set AllianceBattleCry5 = (Units owned by Player 5 (Yellow))
    • Set AllianceBattleCry6 = (Units owned by Player 6 (Orange))
    • Unit Group - Pick every unit in AllianceBattleCry and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to 400.00
        • Unit - Make (Picked unit) Invulnerable
    • Unit Group - Pick every unit in AllianceBattleCry2 and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to 400.00
        • Unit - Make (Picked unit) Invulnerable
    • Unit Group - Pick every unit in AllianceBattleCry3 and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to 400.00
        • Unit - Make (Picked unit) Invulnerable
    • Unit Group - Pick every unit in AllianceBattleCry4 and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to 400.00
        • Unit - Make (Picked unit) Invulnerable
    • Unit Group - Pick every unit in AllianceBattleCry5 and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to 400.00
        • Unit - Make (Picked unit) Invulnerable
    • Unit Group - Pick every unit in AllianceBattleCry6 and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to 400.00
        • Unit - Make (Picked unit) Invulnerable
    • Custom script: call DestroyGroup(udg_AllianceBattleCry)
    • Custom script: call DestroyGroup(udg_AllianceBattleCry2)
    • Custom script: call DestroyGroup(udg_AllianceBattleCry3)
    • Custom script: call DestroyGroup(udg_AllianceBattleCry4)
    • Custom script: call DestroyGroup(udg_AllianceBattleCry5)
    • Custom script: call DestroyGroup(udg_AllianceBattleCry6)
    • Wait 31.00 seconds
    • Sound - Stop 1812at12miuntes36seconds <gen> After fading
    • Sound - Resume music
    • Set AllianceBattleCry = (Units owned by Player 1 (Red))
    • Set AllianceBattleCry2 = (Units owned by Player 2 (Blue))
    • Set AllianceBattleCry3 = (Units owned by Player 3 (Teal))
    • Set AllianceBattleCry4 = (Units owned by Player 4 (Purple))
    • Set AllianceBattleCry5 = (Units owned by Player 5 (Yellow))
    • Set AllianceBattleCry6 = (Units owned by Player 6 (Orange))
    • Unit Group - Pick every unit in AllianceBattleCry and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to (Default movement speed of (Picked unit))
        • Unit - Make (Picked unit) Vulnerable
    • Unit Group - Pick every unit in AllianceBattleCry2 and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to (Default movement speed of (Picked unit))
        • Unit - Make (Picked unit) Vulnerable
    • Unit Group - Pick every unit in AllianceBattleCry3 and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to (Default movement speed of (Picked unit))
        • Unit - Make (Picked unit) Vulnerable
    • Unit Group - Pick every unit in AllianceBattleCry4 and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to (Default movement speed of (Picked unit))
        • Unit - Make (Picked unit) Vulnerable
    • Unit Group - Pick every unit in AllianceBattleCry5 and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to (Default movement speed of (Picked unit))
        • Unit - Make (Picked unit) Vulnerable
    • Unit Group - Pick every unit in AllianceBattleCry6 and do (Actions)
      • Loop - Actions
        • Unit - Set (Picked unit) movement speed to (Default movement speed of (Picked unit))
        • Unit - Make (Picked unit) Vulnerable
    • Custom script: call DestroyGroup(udg_AllianceBattleCry)
    • Custom script: call DestroyGroup(udg_AllianceBattleCry2)
    • Custom script: call DestroyGroup(udg_AllianceBattleCry3)
    • Custom script: call DestroyGroup(udg_AllianceBattleCry4)
    • Custom script: call DestroyGroup(udg_AllianceBattleCry5)
    • Custom script: call DestroyGroup(udg_AllianceBattleCry6)

 

[Pyropenguins]

I see no leaks
And no sounds dont leak

 

[Tru_Power22]

Looks good. I don't see any leaks.

I'm not sure if sounds leak but even if they did this trigger is fired every ten minutes so I can't see this leading to huge amounts of lag.

 

[Edward]

Thank you

Thank you, always wanted to know if sounds leaked.



You both got rep.

 

[Exide]

Why is your trigger so long?
Instead of setting six different unit groups. Start by setting a player group, add all the six players. Then set a unit group to all units who's owner is in that player group.
Then do actions for that unit group.
Then clean up the unit group. (No need to clean up the player group, you can use it next time this trigger fires.)

This will eliminate about ~30 lines of useless code.

Sounds are bad.
I suggest you get rid of them.
Sounds and music (specially music) might cause critical errors. I don't know why.
I'm not saying that the sounds you are using WILL crash your map. I'm just saying there's a risk it might.

I also suggest you get rid of that 31 seconds long wait, in the middle of the trigger.
Add a countdown timer, and create a new trigger. (No need to show the countdown timer in a window.)