Help Trigger Overlap

S

spectre37

New Member
Reaction score
1
I have 2 spells - first one is chanelling heal.

JASS:
function Trig_Ritual_of_Souls_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A03G'
endfunction

function Trig_Ritual_of_Souls_Target takes nothing returns boolean
    if ( not ( IsUnitAlly(GetFilterUnit(), GetOwningPlayer(GetSpellAbilityUnit())) == true ) ) then
    return false
    elseif GetFilterUnit() == GetSpellAbilityUnit() then
    return false
    elseif (not ( IsUnitType(GetFilterUnit(), UNIT_TYPE_HERO) ) ) then 
    return false
    endif 
    return true 
endfunction

function Trig_Ritual_End takes nothing returns nothing
    local unit w
    call DestroyEffect(udg_Ritual)
    loop
        set w = FirstOfGroup(udg_SoulRitual)
        exitwhen w == null
        call GroupRemoveUnit(udg_SoulRitual,w)
        call KillUnit(w)
    endloop
endfunction

function Trig_Ritual_of_Souls_Actions takes nothing returns nothing
    local unit u = GetSpellAbilityUnit()
    local location l = GetUnitLoc(u)
    local trigger  t
    local unit w
    local unit n
    local group g = GetUnitsInRangeOfLocMatching(600 ,l ,Filter(function Trig_Ritual_of_Souls_Target) )
    loop
        set w = FirstOfGroup(g)
        exitwhen w == null
        call GroupRemoveUnit(g,w)
            set n = CreateUnit (Player(bj_PLAYER_NEUTRAL_VICTIM), 'h001', GetUnitX(u), GetUnitY(u), GetUnitFacing(w) )
            call GroupAddUnit(udg_SoulRitual, n)
            call UnitAddAbility(n, 'A03H')
            call SetUnitAbilityLevel( n, 'A03H', GetUnitAbilityLevel(u, 'A03G'))
            call IssueTargetOrder( n, "drain", w )
    endloop
    call AddSpecialEffectTargetUnitBJ( "overhead", u, "Abilities\\Spells\\Undead\\AntiMagicShell\\AntiMagicShell.mdl" )
    set udg_Ritual = GetLastCreatedEffectBJ()
    set t=CreateTrigger()
    call TriggerRegisterUnitEvent(t, u, EVENT_UNIT_SPELL_ENDCAST)
    call TriggerAddAction(t,function Trig_Ritual_End)
    call RemoveLocation(l)
    call DestroyGroup(g)
endfunction

//===========================================================================
function InitTrig_Ritual_of_Souls takes nothing returns nothing
    set gg_trg_Ritual_of_Souls = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Ritual_of_Souls, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Ritual_of_Souls, Condition( function Trig_Ritual_of_Souls_Conditions ) )
    call TriggerAddAction( gg_trg_Ritual_of_Souls, function Trig_Ritual_of_Souls_Actions )
endfunction


and second is spell that make all hero evade every attack. (not channeling)

JASS:

function Wraith_Touch_Conditions takes nothing returns boolean
	return GetSpellAbilityId() == 'A03N'
endfunction

function Wraith_Touch_Filter takes nothing returns boolean
	return IsUnitType(GetFilterUnit(),UNIT_TYPE_HERO) and IsUnitAlly(GetFilterUnit(),GetOwningPlayer(GetTriggerUnit()))
endfunction

function Wraith_Touch_Buff takes nothing returns boolean
	return UnitHasBuffBJ(GetFilterUnit(), 'B00K') == false
endfunction

function Wraith_Touch_Debuff takes nothing returns nothing
	    call UnitRemoveAbility( GetEnumUnit(), 'A03L' )
        call SetUnitVertexColorBJ( GetEnumUnit(), 255, 255, 255, .0 )
        call SetUnitPathing( GetEnumUnit(), true )
endfunction

function Wraith_Touch_End takes nothing returns nothing
    local rect l = GetPlayableMapRect()
    local group g = GetUnitsInRectMatching( l, Filter(function Wraith_Touch_Filter))
    call GroupEnumUnitsInRect(g, l, Filter(function Wraith_Touch_Buff))
    call ForGroup(g, function Wraith_Touch_Debuff)
endfunction

function Wraith_Touch_Actions takes nothing returns nothing
	local unit c = GetTriggerUnit()
	local group g = GetUnitsInRectMatching( GetPlayableMapRect(), Filter(function Wraith_Touch_Filter))
    local trigger t
    local unit u
    local unit n
    loop
        set u = FirstOfGroup(g)
        exitwhen u == null
        call GroupRemoveUnit(g,u)
            set n = CreateUnit(GetOwningPlayer(c),'h001',GetUnitX(u),GetUnitY(u),GetUnitFacing(u))
            call UnitAddAbility(n, 'A03O')
            call SetUnitAbilityLevel(n, 'A03O', GetUnitAbilityLevel(c ,'A03N'))
            call IssueTargetOrder(n, "bloodlust", u)
            call UnitApplyTimedLife(n, 'BTLF', 0.5)
            call SetUnitVertexColorBJ(u, 255, 255, 255, 40.0)
            call SetUnitPathing(u, false)
            call UnitAddAbility(u, 'A03L')
        endloop   
    call DestroyGroup(g)
    set t = CreateTrigger()
    call TriggerRegisterTimerEventPeriodic(t, 1.0)
    call TriggerAddAction(t,function Wraith_Touch_End)
endfunction

//===========================================================================

function InitTrig_Wraith_Touch takes nothing returns nothing
	set gg_trg_Wraith_Touch = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(gg_trg_Wraith_Touch,EVENT_PLAYER_UNIT_SPELL_EFFECT)
	call TriggerAddCondition(gg_trg_Wraith_Touch, Condition(function Wraith_Touch_Conditions))
	call TriggerAddAction(gg_trg_Wraith_Touch,function Wraith_Touch_Actions)
endfunction


If I cast first spell while second spell is already active, it will cause the effect of second spell again. How can I fixed it?
 
RaiJin

RaiJin

New Member
Reaction score
40
you can always use vjass

if your using Newgen editor put a scope. and endscope so it wont interfere with others.



JASS:
scope Ritualofsouls initializer InitTrig_Ritual_of_Souls

function Trig_Ritual_of_Souls_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A03G'
endfunction

function Trig_Ritual_of_Souls_Target takes nothing returns boolean
    if ( not ( IsUnitAlly(GetFilterUnit(), GetOwningPlayer(GetSpellAbilityUnit())) == true ) ) then
    return false
    elseif GetFilterUnit() == GetSpellAbilityUnit() then
    return false
    elseif (not ( IsUnitType(GetFilterUnit(), UNIT_TYPE_HERO) ) ) then 
    return false
    endif 
    return true 
endfunction

function Trig_Ritual_End takes nothing returns nothing
    local unit w
    call DestroyEffect(udg_Ritual)
    loop
        set w = FirstOfGroup(udg_SoulRitual)
        exitwhen w == null
        call GroupRemoveUnit(udg_SoulRitual,w)
        call KillUnit(w)
    endloop
endfunction

function Trig_Ritual_of_Souls_Actions takes nothing returns nothing
    local unit u = GetSpellAbilityUnit()
    local location l = GetUnitLoc(u)
    local trigger  t
    local unit w
    local unit n
    local group g = GetUnitsInRangeOfLocMatching(600 ,l ,Filter(function Trig_Ritual_of_Souls_Target) )
    loop
        set w = FirstOfGroup(g)
        exitwhen w == null
        call GroupRemoveUnit(g,w)
            set n = CreateUnit (Player(bj_PLAYER_NEUTRAL_VICTIM), 'h001', GetUnitX(u), GetUnitY(u), GetUnitFacing(w) )
            call GroupAddUnit(udg_SoulRitual, n)
            call UnitAddAbility(n, 'A03H')
            call SetUnitAbilityLevel( n, 'A03H', GetUnitAbilityLevel(u, 'A03G'))
            call IssueTargetOrder( n, "drain", w )
    endloop
    call AddSpecialEffectTargetUnitBJ( "overhead", u, "Abilities\\Spells\\Undead\\AntiMagicShell\\AntiMagicShell.mdl" )
    set udg_Ritual = GetLastCreatedEffectBJ()
    set t=CreateTrigger()
    call TriggerRegisterUnitEvent(t, u, EVENT_UNIT_SPELL_ENDCAST)
    call TriggerAddAction(t,function Trig_Ritual_End)
    call RemoveLocation(l)
    call DestroyGroup(g)
endfunction

//===========================================================================
function InitTrig_Ritual_of_Souls takes nothing returns nothing
    set gg_trg_Ritual_of_Souls = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Ritual_of_Souls, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Ritual_of_Souls, Condition( function Trig_Ritual_of_Souls_Conditions ) )
    call TriggerAddAction( gg_trg_Ritual_of_Souls, function Trig_Ritual_of_Souls_Actions )
endfunction

endscope
 
S

spectre37

New Member
Reaction score
1
Still doesn't work :(

I Have other problem

1.) How can I destroy effect on Ritual of Soul (Spell 1) without using variables udg.

2.) Wraith's Touch (Spell 2) causing lag on first cast, and doesn't work sometime.
 
Azlier

Azlier

Old World Ghost
Reaction score
461
Well, then you must attach the effect to... what? You are creating a trigger with a periodic event to fuel the spell? What?! Use something like TimerUtils... Just, please, don't make new triggers just to act as timers. Anyway, you must attach the effect to the timer.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Staff online

      Members online

      Online now:
      80 (members: 3, guests: 77)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top