Help with first real vjass attempt

BRUTAL · Jan 28, 2009

all the red parts?
yea sure lol

(well red when you look in newgen)

Kenny · Jan 28, 2009

You should look into changing all those BJ's into their natives also.
I could probably help you with some of that, if you want.

Holy crap!! They are all BJ's... i didnt even notice. You should certaintly fix that.

TriggerHappy · Jan 28, 2009

Yes.

Hold control and move your mouse over the BJ, click it.

It will have the equivalent functions made up to make the BJ.

WolfieeifloW · Jan 28, 2009

BRUTAL said:
all the red parts?
yea sure lol (well red when you look in newgen)

Alright, could you post your current code

?

kenny! said:
Holy crap!! They are all BJ's... i didnt even notice. You should certaintly fix that.

Lmao

!

BRUTAL · Jan 28, 2009

Yes.

Hold control and move your mouse over the BJ, click it.

It will have the equivalent functions made up to make the BJ.

alright, i dont understand what i see though, example:

JASS:

call UnitAddAbilityBJ( &#039;A002&#039;, GetLastCreatedUnit() )

JASS:

function UnitAddAbilityBJ takes integer abilityId, unit whichUnit returns boolean
    return UnitAddAbility(whichUnit, abilityId)
endfunction

would the 3 lined function be native

and heres my code so far

JASS:

scope IceTrap initializer Init

//   ________________________________________
// ||                                        ||
// || Modify below                           ||
// ||________________________________________||

globals
    private constant integer Spellid = &#039;A001&#039;      // Raw code of Ice Trap ability
    private constant integer Dummyid = &#039;h007&#039;     // Raw code of Ice Trap ability
    private constant real MaxUnits   = 360       // Number of units made to complete the circle, 1 unit = 10
    private constant real AOE        = 290      //Base AOE of spell, each level AOE gets bigger
endglobals
  
//   ________________________________________
// ||                                        ||
// || Do not modify                          ||
// ||________________________________________||

private function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == Spellid
endfunction

function Actions takes nothing returns nothing
    local unit ITCaster = GetSpellAbilityUnit()
    local real ITDuration = (6 + (3 * I2R(GetUnitAbilityLevelSwapped(&#039;A001&#039;, ITCaster))))
    local location ITTargetPoint = GetSpellTargetLoc()
    local real ITTimer = 0
    local real ITAngle = ( GetUnitFacing(ITCaster) + 140.00 )    
    local location ITTargetPos = PolarProjectionBJ(ITTargetPoint, ( AOE + ( I2R(GetUnitAbilityLevelSwapped(&#039;A001&#039;, ITCaster)) * 20.00 ) ), ITAngle)
    local rect ITCreateRect = RectFromCenterSizeBJ(ITTargetPoint, 100.00, 100.00)
    call SetUnitFacingToFaceLocTimed( ITCaster, ITTargetPoint, 0 )
    call AddWeatherEffectSaveLast( ITCreateRect, &#039;SNls&#039; )
    call EnableWeatherEffect( GetLastCreatedWeatherEffect(), true )
    call RemoveRect ( ITCreateRect )
    loop
        exitwhen ITTimer == MaxUnits
            set ITTimer = (ITTimer + 10)
            set ITTargetPos = PolarProjectionBJ(ITTargetPoint, ( AOE + ( I2R(GetUnitAbilityLevelSwapped(&#039;A001&#039;, ITCaster)) * 20.00 ) ), (ITAngle + ITTimer ))
            call CreateNUnitsAtLocFacingLocBJ( 1, Dummyid, GetOwningPlayer(ITCaster), ITTargetPos, ITTargetPoint )
            call UnitAddAbilityBJ( &#039;A002&#039;, GetLastCreatedUnit() )
            call SetUnitAbilityLevelSwapped( &#039;A002&#039;, GetLastCreatedUnit(), GetUnitAbilityLevelSwapped(&#039;A001&#039;, ITCaster) )
            call IssueImmediateOrderBJ( GetLastCreatedUnit(), &quot;immolation&quot; )
            call UnitApplyTimedLifeBJ( ( ITDuration), &#039;BTLF&#039;, GetLastCreatedUnit() )
            call SetTerrainPathableBJ( ITTargetPos, PATHING_TYPE_WALKABILITY, false )
            call RemoveLocation (ITTargetPos) 
            call TriggerSleepAction(0.01)
        endloop
    call RemoveLocation (ITTargetPoint)   
    set ITCaster = null
endfunction


//===========================================================================
private function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(t, Condition(function Conditions))
    call TriggerAddAction(t, function Actions)
endfunction

endscope

Kenny · Jan 28, 2009

what:

JASS:

function UnitAddAbilityBJ takes integer abilityId, unit whichUnit returns boolean
    return UnitAddAbility(whichUnit, abilityId)
endfunction

is saying is that UnitAddAbilityBJ() is just the same as UnitAddAbility, except the arguements are switched around.

BRUTAL · Jan 28, 2009

ah thanks
that makes much more sense

WolfieeifloW · Jan 28, 2009

Here you go:

JASS:

scope IceTrap initializer Init

//   ________________________________________
// ||                                        ||
// || Modify below                           ||
// ||________________________________________||

globals
    private constant integer Spellid = &#039;A001&#039;      // Raw code of Ice Trap ability
    private constant integer Dummyid = &#039;h007&#039;     // Raw code of Ice Trap ability
    private constant real MaxUnits   = 360       // Number of units made to complete the circle, 1 unit = 10
    private constant real AOE        = 290      //Base AOE of spell, each level AOE gets bigger
endglobals
  
//   ________________________________________
// ||                                        ||
// || Do not modify                          ||
// ||________________________________________||

private function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == Spellid
endfunction

function Actions takes nothing returns nothing
    local unit ITCaster = GetSpellAbilityUnit()
    //local real ITDuration = (6 + (3 * I2R(GetUnitAbilityLevelSwapped(&#039;A001&#039;, ITCaster))))
    local real ITDuration = (6 + (3 * I2R(GetUnitAbilityLevel(ITCaster, Spellid))))
    local location ITTargetPoint = GetSpellTargetLoc()
    local real ITTimer = 0
    local real ITAngle = ( GetUnitFacing(ITCaster) + 140.00 )    
    //local location ITTargetPos = PolarProjectionBJ(ITTargetPoint, ( AOE + ( I2R(GetUnitAbilityLevelSwapped(&#039;A001&#039;, ITCaster)) * 20.00 ) ), ITAngle)
    local location ITTargetPos = PolarProjectionBJ(ITTargetPoint, (AOE + (I2R(GetUnitAbilityLevel(ITCaster, Spellid)) * 20.00)), ITAngle)
    local rect ITCreateRect = RectFromCenterSizeBJ(ITTargetPoint, 100.00, 100.00)
    // I don&#039;t know how to fix Rect BJ&#039;s, sorry.
    call SetUnitFacingToFaceLocTimed( ITCaster, ITTargetPoint, 0 )
    // Don&#039;t know how to fix above one either, sorry :| .
    call AddWeatherEffectSaveLast( ITCreateRect, &#039;SNls&#039; )
    // This one either, god I suck...
    //call EnableWeatherEffect( GetLastCreatedWeatherEffect(), true )
    call EnableWeatherEffect(bj_lastCreatedWeatherEffect, true)
    call RemoveRect ( ITCreateRect )
    loop
        exitwhen ITTimer == MaxUnits
            set ITTimer = (ITTimer + 10)
            //set ITTargetPos = PolarProjectionBJ(ITTargetPoint, ( AOE + ( I2R(GetUnitAbilityLevelSwapped(&#039;A001&#039;, ITCaster)) * 20.00 ) ), (ITAngle + ITTimer ))
            set ITTargetPos = PolarProjectionBJ(ITTargetPoint, (AOE + (I2R(GetUnitAbilityLevel(ITCaster, Spellid)) * 20.00)), (ITAngle + ITTimer))
            call CreateNUnitsAtLocFacingLocBJ( 1, Dummyid, GetOwningPlayer(ITCaster), ITTargetPos, ITTargetPoint )
            // Can&#039;t remember how to fix Create units...
            //call UnitAddAbilityBJ( &#039;A002&#039;, GetLastCreatedUnit() )
            call UnitAddAbility(bj_lastCreatedUnit, &#039;A002&#039;)
            //call SetUnitAbilityLevelSwapped( &#039;A002&#039;, GetLastCreatedUnit(), GetUnitAbilityLevelSwapped(&#039;A001&#039;, ITCaster) )
            call SetUnitAbilityLevel(bj_lastCreatedUnit, &#039;A002&#039;, GetUnitAbilityLevel(ITCaster, Spellid))
            //call IssueImmediateOrderBJ( GetLastCreatedUnit(), &quot;immolation&quot; )
            call IssueImmediateOrder(bj_lastCreatedUnit, &quot;immolation&quot;)
            //call UnitApplyTimedLifeBJ( ( ITDuration), &#039;BTLF&#039;, GetLastCreatedUnit() )
            call UnitApplyTimedLife(bj_lastCreatedUnit, &#039;BTLF&#039;, ITDuration)
            call SetTerrainPathableBJ( ITTargetPos, PATHING_TYPE_WALKABILITY, false )
            // Can&#039;t fix terrain pathable either, sorry.
            call RemoveLocation (ITTargetPos) 
            call TriggerSleepAction(0.01)
        endloop
    call RemoveLocation (ITTargetPoint)   
    set ITCaster = null
endfunction


//===========================================================================
private function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(t, Condition(function Conditions))
    call TriggerAddAction(t, function Actions)
endfunction

endscope

When you declare 'A001' as a global, use it

!
There was a bunch of things I couldn't fix, sorry.

TriggerHappy · Jan 28, 2009

PolarProjectionBJ can still be changed.

BRUTAL · Jan 28, 2009

ops XD
thanks anyways ;o
but i noticed now everything has like bj_ as a prefix, like when your referencing lastcrated unit, or weathereffect, is that how its supposed to be? i thought bjs were bad

TriggerHappy · Jan 28, 2009

The ones that look like...

bj_someWierdName

are pre-defined constants, in more simple terms..

they are pre-defined variables.

BJ Functions are generally bad, not constants.

WolfieeifloW · Jan 28, 2009

I fixed the unit spawn:
Add these locals in:

JASS:

local real x = GetLocationX(ITTargetPoint)
local real y = GetLocationY(ITTargetPoint)

Then do this:

JASS:

//call CreateNUnitsAtLocFacingLocBJ( 1, Dummyid, GetOwningPlayer(ITCaster), ITTargetPos, ITTargetPoint )
call CreateUnit(GetOwningPlayer(ITCaster), Dummyid, x, y, GetUnitFacing(ITCaster))

!

TriggerHappy · Jan 28, 2009

It would be better to completely remove locations when using jass.

Since your using jass, use coordinates.

BRUTAL · Jan 28, 2009

The ones that look like...

bj_someWierdName

are pre-defined constants, in more simple terms..

they are pre-defined variables.

BJ Functions are generally bad, not constants.

so predefined constants are good? XD
and
oh yea like x/y points are better then locations right

TriggerHappy · Jan 28, 2009

so predefined constants are good? XD

A lot are useful.

yea like x/y points are better then locations right

Yes.

WolfieeifloW · Jan 28, 2009

Try and always use X/Y instead of locations.

Help with first real vjass attempt

BRUTAL

I'm working

Kenny

Back for now.

TriggerHappy

...

WolfieeifloW

WEHZ Helper

BRUTAL

I'm working

Kenny

Back for now.

BRUTAL

I'm working

WolfieeifloW

WEHZ Helper

TriggerHappy

...

BRUTAL

I'm working

TriggerHappy

...

WolfieeifloW

WEHZ Helper

TriggerHappy

...

BRUTAL

I'm working

TriggerHappy

...

WolfieeifloW

WEHZ Helper

Settings Notifications

Options

The Helper Discord

Members online

Share this page

Affiliates

Network Sponsors

Help with first real vjass attempt

I'm working

Back for now.

...

WEHZ Helper

I'm working

Back for now.

I'm working

WEHZ Helper

...

I'm working

...

WEHZ Helper

...

I'm working

...

WEHZ Helper

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors