Help

Ulla_t

Member
Reaction score
1
I know this is simple, but it doesent work at all.

Trigger:
  • SlimesKillSpawn
    • Events
    • Destructible - A destructible within SlimeRegion <gen> dies
    • Conditions
    • (Destructible-type of (Dying destructible)) Equal to Demon Egg
    • (Destructible-type of (Dying destructible)) Equal to Demon Egg
    • Actions
    • Unit - Create 1 Demon (Level 1) for Neutral Hostile at (Position of (Dying destructible)) facing (Center of SlimeRegion <gen>)
 

Accname

2D-Graphics enthusiast
Reaction score
1,463
The event does only work for the 64 first created destructibles in the area. This part was sloppy scripted by blizzard.
You would have to manually pick all destructibles in the area and add the event (<Picked Destructible> dies) to your trigger for each destructible picked.

You also have 2 conditions which look alike. If those are 2 different destructible types with equal names that would also be a problem since those two conditions are linked with an "and" statement and a destructible could never be of the same type as 2 different destructibles.
 

Ulla_t

Member
Reaction score
1
Well the problem is that i use a refresh trigger, everytime a team fails killing the 'slime Eggs'(Destrictible) they will refresh (Rebuild themself). So it will always be new Eggs, so i cant pick them manually.
 

Accname

2D-Graphics enthusiast
Reaction score
1,463
When creating a new one add its death event to the trigger.
This will, however, leak event handles. But those arent the "biggest" memory leaks.
 

GFreak45

I didnt slap you, i high 5'd your face.
Reaction score
130
are you use JNGP? if you are i could write a quick library that would give you a custom script you could use to avoid that leak caused by adding hundreds of events to the same trigger

if you are this should work, create a new trigger, edit->convert to custom text, delete whats inside and paste this:

JASS:
library EventLeakStopper
    
    globals
        private constant integer SPAWN_ID = &#039;hfoo&#039;
        //This is the only thing you adjust, it is the supposed to be set to the raw data id of the unit spawned
        //replace the &#039;hfoo&#039; with &#039;[id of demon unit type]&#039;, inside the apostraphes
        //you can get the raw data id of a unit type by finding it in the object editor, then going to View/Show Raw Data, or something to that effect
    endglobals
    
    private function Actions takes nothing returns boolean
        call CreateUnit(PLAYER_NEUTRAL_AGGRESSIVE, SPAWN_ID, GetDestructableX(GetTriggerDestructable()), GetDestructableY(GetTriggerDestructable()), 0)
        call DestroyTrigger(GetTriggeringTrigger())
        return false
    endfunction
    
    public function AddEggEvent takes destructable d returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterDeathEvent(t, d)
        call TriggerAddCondition(t, Filter(function Actions))
        t = null
    endfunction
    
endlibrary

then you can use the custom script: call AddEggEvent (udg_Destructable)
 

GFreak45

I didnt slap you, i high 5'd your face.
Reaction score
130
Reposting because i had to edit the submitted code, there was a logic error in it that would cause it to not work, if you were using it already replace it with what is there now

The library right there will actually stop leaks generated by the GUI trigger editor period, whereas every gui trigger will leak no matter what unfortunately

you call this on the eggs when they are created, set the egg to a variable then call the custom script on the variable
 

Ulla_t

Member
Reaction score
1
I'm really sorry, but i fixed it yesterday, by making the 'Eggs' Into units instead, thanks for the great replies anyway! :)
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top