How come my units don't spawn right?

turok255

turok255

New Member
Reaction score
30
So im back from WoW for awhile and im going to finish this map I started on a couple months ago...

Heres the trigger that makes is supposed to spawn a unit if a dummy unit is on the field...
Code: 
Night Elves
    Events
        Time - Every 5.00 seconds of game time
    Conditions
    Actions
        -------- NIGHT ELVES --------
        Set TempUnitGroup = (Units of type Night Elf ( Dummy 1 ))
        Unit Group - Pick every unit in TempUnitGroup and do (Actions)
            Loop - Actions
                Unit - Create 1 Archer for (Owner of (Picked unit)) at ((Owner of (Picked unit)) start location) facing Default building facing degrees
        Custom script:   call DestroyGroup (udg_TempUnitGroup)
        -------- --------------------- --------
        Set TempUnitGroup = (Units of type Night Elf ( Dummy 2 ))
        Unit Group - Pick every unit in TempUnitGroup and do (Actions)
            Loop - Actions
                Unit - Create 1 Huntress for (Owner of (Picked unit)) at ((Owner of (Picked unit)) start location) facing Default building facing degrees
        Custom script:   call DestroyGroup (udg_TempUnitGroup)
        -------- --------------------- --------
        Set TempUnitGroup = (Units of type Night Elf ( Dummy 3 ))
        Unit Group - Pick every unit in TempUnitGroup and do (Actions)
            Loop - Actions
                Unit - Create 2 Dryad for (Owner of (Picked unit)) at ((Owner of (Picked unit)) start location) facing Default building facing degrees
        Custom script:   call DestroyGroup (udg_TempUnitGroup)
        -------- --------------------- --------
        Set TempUnitGroup = (Units of type Night Elf ( Dummy 4 ))
        Unit Group - Pick every unit in TempUnitGroup and do (Actions)
            Loop - Actions
                Unit - Create 1 Druid of the Claw (Night Elf Form) for (Owner of (Picked unit)) at ((Owner of (Picked unit)) start location) facing Default building facing degrees
        Custom script:   call DestroyGroup (udg_TempUnitGroup)
        -------- --------------------- --------
        Set TempUnitGroup = (Units of type Night Elf ( Dummy 5 ))
        Unit Group - Pick every unit in TempUnitGroup and do (Actions)
            Loop - Actions
                Unit - Create 1 Druid of the Talon (Night Elf Form) for (Owner of (Picked unit)) at ((Owner of (Picked unit)) start location) facing Default building facing degrees
        Custom script:   call DestroyGroup (udg_TempUnitGroup)
        -------- --------------------- --------
        Set TempUnitGroup = (Units of type Night Elf ( Dummy 6 ))
        Unit Group - Pick every unit in TempUnitGroup and do (Actions)
            Loop - Actions
                Unit - Create 1 Mountain Giant for (Owner of (Picked unit)) at ((Owner of (Picked unit)) start location) facing Default building facing degrees
        Custom script:   call DestroyGroup (udg_TempUnitGroup)
        -------- --------------------- --------
        Set TempUnitGroup = (Units of type Night Elf ( Dummy 7 ))
        Unit Group - Pick every unit in TempUnitGroup and do (Actions)
            Loop - Actions
                Unit - Create 1 Chimaera for (Owner of (Picked unit)) at ((Owner of (Picked unit)) start location) facing Default building facing degrees
        Custom script:   call DestroyGroup (udg_TempUnitGroup)

Here is the trigger to upgrade units to tier 2.

Code: 
Tier 2
    Events
        Unit - A unit Dies
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Kill_Count[Player_Number] Equal to 250
            Then - Actions
                Set Tier[Player_Number] = (Tier[Player_Number] + 1)
                Multiboard - Set the text for Multiboard item in column 2, row Player_Row to (Players_ColorCodes[Player_Color] + ((String(Tier[Player_Number])) + ColorCodes_EndTag))
                -------- Human - Tier 2 --------
                Unit Group - Pick every unit in (Units in Dummy Race Units <gen> owned by (Owner of (Killing unit))) and do (Actions)
                    Loop - Actions
                        Unit - Remove (Picked unit) from the game
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Human ( Dummy 1 )
                            Then - Actions
                                Unit - Create 1 Human ( Dummy 2 ) for (Owner of (Killing unit)) at (Center of Dummy Race Units <gen>) facing Default building facing degrees
                            Else - Actions
                -------- Orc - Tier 2 --------
                Unit Group - Pick every unit in (Units in Dummy Race Units <gen> owned by (Owner of (Killing unit))) and do (Actions)
                    Loop - Actions
                        Unit - Remove (Picked unit) from the game
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Orc ( Dummy 1 )
                            Then - Actions
                                Unit - Create 1 Orc ( Dummy 2 ) for (Owner of (Killing unit)) at (Center of Dummy Race Units <gen>) facing Default building facing degrees
                            Else - Actions
                -------- Undead - Tier 2 --------
                Unit Group - Pick every unit in (Units in Dummy Race Units <gen> owned by (Owner of (Killing unit))) and do (Actions)
                    Loop - Actions
                        Unit - Remove (Picked unit) from the game
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Undead ( Dummy 1 )
                            Then - Actions
                                Unit - Create 1 Undead ( Dummy 2 ) for (Owner of (Killing unit)) at (Center of Dummy Race Units <gen>) facing Default building facing degrees
                            Else - Actions
                -------- Night Elf - Tier 2 --------
                Unit Group - Pick every unit in (Units in Dummy Race Units <gen> owned by (Owner of (Killing unit))) and do (Actions)
                    Loop - Actions
                        Unit - Remove (Picked unit) from the game
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Night Elf ( Dummy 1 )
                            Then - Actions
                                Unit - Create 1 Night Elf ( Dummy 2 ) for (Owner of (Killing unit)) at (Center of Dummy Race Units <gen>) facing Default building facing degrees
                            Else - Actions
                -------- Naga - Tier 2 --------
                Unit Group - Pick every unit in (Units in Dummy Race Units <gen> owned by (Owner of (Killing unit))) and do (Actions)
                    Loop - Actions
                        Unit - Remove (Picked unit) from the game
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Naga ( Dummy 1 )
                            Then - Actions
                                Unit - Create 1 Naga ( Dummy 2 ) for (Owner of (Killing unit)) at (Center of Dummy Race Units <gen>) facing Default building facing degrees
                            Else - Actions
                -------- Demon - Tier 2 --------
                Unit Group - Pick every unit in (Units in Dummy Race Units <gen> owned by (Owner of (Killing unit))) and do (Actions)
                    Loop - Actions
                        Unit - Remove (Picked unit) from the game
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Demon ( Dummy 1 )
                            Then - Actions
                                Unit - Create 1 Demon ( Dummy 2 ) for (Owner of (Killing unit)) at (Center of Dummy Race Units <gen>) facing Default building facing degrees
                            Else - Actions
                -------- Creep - Tier 2 --------
                Unit Group - Pick every unit in (Units in Dummy Race Units <gen> owned by (Owner of (Killing unit))) and do (Actions)
                    Loop - Actions
                        Unit - Remove (Picked unit) from the game
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Creep ( Dummy 1 )
                            Then - Actions
                                Unit - Create 1 Creep ( Dummy 2 ) for (Owner of (Killing unit)) at (Center of Dummy Race Units <gen>) facing Default building facing degrees
                            Else - Actions
            Else - Actions

The second trigger as far as I can tell works... When I get 250 kills my multiboard shows me having tier 2 but the night elf archers keep spawning instead of the huntressess that are supposed to.

So what I want it to do is...

When a player reaches 250 kills, It removes the tier 1 dummy and makes a tier 2 dummy.. Then it starts to spawn tier 2 units...
 
A

averes

New Member
Reaction score
17
Try adding Locust to the picked unit, creating the next tier unit at that location, and THEN removing the picked unit from the game. I'm pretty sure once you remove it, its no longer considered the "Picked Unit"

Edit: Didn't notice you didn't create the next tier of unit at the location of the picked unit, in which case Locust doesn't need to be added.
 
turok255

turok255

New Member
Reaction score
30
Alright just I just did some testing... I made a new trigger to make a barracks at the start just to see if my tier trigger was messed up and its not.. Its my spawning trigger... But my Tier 1 for any race is just fine.. Its the second tier of units that never spawns. Any ideas?
 
vypur85

vypur85

Hibernate
Reaction score
803
Does the units have Locust? Locust units cannot be picked using this method:
Code: 
Unit Group - Pick every unit in (Units in Dummy Race Units <gen> owned by (Owner of (Killing unit))) and do (Actions)

but can be picked using this:
Code: 
Set TempUnitGroup = (Units of type Night Elf ( Dummy 3 ))

Use 'Unit group - Pick units of Type' instead. Maybe that's why your first trigger works while your second doesn't.
 
turok255

turok255

New Member
Reaction score
30
Tried that didn't work... Its like the trigger stops working at the line to make the unit... Everything higher up than it works...:banghead:

EDIT: It removes my dummy unit already on the map and all that good stuff... Just never makes a new dummy unit.
 
AceHart

AceHart

Your Friendly Neighborhood Admin
Reaction score
1,495
Start location leaks a point.


> The second trigger as far as I can tell works...

Player_Number and Player_Color aren't set.

Removing a unit, then testing for its type is probably not a good idea.

You could put all the "if"s into one "pick" loop.
Actually, you could also pick all dummy 1 and use "unit - replace", no testing needed.

Or get some inspiration from Orc Berserkers and just set the level of some upgrades...
 
turok255

turok255

New Member
Reaction score
30
Hmmm I need to brush up on my codeing... I took a break for a few months and played WoW and it seems im a bit rusty :rolleyes:. Anyways thanks a ton Ace, This trigger works perfectly and I set the variables at map initialization.

Code: 
Tier 2
    Events
        Unit - A unit Dies
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Kill_Count[Player_Number] Equal to 250
            Then - Actions
                Set Tier[Player_Number] = (Tier[Player_Number] + 1)
                Multiboard - Set the text for Multiboard item in column 2, row Player_Row to (Players_ColorCodes[Player_Color] + ((String(Tier[Player_Number])) + ColorCodes_EndTag))
                Unit Group - Pick every unit in (Units in Dummy Race Units <gen> owned by (Owner of (Killing unit))) and do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Human ( Dummy 1 )
                            Then - Actions
                                Unit - Replace (Picked unit) with a Human ( Dummy 2 ) using The old unit's relative life and mana
                            Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Orc ( Dummy 1 )
                            Then - Actions
                                Unit - Replace (Picked unit) with a Orc ( Dummy 2 ) using The old unit's relative life and mana
                            Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Undead ( Dummy 1 )
                            Then - Actions
                                Unit - Replace (Picked unit) with a Undead ( Dummy 2 ) using The old unit's relative life and mana
                            Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Night Elf ( Dummy 1 )
                            Then - Actions
                                Unit - Replace (Picked unit) with a Night Elf ( Dummy 2 ) using The old unit's relative life and mana
                            Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Demon ( Dummy 1 )
                            Then - Actions
                                Unit - Replace (Picked unit) with a Demon ( Dummy 2 ) using The old unit's relative life and mana
                            Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Unit-type of (Picked unit)) Equal to Creep ( Dummy 1 )
                            Then - Actions
                                Unit - Replace (Picked unit) with a Creep ( Dummy 2 ) using The old unit's relative life and mana
                            Else - Actions
            Else - Actions

Also gunna set a variable and get rid of start location.
 
AceHart

AceHart

Your Friendly Neighborhood Admin
Reaction score
1,495
> I set the variables at map initialization

Doesn't sound like it would work with more than one player...
You sure you don't want to set them as first action in the "dies" trigger? Just in case you use them elsewhere too?
 
turok255

turok255

New Member
Reaction score
30
AceHart said:
> I set the variables at map initialization

Doesn't sound like it would work with more than one player...
You sure you don't want to set them as first action in the "dies" trigger? Just in case you use them elsewhere too?
Click to expand...

Good point. I'll change that ;)
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Staff online

      Members online

      Online now:
      238 (members: 1, guests: 237)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top