how do I remove this leak?

[Cokemonkey11]

According to leakchecker this is a leak:

Set pointFootyLeaderLastPOS[(Integer B)] = (Position of unitFootyLeader[(Integer B)])

This is in a trigger that runs 100 times per second so it's important I get it fixed.

Thanks,

 

[Azylaminaz]

call RemoveLocation (udg_pointFootyLeaderLastPOS[GetForLoopIndexB()])

Not much a reason for 0.01 second loop, 0.02 is not even a noticable change, but requires half the computing power.

 

[THE_X]

call RemoveLocation (udg_pointFootyLeaderLastPOS[GetForLoopIndexB()])

aww beat to the punch

 

[Cokemonkey11]

every other leak i've ever gotten into i could remove using variables (no "custom script" required)

Is this the only way to remove this leak?

 

[shinami]

every other leak i've ever gotten into i could remove using variables (no "custom script" required)

Is this the only way to remove this leak?

Yes. Why do you want it in another way? :nuts:

 

[Artificial]

every other leak i've ever gotten into i could remove using variables (no "custom script" required)

Umm... Special effects are like the only leaks GUI can handle without that Custom script line.

And in case you want to make it a bit faster than those two guys suggested:

Custom script:   call RemoveLocation(udg_pointFootyLeaderLastPOS[[i]bj_forLoopBIndex[/i]])

 

[Cokemonkey11]

every other leak i've experianced can be removed without the use of custom code and/or jass/scripts.

Let's get an example.

faketrig
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Unit Group - Pick every unit in (Units in (Rect centered at ((Position of Peasant 0000 <gen>) offset by ((Random real number between 15.00 and 25.00), (Random real number between -500.00 and 500.00))) with size (250.00, 250.00))) and do (Actions)
            Loop - Actions
                Unit - Order (Picked unit) to Move To ((Position of (Picked unit)) offset by 500.00 towards (Facing of (Picked unit)) degrees)

this is possibly the leakiest trigger I know how to make.

5 leaks in 1 action. I can get 100x the leaks just by changing the event.

This can be removed by creating an using 5 variables.

faketrig
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Set realX = (Real((Random integer number between -15 and 15)))
        Set realY = (Real((Random integer number between -500 and 500)))
        Set rectOffsetOfPeasant = ((Rect centered at (Position of Peasant 0000 <gen>) with size (250.00, 250.00)) offset by (realX, realY))
        Set unitGroupInRectAtPeasant = (Units in rectOffsetOfPeasant)
        Unit Group - Pick every unit in unitGroupInRectAtPeasant and do (Actions)
            Loop - Actions
                Set pointPositionOfPickedUnit = (Position of (Picked unit))
                Unit - Order (Picked unit) to Move To (pointPositionOfPickedUnit offset by 500.00 towards (Facing of (Picked unit)) degrees)

Hope that makes sense.

If you know of a way using GUI only (probably with variables such as these) to remove the leak let me know.

 

[Squishy]

Just setting variables doesn't remove the leaks. You need custom values to remove all the variables you set at the end of the trigger.

 

[shinami]

every other leak i've experianced can be removed without the use of custom code and/or jass/scripts.

Let's get an example.

faketrig
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Unit Group - Pick every unit in (Units in (Rect centered at ((Position of Peasant 0000 <gen>) offset by ((Random real number between 15.00 and 25.00), (Random real number between -500.00 and 500.00))) with size (250.00, 250.00))) and do (Actions)
            Loop - Actions
                Unit - Order (Picked unit) to Move To ((Position of (Picked unit)) offset by 500.00 towards (Facing of (Picked unit)) degrees)

this is possibly the leakiest trigger I know how to make.

5 leaks in 1 action. I can get 100x the leaks just by changing the event.

This can be removed by creating an using 5 variables.

faketrig
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Set realX = (Real((Random integer number between -15 and 15)))
        Set realY = (Real((Random integer number between -500 and 500)))
        Set rectOffsetOfPeasant = ((Rect centered at (Position of Peasant 0000 <gen>) with size (250.00, 250.00)) offset by (realX, realY))
        Set unitGroupInRectAtPeasant = (Units in rectOffsetOfPeasant)
        Unit Group - Pick every unit in unitGroupInRectAtPeasant and do (Actions)
            Loop - Actions
                Set pointPositionOfPickedUnit = (Position of (Picked unit))
                Unit - Order (Picked unit) to Move To (pointPositionOfPickedUnit offset by 500.00 towards (Facing of (Picked unit)) degrees)

Hope that makes sense.

If you know of a way using GUI only (probably with variables such as these) to remove the leak let me know.

Download the leak checker.. It helps.. And as far as i recall rects leak.. You have to destroy them. I think its DestroyRect or RemoveRect .. Most likely Destroy.

Also you did not remove the unit group here.. Also a leak.

Also you have to store "position of peasant" into a point variable and remove it at the end.. Point variables are the most common leaks.

And i don't know whats so hard about using custom scripts.. They're a mini version of JASS in GUI.

 

[Cokemonkey11]

squishy: it does remove leaks. because it's a periodic event it's using the same "variable" (the same point or leak if thats what u want to think of it as) each time it's ran. There is a variable that never gets deleted which can count as 1 "leak," but it will never multiply when the trigger is ran more than once.

I do use it shinami - thats how I knew to bring up the leak in this thread in the first place. It's a great tool.

 

[shinami]

squishy: it does remove leaks. because it's a periodic event it's using the same "variable" (the same point or leak if thats what u want to think of it as) each time it's ran. There is a variable that never gets deleted which can count as 1 "leak," but it will never multiply when the trigger is ran more than once.

I do use it shinami - thats how I knew to bring up the leak in this thread in the first place. It's a great tool.

Remove the things i said.. Because that thing doesn't find all the leaks actually.

 

[Cokemonkey11]

there are no leaks dude

i know because i've played 40 minute games that would otherwise end in a lagfest.

if there are leaks the way i do it, its has to be a shitload better than before.. i can tell with lag reduction.

 

[UndeadDragon]

Please read this.

 

[Cokemonkey11]

okay lets forget everything about custom scripts

just assume im a sarcastic rude impatient stubborn kid that wants it done his way.

Is there a way to do it that you guys know of or not?

If not, I don't believe you. Theres a way for every other trigger i've ever made.

 

[trb92]

>okay lets forget everything about custom scripts
You cannot remove most leaks without using custom scripts. Let's go back to the example trigger you posted, that still leaks.

faketrig
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Set realX = (Real((Random integer number between -15 and 15)))
        Set realY = (Real((Random integer number between -500 and 500)))
        Set rectOffsetOfPeasant = ((Rect centered at (Position of Peasant 0000 <gen>) with size (250.00, 250.00)) offset by (realX, realY))
        Set unitGroupInRectAtPeasant = (Units in rectOffsetOfPeasant)
        Unit Group - Pick every unit in unitGroupInRectAtPeasant and do (Actions)
            Loop - Actions
                Set pointPositionOfPickedUnit = (Position of (Picked unit))
                Unit - Order (Picked unit) to Move To (pointPositionOfPickedUnit offset by 500.00 towards (Facing of (Picked unit)) degrees)

It still leaks, alot. Here's a corrected version, using custom scripts.

faketrig
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Set realX = (Real((Random integer number between -15 and 15)))
        Set realY = (Real((Random integer number between -500 and 500)))
        Set rectOffsetOfPeasant = ((Rect centered at (Position of Peasant 0000 <gen>) with size (250.00, 250.00)) offset by (realX, realY))
        Set unitGroupInRectAtPeasant = (Units in rectOffsetOfPeasant)
        Unit Group - Pick every unit in unitGroupInRectAtPeasant and do (Actions)
            Loop - Actions
                Set pointPositionOfPickedUnit = (Position of (Picked unit))
                Unit - Order (Picked unit) to Move To (pointPositionOfPickedUnit offset by 500.00 towards (Facing of (Picked unit)) degrees)
                [B]Custom Script:     call RemoveLocation(udg_pointPositionOfPickedUnit)
        Custom Script:     call DestroyGroup(udg_unitGroupInRectAtPeasant)[/B]

The bolded parts are required to remove the leaks. It also might leak a rect, but I don't know the function to fix that off the top of my head.
Just adding variables will only speed up your code a bit, since it just has the check the data within the variable rather then find the (Position of (Picked unit)) again, but there are still many leaks that you didn't remove.

See the part on your screenshot that says "- Removed: No"? That means you kept the variables, so they just keep overwriting and leaking.

And also, these two lines are useless. Reals don't leak.

        Set realX = (Real((Random integer number between -15 and 15)))
        Set realY = (Real((Random integer number between -500 and 500)))

 

[shinami]

its Custom script: call RemoveRect(udg_Your_Variable)

 

[Cokemonkey11]

addind realx and realy stopped leak checker from telling me the previous was a leak.

So my question is, if my triggers are still leaking, how come they don't lag.

I stress test all my maps to check for lag or long load times or long memory cache cleaning (end of map) times.

Is it because my leaks are "better" or because theres less or what?


Thank you for all the help by the way.

 

[shinami]

addind realx and realy stopped leak checker from telling me the previous was a leak.

So my question is, if my triggers are still leaking, how come they don't lag.

I stress test all my maps to check for lag or long load times or long memory cache cleaning (end of map) times.

Is it because my leaks are "better" or because theres less or what?


Thank you for all the help by the way.

There are some leaks or just minor leaks that cause such little lag that u can't even see it.. still lag tough.... and leaks might cause other problems.. which i don't exactly know.

IF youre trigger leaks at every freakin line then it will lag.

 

[Cokemonkey11]

not if said trigger is 1 line long and runs once >.O

 

[shinami]

not if said trigger is 1 line long and runs once >.O

I'd still rather add an additional 3-2 lines to clean leaks and be safe.. Cleaning leaks is quite easy.