How is my trigger?

[Devrak]

How is my trigger? Does it leak, lag, is it bad, and most important, would this be MUI?

• Basic Shoot Trigger
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to Shoot Arrow
  • Actions
    • Set Caster_Point[(Custom value of (Casting unit))] = (Position of (Casting unit))
    • Set Stat_Damage[(Custom value of (Casting unit))] = (Agility of (Casting unit) (Include bonuses))
    • For each (Integer A) from 1 to 10, do (Actions)
      • Loop - Actions
        • Wait 0.15 seconds
        • Unit Group - Pick every unit in (Units within 2000.00 of (Position of (Casting unit))) and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • And - All (Conditions) are true
                  • Conditions
                    • ((Picked unit) has buff Damaged) Equal to True
                    • ((Owner of (Picked unit)) is an enemy of (Owner of (Casting unit))) Equal to True
              • Then - Actions
                • Set Damage_Done = ((Real(Stat_Damage[(Custom value of (Casting unit))])) + 0.00)
                • Unit - Cause (Casting unit) to damage (Picked unit), dealing Damage_Done damage of attack type Spells and damage type Normal
                • Unit - Remove Damaged buff from (Picked unit)
                • Floating Text - Create floating text that reads (String(Damage_Done, 0, 0)) above (Picked unit) with Z offset 0.00, using font size 9.00, color (100.00%, 0.00%, 0.00%), and 0.00% transparency
                • Floating Text - Change the fading age of (Last created floating text) to 0.20 seconds
                • Floating Text - Change (Last created floating text): Disable permanence
                • Floating Text - Change the lifespan of (Last created floating text) to 1.20 seconds
                • Floating Text - Set the velocity of (Last created floating text) to 20.00 towards 90.00 degrees
              • Else - Actions
                • Do nothing
    • Custom script: call RemoveLocation(udg_Caster_Point[GetUnitUserData(GetSpellAbilityUnit())])

 

[Carl-Fredrik]

There is a unit group which will leak, set it to a variable and then destroy it by using

call DestroyGroup(udg_VARIABLENAME)

And no, it's not MUI since there is a 0.15 sec wait.

Edit: Or you could put the script

set bj_wantDestroyGroup=true

in before you use the group.

 

[Devrak]

Okay, thanks for the fast answer.

How does the wait make it not MUI? Noobish question I guess, but I want to learn, so could you explain with a bit more detail what would make it not work?

Thanks!

 

[Igor_Z]

Unit - A unit Begins casting an ability
Change it with
Unit - A unit starts the effects of an ability
Always use starts the effects, i dunno how to explain to you but begins casting is bugged... (Units within 2000.00 of (Position of (Casting unit))) = Unit Group leak. I don't know about waits in loops so u figure if it works or not

 

[Devrak]

Okay, I'll do that.

And about the leak, how do I remove it? with "call DestroyGroup(udg_VARIABLENAME)" like Carl-Fredrik said? If so, what's the "VARIABLENAME"?

 

[Angel_Island]

It is the name of the variable you are going to use when you are setting the group to the variable.

 

[Devrak]

Ah lol.

Fixed.

Anyone that could explain a bit more in detail why it isn't MUI or why waits doesn't work? Would be very nice.

 

[Angel_Island]

When using waits, variables can be overwritten when another unit uses the same spell.

 

[Devrak]

Ah, but doesn't [(Custom value of (Casting unit))] prevent this from happening?

 

[simonake]

Ok, ill try to make you understand.
If a unit's custom value is 0 and that another unit custom's value is 0 and it cast the spell, will they be overwriten you think?
A: Yes
B: No
You need a MUI count or To read Sooda tutorial. I don't have the link, i'm never able to find this damned tutorial.

 

[Devrak]

Ok, ill try to make you understand.
If a unit's custom value is 0 and that another unit custom's value is 0 and it cast the spell, will they be overwriten you think?
A: Yes
B: No
You need a MUI count or To read Sooda tutorial. I don't have the link, i'm never able to find this damned tutorial.

A I guess I assumed that every units custom value was different.

Okay, I think I understand now. :thup:

MUI count? What's that? I'll try to find that tutorial too, I think I saw it not so long ago.. somewhere...

Anyway +rep for helping me understand.

Edit: http://www.hiveworkshop.com/forums/f279/multi-instancible-gui-spell-making-34393/ Did you mean this tutorial simonake?

 

[Igor_Z]

Set Arrow_Group = (Units within 2000.00 of (Caster_Point[(Custom value of (Casting unit))])))

Use Triggering unit instead of casting unit and set it in a variable if u want... Then the custom script to remove the leak( call DestroyGroup(udg_Arrow_Group) )
I think that Casting Unit is lost after waits or something, correct me if im wrong. Im not sure, but use triggering unit to be sure

 

[Devrak]

Set Arrow_Group = (Units within 2000.00 of (Position of (Triggering unit)))

Use Triggering unit instead of casting unit and set it in a variable if u want... Then the custom script to remove the leak( call DestroyGroup(udg_Arrow_Group) )
I think that Casting Unit is lost after waits or something, correct me if im wrong. Im not sure, but use triggering unit to be sure

Okay will do, thank you. Should I change every 'casting unit' to 'triggering unit' then?

Thinking of what simonake said, if you set every units custom value to a different value, would it work? I will have a maximum of 12 units in my map, so it wont be hard.

 

[simonake]

http://www.hiveworkshop.com/forums/f...-making-34393/ Did you mean this tutorial simonake?

Both of these tutorials gives the same results, your spells is Mui. Personnaly, i prefer MuiCounts but Sooda's tutorial is much easier to understand and is working.
So you can use both of these methods. It won't change the play of your games.

I forgot to paste the link? Lol my mistake, I had find it and add to favorites.
Here it is!! Sooda's Mui

 

[kingkingyyk3]

Unit Group - Pick every unit in (Units within 2000.00 of (Position of (Casting unit))) and do (Actions)
Leaks a location

((Owner of (Picked unit)) is an enemy of (Owner of (Casting unit)))
Leaks 2 players

String(Damage_Done, 0, 0)
Leaks a string

The minimum value of Wait is 0.27 seconds. any value under 0.27 will automatically changed to 0.27 when playing