I need some JASS help

Dryvnt · Sep 29, 2008

Hey all! Before i start to address what i need help for, i first wanna say for all that remember me, that the first time i was here, i failed, bigtime... But now i am back and i have learned abit more patience, gotten more writing skills and simply, gotten smarter :thup:

So heres my problem, i am making this spell, that i need to use local variables for. But the problem is i FAIL at JASS, but i tried, but the spell wont work :banghead:. The spell is going to go like this

1. I cast the spell on an enemy
2. A dummy unit spawns and cast's a lookalike spell (without a new dummy unit ofc)

Here's my code

JASS:

function Trig_Main_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == &#039;A001&#039; ) ) then
        return false
    endif
    return true
endfunction

function Trig_Main_Func002001003 takes nothing returns boolean
    return ( GetOwningPlayer(GetEnumUnit()) != GetOwningPlayer(GetSpellAbilityUnit()) )
endfunction

function Trig_Main_Func002A takes nothing returns nothing
    local unit caster = GetSpellAbilityUnit()
    local unit victim = GetSpellTargetUnit()
    local location targetpoint = GetSpellTargetLoc()
    local unit dummy
    call CreateNUnitsAtLoc( 1, &#039;h000&#039;, GetOwningPlayer(caster), targetpoint, 0.00 )
    set dummy = GetLastCreatedUnit()
    call UnitAddAbilityBJ( &#039;A000&#039;, dummy )
    call SetUnitAbilityLevelSwapped( &#039;A000&#039;, dummy, GetUnitAbilityLevelSwapped(&#039;A001&#039;, caster) )
    call IssueTargetOrderBJ( GetLastCreatedUnit(), &quot;thunderbolt&quot;, victim )
    call UnitApplyTimedLifeBJ( 2.00, &#039;BTLF&#039;, dummy )
endfunction

function Trig_Main_Actions takes nothing returns nothing
    local location targetpoint = GetSpellTargetLoc()
    call ForGroupBJ( GetUnitsInRangeOfLocMatching(500.00, targetpoint, Condition(function Trig_Main_Func002001003)), function Trig_Main_Func002A )
endfunction

//===========================================================================
function InitTrig_Main takes nothing returns nothing
    set gg_trg_Main = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Main, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Main, Condition( function Trig_Main_Conditions ) )
    call TriggerAddAction( gg_trg_Main, function Trig_Main_Actions )
endfunction

Faust · Sep 29, 2008

the spell wont work

Explains hardly what's the problem.

But I already found some errors:

JASS:

    local unit victim = GetSpellTargetUnit()
    local location targetpoint = GetSpellTargetLoc()

So the spell is targeted on ground or unit?

JASS:

    call CreateNUnitsAtLoc( 1, &#039;h000&#039;, GetOwningPlayer(caster), targetpoint, 0.00 )
    set dummy = GetLastCreatedUnit()

should be

JASS:

    set dummy = CreateUnitAtLoc( GetOwningPlayer(caster), &#039;hooo&#039;, targetpoint, 0.00 )

chobibo · Sep 29, 2008

Optimize your code:
-learn vjass
-inline code when necessary
-Use native functions whenever you can
-All dynamic handles must be nulled after use

I recommend the "Collected jass lessons" tutorial.

Dryvnt · Sep 29, 2008

Faust said:
Explains hardly what's the problem.

But I already found some errors:

JASS:
local unit victim = GetSpellTargetUnit() local location targetpoint = GetSpellTargetLoc()

So the spell is targeted on ground or unit?

The location is for making the dummy unit at the right point, while the victim is gonna get hit by the dummy units spell

But even with your recommended fix, it wont work. I have my EVIL thoughts on the

JASS:

    call IssueTargetOrderBJ( GetLastCreatedUnit(), &quot;thunderbolt&quot;, victim )

Faust · Sep 29, 2008

Dryvnt said:
The location is for making the dummy unit at the right point, while the victim is gonna get hit by the dummy units spell

But even with your recommended fix, it wont work. I have my EVIL thoughts on the
JASS:
call IssueTargetOrderBJ( GetLastCreatedUnit(), "thunderbolt", victim )

Why would you order the lastcreatedunit if you set it to a variable?

Dryvnt · Sep 29, 2008

Faust said:
Why would you order the lastcreatedunit if you set it to a variable?

Oh my! I didn't see that! But it still didnt fix it :/... Tell me if you need map to see if i missed some info

Edit:
Added the map, so you might see if i made something wrong with the dummy unit or something with the spell's stats or stuff

Expelliarmus · Sep 29, 2008

Found your error(s)
Start with GUI

Code:

Main Copy
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Spreading Evil 
    Actions
        Unit Group - Pick every unit in (Units within 500.00 of (Target point of ability being cast) matching[B] (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True))[/B] and do (Actions)
            Loop - Actions
                Unit - Create 1 Peasant for (Owner of (Triggering unit)) at (Target point of ability being cast) facing 0.00 degrees
                Unit - Add Spreading Evil Dummy  to (Last created unit)
                Unit - Set level of Spreading Evil Dummy  for (Last created unit) to (Level of Spreading Evil  for (Triggering unit))
                [B]Unit - Order (Last created unit) to Human Mountain King - Storm Bolt (Picked unit)[/B]
                Unit - Add a 2.00 second Generic expiration timer to (Last created unit)

- Matching Condition errors?
- You ordered Chain Lightning when the spell was based on Stormbolt
- You used Target Unit of Ability Being Cast which again shoots Stormbolt to target unit based on the number of people around it. (This is what you want?)
- Spreading Evil Dummy had mana cost

JASS:

JASS:

function Trig_Main_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == &#039;A001&#039; ) ) then
        return false
    endif
    return true
endfunction

function Trig_Main_Func002001003 takes nothing returns boolean
    //return ( GetOwningPlayer(GetEnumUnit()) != GetOwningPlayer(GetSpellAbilityUnit()) ) // again filter error?
      return ( IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(GetTriggerUnit())) == true )
endfunction

function Trig_Main_Func002A takes nothing returns nothing
    //local unit caster = GetSpellAbilityUnit() // use triggering unit instead 
    local unit caster = GetTriggerUnit()
    local unit victim = GetSpellTargetUnit()
    local location targetpoint = GetSpellTargetLoc()
    local unit dummy = CreateUnitAtLoc( GetOwningPlayer(caster), &#039;hooo&#039;, targetpoint, 0.00 )
    //set dummy = CreateUnitAtLoc( GetOwningPlayer(caster), &#039;hooo&#039;, targetpoint, 0.00 ) // you can combine them
    call UnitAddAbilityBJ( &#039;A000&#039;, dummy )
    call SetUnitAbilityLevelSwapped( &#039;A000&#039;, dummy, GetUnitAbilityLevelSwapped(&#039;A001&#039;, caster) )
    //call IssueTargetOrderBJ( GetLastCreatedUnit(), &quot;thunderbolt&quot;, victim ) // you can use dummy variable
    call IssueTargetOrderBJ(dummy, &quot;thunderbolt&quot;, victim)
    call UnitApplyTimedLifeBJ( 2.00, &#039;BTLF&#039;, dummy )
endfunction

function Trig_Main_Actions takes nothing returns nothing
    local location targetpoint = GetSpellTargetLoc()
    call ForGroupBJ( GetUnitsInRangeOfLocMatching(500.00, targetpoint, Condition(function Trig_Main_Func002001003)), function Trig_Main_Func002A )
    call RemoveLocation(targetpoint) //leaks
    set targetpoint = null //leaks
endfunction

//===========================================================================
function InitTrig_Main takes nothing returns nothing
    set gg_trg_Main = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Main, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Main, Condition( function Trig_Main_Conditions ) )
    call TriggerAddAction( gg_trg_Main, function Trig_Main_Actions )
endfunction

- Your spell casts shockwave to the target as many times as the number of units around the target.
- Look at GUI problems

- You can remove the BJ/ Optimize the code yourself (when you start to learn JASS, this will be a good example to start from)

Faust · Sep 30, 2008

Give the dummy's ability 9999999999999 casting range.

Dryvnt · Sep 30, 2008

Wierd

This is wierd, the GUI version works, have i done something wrong in the JASS?

GUI

Code:

Main Copy
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Spreading Evil 
    Actions
        Unit Group - Pick every unit in (Units within 500.00 of (Target point of ability being cast) matching (((Owner of (Matching unit)) is an enemy of (Owner of (Triggering unit))) Equal to True)) and do (Actions)
            Loop - Actions
                Unit - Create 1 Peasant for (Owner of (Triggering unit)) at (Target point of ability being cast) facing 0.00 degrees
                Unit - Set level of Spreading Evil Dummy  for (Last created unit) to (Level of Spreading Evil  for (Casting unit))
                Unit - Order (Last created unit) to Human Mountain King - Storm Bolt (Picked unit)
                Unit - Add a 2.00 second Generic expiration timer to (Last created unit)

JASS

JASS:

function Trig_Main_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == &#039;A001&#039; ) ) then
        return false
    endif
    return true
endfunction

function Trig_Main_Func002001003 takes nothing returns boolean
    return ( IsPlayerEnemy(GetOwningPlayer(GetFilterUnit()), GetOwningPlayer(GetTriggerUnit())) == true )
endfunction

function Trig_Main_Func002A takes nothing returns nothing
    local location targetpoint = GetSpellTargetLoc()
    local unit caster = GetTriggerUnit()
    local unit victim = GetEnumUnit()
    local unit dummy = CreateUnitAtLoc( GetOwningPlayer(caster), &#039;hooo&#039;, targetpoint, 0.00 )
    call SetUnitAbilityLevelSwapped( &#039;A000&#039;, dummy, GetUnitAbilityLevelSwapped(&#039;A001&#039;, caster) )
    call IssueTargetOrderBJ( dummy, &quot;thunderbolt&quot;, victim )
    call UnitApplyTimedLifeBJ( 2.00, &#039;BTLF&#039;, dummy )
endfunction

function Trig_Main_Actions takes nothing returns nothing
    local location targetpoint = GetSpellTargetLoc()
    call ForGroupBJ( GetUnitsInRangeOfLocMatching(500.00, GetSpellTargetLoc(), Condition(function Trig_Main_Func002001003)), function Trig_Main_Func002A )
    call RemoveLocation(targetpoint)
    set targetpoint = null
endfunction

//===========================================================================
function InitTrig_Main takes nothing returns nothing
    set gg_trg_Main = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Main, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Main, Condition( function Trig_Main_Conditions ) )
    call TriggerAddAction( gg_trg_Main, function Trig_Main_Actions )
endfunction

What am i doing wrong?

saw792 · Sep 30, 2008

Did you add the CreateUnitAtLoc() line yourself? Because normally custom unit codes start with 'h000' not 'hooo'.

Dryvnt · Sep 30, 2008

saw792 said:
Did you add the CreateUnitAtLoc() line yourself? Because normally custom unit codes start with 'h000' not 'hooo'.

Well... I thought that was the problem but no

... I still think its something with that line... Because it doesent spawn a dummy unit

But since the GUI version works, should i just stick to that? Or should i try and fix the JASS ?

Viikuna · Sep 30, 2008

Btw.
You dont have to create Dummy unit for stun everytime someone gets stunned. Just use one global dummy all the time. You just need to set spells casting time and unit animation times to 0. And use SetUnitX /SetUnitY to move dummy to the right place.

EDIT.

I made this WarStomp copy, as a small Jass tutorial for my friend
You might learn something from it too.

JASS:

scope WarStomp initializer init
//====================================================================================
//ASDASDASDASDASDASDDDDASDASDASDASDASDASDASDDDDASDASDASDASDASDASDASDDDDASDASDASDASDASDASDASDDDDA
//==================================================================================
globals
            private constant integer ABILITY_ID = &#039;A000&#039;
            private constant integer DEALERS_HAND = &#039;A001&#039;
            private constant integer DEALER_ID = &#039;n000&#039;
            private constant real AOE = 250.0
            private constant real DAMAGE = 25.0
            private constant string EFFECT_PATH = &quot;Abilities\\Spells\\Orc\\WarStomp\\WarStompCaster.mdl&quot;

//====================================================================================
//ASDASDASDASDASDASDDDDASDASDASDASDASDASDASDDDDASDASDASDASDASDASDASDDDDASDASDASDASDASDASDASDDDDASD
//====================================================================================    
    private group TempG = CreateGroup()
    private unit TempU
    private filterfunc F
    private unit Dealer
endglobals

private function Filtteri takes nothing returns boolean
    return IsUnitAlly(GetFilterUnit(),GetOwningPlayer(TempU)) == false and GetWidgetLife(GetFilterUnit()) &gt; 0.405
endfunction

private function YesWeCan takes nothing returns nothing
     local unit u = GetTriggerUnit()
     local real x = GetUnitX(u)
     local real y = GetUnitY(u)
     local integer level = GetUnitAbilityLevel(u,ABILITY_ID)
     local unit target
     local player p = GetOwningPlayer(u)
     set TempU = u
     call GroupEnumUnitsInRange(TempG,x,y,AOE,F)
     call DestroyEffect(AddSpecialEffect(EFFECT_PATH,x,y))
     call SetUnitAbilityLevel(Dealer,DEALERS_HAND,level)
     loop
         set target = FirstOfGroup(TempG)
         exitwhen target == null
         set x = GetUnitX(target)
         set y = GetUnitY(target)
         call SetUnitX(Dealer,x)
         call SetUnitY(Dealer,y)
         call IssueTargetOrder(Dealer,&quot;thunderbolt&quot;,target)
         call UnitDamageTarget(u,target,DAMAGE*level,false,false,ATTACK_TYPE_NORMAL,DAMAGE_TYPE_MAGIC,WEAPON_TYPE_WHOKNOWS)
         call GroupRemoveUnit(TempG,target)
     endloop
     set u = null
     set p = null
endfunction

private function CanWeStomp takes nothing returns boolean
    return GetSpellAbilityId() == ABILITY_ID
endfunction

private function init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(t,Condition(function CanWeStomp))
    call TriggerAddAction(t,function YesWeCan)
    set F = Filter(function Filtteri)
    set Dealer = CreateUnit(Player(13),DEALER_ID,0.0,0.0,0.0)
endfunction

endscope

And sometimes it is good to have WarStomp without terrain deformation, since normal WarStomp can desync with GetLocationZ.

saw792 · Sep 30, 2008

Umm I think you missed what I was saying. Replace 'hooo' with 'h000'.

Dryvnt · Oct 1, 2008

saw792 said:
Umm I think you missed what I was saying. Replace 'hooo' with 'h000'.

I have done that... But it didnt work, then after importing into another map, it worked... So well, thank you guys for all your help!

Wish i could give you +rep

I need some JASS help

Dryvnt

New Member

Faust

You can change this now in User CP.

chobibo

Level 1 Crypt Lord

Dryvnt

New Member

Faust

You can change this now in User CP.

Dryvnt

New Member

Attachments

Expelliarmus

Where to change the sig?

Faust

You can change this now in User CP.

Dryvnt

New Member

saw792

Is known to say things. That is all.

Dryvnt

New Member

Viikuna

No Marlo no game.

saw792

Is known to say things. That is all.

Dryvnt

New Member

Settings Notifications

Options

The Helper Discord

Members online

Share this page

Affiliates

Network Sponsors

I need some JASS help

New Member

You can change this now in User CP.

Level 1 Crypt Lord

New Member

You can change this now in User CP.

New Member

Attachments

Where to change the sig?

You can change this now in User CP.

New Member

Is known to say things. That is all.

New Member

No Marlo no game.

Is known to say things. That is all.

New Member

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors