if conditions mess up weirdly

wellwish3r

wishes wells.
Reaction score
52
JASS:

set index = i
if D<i>.mult == false then
       call GroupAddUnit(D<i>.multgrp,D<i>.targ)
else
    set multiple = true
endif</i></i></i>


D.mult is false here, so the unit D.targ should get added to the D.multgrp group right?

So then later there is a GroupEnumUnitsInRangeOfLoc() Which has this as a condition (index is a global integer):
JASS:
if (IsUnitInGroup(u,D[index].multgrp) == D[index].mult == true) or (IsUnitInGroup(u,D[index].multgrp) == false) then


This if statement however seems to allways be true. I don't understand why...

Here is the whole thing if that helps (kinda lengthy)

JASS:
scope HealWave

    struct HealingWave
        unit caster
        unit targ
        real aoe
        real amount
        real bounce
        real reducer
        player owner
        boolean healmech
        boolean end
        boolean mult
        group multgrp
    endstruct

    globals
        private integer Total = 0
        private HealingWave array D
        private timer T=CreateTimer()
        private boolean mechanical
        private player owningPlayer
        private integer index = 0
        private boolean multiple
    endglobals
    
    private function MatchPlayerType takes nothing returns boolean
        local unit u = GetFilterUnit()
        if (IsUnitInGroup(u,D[index].multgrp) == D[index].mult == true) or (IsUnitInGroup(u,D[index].multgrp) == false) then
            if IsUnitAlly(u,owningPlayer) == true and IsUnitType(u,UNIT_TYPE_STRUCTURE) == false and GetFilterUnit() != D[index].caster and GetPlayerController(GetOwningPlayer(u)) == MAP_CONTROL_USER then
                if mechanical == false and IsUnitType(u,UNIT_TYPE_MECHANICAL) then
                    set u = null
                    return false
                endif
                set u =null
                return true
            endif
        endif
        return false
    endfunction
    
    private function LoopActions takes nothing returns nothing
        local integer i = 0
        local location array loc2
        local group array grp
        local texttag array txt
        local effect array sfx
        loop
            exitwhen i&gt;=Total
            if D<i>.end then
                call D<i>.destroy()
                set Total=Total-1
                if Total &gt; 0 then
                    set D<i>=D[Total]
                    set i=i-1
                else
                    call PauseTimer(T)
                endif
            else
                set grp<i> = CreateGroup()
                set txt<i> = CreateTextTag()
                set loc2<i> = GetUnitLoc(D<i>.targ)
                call TL_Unit (&quot;HWPB&quot;, D<i>.caster, D<i>.targ,.7, true, 1, 0)
                set sfx<i> = AddSpecialEffectTarget(&quot;Abilities\\Spells\\Orc\\HealingWave\\HealingWaveTarget.mdl&quot;,D<i>.targ,&quot;origin&quot;)
                call SetUnitState(D<i>.targ,UNIT_STATE_LIFE,(GetUnitState(D<i>.targ,UNIT_STATE_LIFE)+D<i>.amount))
                call SetTextTagText(txt<i>,I2S(R2I(D<i>.amount)),TextTagSize2Height(8.00))
                call SetTextTagPos(txt<i>,GetLocationX(loc2<i>),GetLocationY(loc2<i>),150)
                call SetTextTagColor(txt<i>,51,255,0,255)
                call SetTextTagPermanent(txt<i>,false)
                call SetTextTagLifespan(txt<i>, .67)
                call SetTextTagFadepoint(txt<i>, 0.47)
                call SetTextTagVelocityBJ( txt<i>, 250.00, 90 )
                set D<i>.amount = (D<i>.amount)*(1-D<i>.reducer)
                set D<i>.caster = D<i>.targ
                set mechanical  = D<i>.healmech
                set owningPlayer = D<i>.owner
                set index = i
                if D<i>.mult == false then
                    call GroupAddUnit(D<i>.multgrp,D<i>.targ)
                else
                    set multiple = true
                endif
                call GroupEnumUnitsInRangeOfLoc(grp<i>,loc2<i>,D<i>.aoe,Condition(function MatchPlayerType))
                call RemoveLocation(loc2<i>)
                set D<i>.targ = GroupPickRandomUnit(grp<i>)
                call DestroyGroup(grp<i>)
                set D<i>.bounce = (D<i>.bounce) - 1
                if D<i>.bounce == 0 then
                    set D<i>.end = true
                endif
            endif
            set i = i+1
        endloop
    endfunction
    
    function HealWave takes unit c, unit t, real ae, real am, real bo, real red, player own, boolean mech, boolean m returns nothing
        local HealingWave LWave = HealingWave.create()
        set LWave.caster = c
        set LWave.targ = t
        set LWave.aoe = ae
        set LWave.amount = am
        set LWave.bounce = bo
        set LWave.reducer = red
        set LWave.owner = own
        set LWave.healmech = mech
        set LWave.end = false
        set LWave.mult = m
        if Total == 0 then
            call TimerStart(T,0.3,true,function LoopActions)
        endif
        set D[Total] = LWave
        set Total = Total+1
        call LWave.destroy()
    endfunction
    
endscope
</i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i>
 

Rainther

I guess I should write something of value here...
Reaction score
61
I'm just guessing that the function executed from GroupEnum etc. doesn't have this group passed through the other function. My suggestion would be to remove that string and after GroupEnum etc. do:
JASS:
GroupRemoveGroup(D<i>.multgrp,grp<i> // Change <i> if needed</i></i></i>
 

wellwish3r

wishes wells.
Reaction score
52
I'm just guessing that the function executed from GroupEnum etc. doesn't have this group passed through the other function. My suggestion would be to remove that string and after GroupEnum etc. do:
JASS:
GroupRemoveGroup(D<i>.multgrp,grp<i> // Change <i> if needed</i></i></i>


i honestly don't get what you said :S. What am i supposed to remove?

EDIT: Found a solution:

JASS:
scope HealWave

    struct HealingWave
        unit caster
        unit targ
        real aoe
        real amount
        real bounce
        real reducer
        player owner
        boolean healmech
        boolean end
        boolean mult
        group multgrp = CreateGroup()
    endstruct

    globals
        private integer Total = 0
        private HealingWave array D
        private timer T=CreateTimer()
        private boolean mechanical
        private player owningPlayer
        private integer index = 0
        private boolean multiple
    endglobals
    
    private function MatchPlayerType takes nothing returns boolean
        local unit u = GetFilterUnit()
        call BJDebugMsg(&quot;Units in Multgroup: &quot;+I2S(CountUnitsInGroup(D[index].multgrp)))
        if (IsUnitInGroup(u,D[index].multgrp) == D[index].mult == true) or (IsUnitInGroup(u,D[index].multgrp) == false) then
            if IsUnitAlly(u,owningPlayer) == true and IsUnitType(u,UNIT_TYPE_STRUCTURE) == false and GetFilterUnit() != D[index].caster and GetPlayerController(GetOwningPlayer(u)) == MAP_CONTROL_USER then
                if mechanical == false and IsUnitType(u,UNIT_TYPE_MECHANICAL) then
                    set u = null
                    return false
                endif
                set u =null
                return true
            endif
        endif
        return false
    endfunction
    
    private function LoopActions takes nothing returns nothing
        local integer i = 0
        local location array loc2
        local group array grp
        local texttag array txt
        local effect array sfx
        local unit u
        loop
            exitwhen i&gt;=Total
            if D<i>.end then
                call D<i>.destroy()
                set Total=Total-1
                if Total &gt; 0 then
                    set D<i>=D[Total]
                    set i=i-1
                else
                    call PauseTimer(T)
                endif
            else
                set grp<i> = CreateGroup()
                set txt<i> = CreateTextTag()
                set loc2<i> = GetUnitLoc(D<i>.targ)
                call TL_Unit (&quot;HWPB&quot;, D<i>.caster, D<i>.targ,.7, true, 1, 0)
                set sfx<i> = AddSpecialEffectTarget(&quot;Abilities\\Spells\\Orc\\HealingWave\\HealingWaveTarget.mdl&quot;,D<i>.targ,&quot;origin&quot;)
                call SetUnitState(D<i>.targ,UNIT_STATE_LIFE,(GetUnitState(D<i>.targ,UNIT_STATE_LIFE)+D<i>.amount))
                call SetTextTagText(txt<i>,I2S(R2I(D<i>.amount)),TextTagSize2Height(8.00))
                call SetTextTagPos(txt<i>,GetLocationX(loc2<i>),GetLocationY(loc2<i>),150)
                call SetTextTagColor(txt<i>,51,255,0,255)
                call SetTextTagPermanent(txt<i>,false)
                call SetTextTagLifespan(txt<i>, .67)
                call SetTextTagFadepoint(txt<i>, 0.47)
                call SetTextTagVelocityBJ( txt<i>, 250.00, 90 )
                set u = D<i>.targ
                set D<i>.amount = (D<i>.amount)*(1-D<i>.reducer)
                set D<i>.caster = D<i>.targ
                set mechanical  = D<i>.healmech
                set owningPlayer = D<i>.owner
                set index = i
                if D<i>.mult == false then
                    call GroupAddUnit(D<i>.multgrp,u)
                    set u =null
                else
                    set multiple = true
                endif
                call GroupEnumUnitsInRangeOfLoc(grp<i>,loc2<i>,D<i>.aoe,Condition(function MatchPlayerType))
                //call GroupRemoveGroup(D<i>.multgrp,grp<i>)
                call RemoveLocation(loc2<i>)
                set D<i>.targ = GroupPickRandomUnit(grp<i>)
                call DestroyGroup(grp<i>)
                set D<i>.bounce = (D<i>.bounce) - 1
                if D<i>.bounce == 0 then
                    set D<i>.end = true
                endif
            endif
            set i = i+1
        endloop
    endfunction
    
    function HealWave takes unit c, unit t, real ae, real am, real bo, real red, player own, boolean mech, boolean m returns nothing
        local HealingWave LWave = HealingWave.create()
        set LWave.caster = c
        set LWave.targ = t
        set LWave.aoe = ae
        set LWave.amount = am
        set LWave.bounce = bo
        set LWave.reducer = red
        set LWave.owner = own
        set LWave.healmech = mech
        set LWave.end = false
        set LWave.mult = m
        if Total == 0 then
            call TimerStart(T,0.3,true,function LoopActions)
        endif
        set D[Total] = LWave
        set Total = Total+1
        call LWave.destroy()
    endfunction
    
endscope
</i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i>
 

Rainther

I guess I should write something of value here...
Reaction score
61
I just suggested to create the group without the isunitingroup condition and them remove everyone that's in the special group from the grp.
Anyhow good it works now. Just wanted to explain.
 

wellwish3r

wishes wells.
Reaction score
52
I just suggested to create the group without the isunitingroup condition and them remove everyone that's in the special group from the grp.
Anyhow good it works now. Just wanted to explain.


ahh okay, anyways, the problem was just that the group was never created :D
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    How are you all? :D
    +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top