Item Collection Quest with Item Stacking

[Fung]

After reading 2 very informative tutorials on how to stack items and how to create an item collection quest I tried to merge the 2. First of all the item stacking works perfectly.

So I tried to create a separate trigger for the item stacking quest. The player (Fung) has to collect 10 (for testing I made it 2) banshee dust to complete the quest (3).

Finish Quest Us and Them
    Events
        Unit - A unit owned by Player 1 (Red) Acquires an item
    Conditions
        (Quest[3] is enabled) Equal to True
        (Item-type of (Item being manipulated)) Equal to Banshee Dust
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Charges remaining in (Item carried by Fung 0002 <gen> of type Banshee Dust)) Equal to 2
            Then - Actions
                Quest - Mark Quest[3] as Completed
                Game - Display to Player Group - Player 1 (Red) the text: Return the Banshee ...
            Else - Actions

Well this didn't work. So I emailed SFilip and asked for his help. He suggested I put it directly into his acquire trigger and it came out like this.

Acquire
    Events
        Unit - A unit Acquires an item
    Conditions
        (Owner of (Triggering unit)) Equal to Player 1 (Red)
        (Charges remaining in (Item being manipulated)) Not equal to 0
    Actions
        For each (Integer A) from 1 to 6, do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Item-type of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to (Item-type of (Item being manipulated))
                        (Charges remaining in (Item carried by (Hero manipulating item) in slot (Integer A))) Less than (Item level of (Item carried by (Hero manipulating item) in slot (Integer A)))
                        (Item carried by (Hero manipulating item) in slot (Integer A)) Not equal to (Item being manipulated)
                    Then - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                ((Charges remaining in (Item carried by (Hero manipulating item) in slot (Integer A))) + (Charges remaining in (Item being manipulated))) Greater than (Item level of (Item being manipulated))
                            Then - Actions
                                Item - Set charges remaining in (Item being manipulated) to (((Charges remaining in (Item carried by (Hero manipulating item) in slot (Integer A))) + (Charges remaining in (Item being manipulated))) - (Item level of (Item being manipulated)))
                                Item - Set charges remaining in (Item carried by (Hero manipulating item) in slot (Integer A)) to (Item level of (Item being manipulated))
                            Else - Actions
                                Item - Set charges remaining in (Item carried by (Hero manipulating item) in slot (Integer A)) to ((Charges remaining in (Item carried by (Hero manipulating item) in slot (Integer A))) + (Charges remaining in (Item being manipulated)))
                                Item - Remove (Item being manipulated)
                    Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Quest[3] is enabled) Equal to True
                (Item-type of (Item being manipulated)) Equal to Banshee Dust
                (Charges remaining in (Item carried by Fung 0002 <gen> of type Banshee Dust)) Equal to 2
            Then - Actions
                Quest - Mark Quest[3] as Completed
                Game - Display to Player Group - Player 1 (Red) the text: Return the Banshee ...
            Else - Actions

This didn't work either. I collect 2 dust and nothing happens. SFilip didn't know of a solution and suggested I post for help.

Any thoughts?

 

[Exide]

Try changing:

(Item carried by Fung 0002 <gen> of type Banshee Dust)

into

(Item carried by (Triggering unit) of type Banshee Dust)

If that doesn't work, undo your second trigger. (So that the stack - trigger is one trigger and the 'quest trigger' is another trigger. -Two triggers again.)
And then use an integer variable to count how many items the hero has.
For example:

Finish Quest Us and Them
    Events
        Unit - A unit owned by Player 1 (Red) Acquires an item
    Conditions
        (Quest[3] is enabled) Equal to True
        (Item-type of (Item being manipulated)) Equal to Banshee Dust
    Actions
        set Counter_Variable = (Counter_Variable + 1)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                [COLOR="Red"]Counter_Variable is Greater than or equal to 2[/COLOR]
            Then - Actions
                Quest - Mark Quest[3] as Completed
                Game - Display to Player Group - Player 1 (Red) the text: Return the Banshee ...
            Else - Actions

That should do the trick.
Make sure the player can't drop and pick up the same item, though. Either that or have a trigger deduct the number of counts in 'Counter_Variable' for each charge in the item. (In order to prevent cheating.)

 

[Fung]

First suggestion didn't work.

Finish Quest Us and Them
    Events
        Unit - A unit owned by Player 1 (Red) Acquires an item
    Conditions
        (Quest[3] is enabled) Equal to True
        (Item-type of (Item being manipulated)) Equal to Banshee Dust
    Actions
        Set CountDust = (CountDust + 1)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                CountDust Greater than or equal to 2
            Then - Actions
                Quest - Mark Quest[3] as Completed
                Game - Display to Player Group - Player 1 (Red) the text: Return the Banshee ...
            Else - Actions

This is somewhat working. Whenever I pickup a single dust the quest is marked complete. Just to clarify "CountDust" is an integer variable with an initial value of 0.

 

[Exide]

Try setting it in a 'Map Init' trigger to 0, and/or change:

            If - Conditions
                CountDust Greater than or equal to 2

into

            If - Conditions
                CountDust Greater than or equal to 3

and see if that works.

 

[Dameon]

you could make your dust item into a stacking item by useing charges, then check if it has 2 charges in the condition..

 

[Fung]

Try setting it in a 'Map Init' trigger to 0, and/or change:

            If - Conditions
                CountDust Greater than or equal to 2

into

            If - Conditions
                CountDust Greater than or equal to 3

and see if that works.

I tried both options, same result. Once I pickup a single dust the quest gets marked complete.

 

[Exide]

Try disabling the charge-stack-trigger, and playtest again.

Try increasing the value of the condition and see if it works.

 

[Fung]

Try disabling the charge-stack-trigger, and playtest again.

That works. Guess I need to find a different way stacking items?

 

[Exide]

Nah.
Just make the Quest-item non-stackable.
Or make them dissapear from the unit as soon as you pick it up. -And have a message Display: 1/2 items found.. 2/2 items found..

 

[Fung]

you could make your dust item into a stacking item by useing charges, then check if it has 2 charges in the condition..

I tried your item charge system and it has the same result as SFilip's stacking system. Once I pickup the item it completes the quest.

I rather the player see the items in their inventory then receive status updates. Guess I just need to keep trying new things.

Just make the Quest-item non-stackable.

Where is this done?

 

[Exide]

Remove the charges from the item, in Object Editor.

 

[Fung]

Remove the charges from the item, in Object Editor.

Interesting. Doing this and enabling either the charge or item stacking trigger doesn't complete the quest when I aquire 1 dust, but it also doesn't stack the item.

 

[Fung]

I got it to work.

Finish Quest Us and Them
    Events
        Unit - A unit owned by Player 1 (Red) Acquires an item
    Conditions
        (Quest[3] is enabled) Equal to True
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Charges remaining in (Item carried by (Triggering unit) of type Banshee Dust)) Greater than or equal to 2
            Then - Actions
                Quest - Mark Quest[3] as Completed
                Game - Display to Player Group - Player 1 (Red) the text: Return the Banshee ...
            Else - Actions

Using this and SFilip's stacking system. However I need to do some modifying so the messages stop after collecting 2 dust and the trigger fires off in case the player drops the dusts.

 

[dragonhord]

If you try to make the item unstackable than you can just base it off an entirely different item... It would be fairly simple that way, adding an integer and removing an integer each time an item is grabbed or dropped... But if you want to maintain charges in order to help with inventory space you could always check whether or not the player is dropping or picking up an item. Make sure the item is your dust that they are trying to get. Then every time they do it set a variable equal to the number of charges on the dust item they have... If the number of charges is equal to your quest condition than it should fire up a completed quest and you should be fine... If you need me to elaborate more I will... Haven't been on in a while so sorry about not responding prior...