Locals Per Function

S

SFilip

Gone but not forgotten
Reaction score
634
per function.
 
Prometheus

Prometheus

Everything is mutable; nothing is sacred
Reaction score
590
Code: 
function Trig_Increase_Damage_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A004' ) ) then
        return false
    endif
    return true
endfunction

function Trig_Increase_Damage_Func002C takes nothing returns boolean
    if ( not ( IsUnitType(udg_increaseDamageU, UNIT_TYPE_HERO) == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_Increase_Damage_Actions takes nothing returns nothing
    local unit DU
    set DU = GetSpellTargetUnit()
    if ( Trig_Increase_Damage_Func002C() ) then
        call ModifyHeroStat( bj_HEROSTAT_STR, DU, bj_MODIFYMETHOD_ADD, 3 )
        call TriggerSleepAction( 60.00 )
        call ModifyHeroStat( bj_HEROSTAT_STR, DU, bj_MODIFYMETHOD_SUB, 3 )
    else
        call SetUnitExplodedBJ( DU, true )
    endif
endfunction

//===========================================================================
function InitTrig_Increase_Damage takes nothing returns nothing
    set gg_trg_Increase_Damage = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Increase_Damage, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Increase_Damage, Condition( function Trig_Increase_Damage_Conditions ) )
    call TriggerAddAction( gg_trg_Increase_Damage, function Trig_Increase_Damage_Actions )
endfunction
Do I need to use a global to get this to work right? It was GUI with globals but then I wanted to convert it to JASS and use locals.
 
S

SFilip

Gone but not forgotten
Reaction score
634
one of the main advantages of jass is the possibility of cleaning stuff like this.
Code: 
    if ( Trig_Increase_Damage_Func002C() ) then
change it intro
Code: 
    if ( ( IsUnitType(DU, UNIT_TYPE_HERO) == true ) then
and there you have it. now you can remove Trig_Increase_Damage_Func002C since you are not using it anymore.

you can simplify this too:
Code: 
function Trig_Increase_Damage_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A004' ) ) then
        return false
    endif
    return true
endfunction
intro
Code: 
function Trig_Increase_Damage_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A004'
endfunction

dont forget the remove the local handle leak in the end.
Code: 
    set DU = null
 
Prometheus

Prometheus

Everything is mutable; nothing is sacred
Reaction score
590
This look right?

Code: 
function Trig_Increase_Damage_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A004'
endfunction


function Trig_Increase_Damage_Actions takes nothing returns nothing
    local unit DU
    set DU = GetSpellTargetUnit()
    if ( ( IsUnitType(DU, UNIT_TYPE_HERO) == true ) then
        call ModifyHeroStat( bj_HEROSTAT_STR, DU, bj_MODIFYMETHOD_ADD, 3 )
        call TriggerSleepAction( 60.00 )
        call ModifyHeroStat( bj_HEROSTAT_STR, DU, bj_MODIFYMETHOD_SUB, 3 )
        set DU = null
    else
        call SetUnitExplodedBJ( DU, true )
        set DU = null
    endif
endfunction

//===========================================================================
function InitTrig_Increase_Damage takes nothing returns nothing
    set gg_trg_Increase_Damage = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Increase_Damage, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Increase_Damage, Condition( function Trig_Increase_Damage_Conditions ) )
    call TriggerAddAction( gg_trg_Increase_Damage, function Trig_Increase_Damage_Actions )
endfunction
 
S

SFilip

Gone but not forgotten
Reaction score
634
yeah
though you could move that nulling action to save space...and set it in the same line where you defined
Code: 
function Trig_Increase_Damage_Actions takes nothing returns nothing
    [B]local unit DU = GetSpellTargetUnit()[/B]
    if ( ( IsUnitType(DU, UNIT_TYPE_HERO) == true ) then
        call ModifyHeroStat( bj_HEROSTAT_STR, DU, bj_MODIFYMETHOD_ADD, 3 )
        call TriggerSleepAction( 60.00 )
        call ModifyHeroStat( bj_HEROSTAT_STR, DU, bj_MODIFYMETHOD_SUB, 3 )
    else
        call SetUnitExplodedBJ( DU, true )
    endif
    [B]set DU = null[/B]
endfunction
 
Prometheus

Prometheus

Everything is mutable; nothing is sacred
Reaction score
590
This line gives me an error

Code: 
    if ( ( IsUnitType(DU, UNIT_TYPE_HERO) == true ) then
 
S

SFilip

Gone but not forgotten
Reaction score
634
my bad, has an extra ( :eek:
Code: 
    if ( IsUnitType(DU, UNIT_TYPE_HERO) == true ) then
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • WildTurkey WildTurkey:
    is there a stephen green in the house?
     +1
  • The Helper The Helper:
    What is up WildTurkey?
  • The Helper The Helper:
    Looks like Google fixed whatever mistake that made the recipes on the site go crazy and we are no longer trending towards a recipe site lol - I don't care though because it motivated me to spend alot of time on the site improving it and at least now the content people are looking at is not stupid and embarrassing like it was when I first got back into this like 5 years ago.
  • The Helper The Helper:
    Plus - I have a pretty bad ass recipe collection now! That section of the site is 10 thousand times better than it was before
  • The Helper The Helper:
    We now have a web designer at my job. A legit talented professional! I am going to get him to redesign the site theme. It is time.
  • Varine Varine:
    I got one more day of community service and then I'm free from this nonsense! I polished a cop car today for a funeral or something I guess
  • Varine Varine:
    They also were digging threw old shit at the sheriff's office and I tried to get them to give me the old electronic stuff, but they said no. They can't give it to people because they might use it to impersonate a cop or break into their network or some shit? idk but it was a shame to see them take a whole bunch of radios and shit to get shredded and landfilled
  • The Helper The Helper:
    whatever at least you are free
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?

      The Helper Discord

      Staff online

      Members online

      Online now:
      324 (members: 1, guests: 323)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top