need help on trigger(randomly select unit)

[squorpion]

i know i have posted about this trigger before but i still never recieved an answer that worked so posting agien. here is the trigger all i need is to add a if,then,else loop.

variables used in trigger

Sheeps
    Events
        Map initialization
    Conditions
    Actions
        Unit Group - Pick every unit in (Units in Sheeps <gen>) and do (Actions)
            Loop - Actions
                Unit Group - Add (Picked unit) to Sheeps

RandomSheep
    Events
    Conditions
    Actions
        Set RandomSheep = (Random unit from Sheeps)

trigger it self

Randomize spawn Copy
    Events
        Time - Elapsed game time is 0.01 seconds
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                ((Player 1 (Red) slot status) Equal to Is playing) and ((Player 1 (Red) controller) Equal to User)
            Then - Actions
                If ((Owner of RandomSheep) Equal to Neutral Passive) then do (Unit - Change ownership of (Matching unit) to Player 1 (Red) and Change color) else do (-------- Loop untill red recieves a unit from random sheep --------)
            Else - Actions
                Unit - Remove (Random unit from Sheeps) from the game

so what i need in this trigger is this.
instead of this(wich is just an explination of what i need)

else do (-------- Loop untill red recieves a unit from random sheep --------)

i need this.

else Loop. End loop when player1 red owns 1 unit from sheeps.

that is what i have no idea how to do. i know in jass you can do that but im not to good at jass and can't figure out how to loop the trigger correctly.

if you need the trigger itself post and i will attach a map containing this trigger and the required variables.

 

[garion992]

so, for example, you have a unit from player 2. but it must be for player one, so you search further among your sheep group to find a player 1 sheep and skip the player 2 sheep?
you could make the trigger start over again, so it runs again if it hasnt found a player 1 unit, you know, something like Trigger - Run this trigger checking conditions

 

[squorpion]

so, for example, you have a unit from player 2. but it must be for player one, so you search further among your sheep group to find a player 1 sheep and skip the player 2 sheep?

i have no ideaa what you just said but this is what is going on.

variables
sheeps- when i set the variable sheeps i have a region named sheeps with 8 different sheep inside of it.
randomsheep - it just picks a ranodom unit from the 8 sheeps set inside of sheeps.
trigger
what i want to happen is as followed
first for that map doesnt have that enormus lag at start i set event to map time 0.01 with a condition of play is playing and is a user then run action. pick a random sheep, if the sheep is ownd by anyother player then nutral passive then reroll the sheep and keep on doing so untill it finds one not ownd by nuetral passive. oce it finds one cange the ownership to the player this trigger is for and teleport is to center of map.

 

[garion992]

I think it must be something like this

Then - Actions
If Sheep is from Neutral Passive
>then: Trigger - Run this trigger checking conditions (so it starts the trigger over again, if it has again a Neutral Passive sheep it will start again and again untill it has a player controlled sheep, that will be teleported to centre)
>else (so if you have a player controlled sheep): teleport Sheep to centre

 

[squorpion]

FINALLY!!!! i think i figured something out that will work. here are the trigger.
red

Randomize spawn red
    Events
        Time - Elapsed game time is 0.01 seconds
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                ((Player 1 (Red) slot status) Equal to Is playing) and ((Player 1 (Red) controller) Equal to User)
            Then - Actions
                If ((Owner of RandomSheep) Equal to Neutral Passive) then do (Unit - Change ownership of (Matching unit) to (Matching player) and Change color) else do (Do nothing)
                Unit Group - Remove (Matching unit) from Sheeps
            Else - Actions
                Unit - Remove (Random unit from Sheeps) from the game

blue

Randomize spawn blue
    Events
        Time - Elapsed game time is 0.02 seconds
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                ((Player 2 (Blue) slot status) Equal to Is playing) and ((Player 2 (Blue) controller) Equal to User)
            Then - Actions
                If ((Owner of RandomSheep) Equal to Neutral Passive) then do (Unit - Change ownership of (Matching unit) to (Matching player) and Change color) else do (Do nothing)
                Unit Group - Remove (Matching unit) from Sheeps
            Else - Actions
                Unit - Remove (Random unit from Sheeps) from the game

and so on. each trigger starts 0.01 seconds later and removes the sheep picked from the unit group. i have a cuestion though. since this trigger is useing 2 variables()one of them inderectly) will both update with each new trigger???

 

[garion992]

yes, they should

 

[squorpion]

going to test it in a few minutes i need to find people to test the trigger.
actually im going to just cange conditions.

edit

for somereason it change the owner ship.

 

[garion992]

thats not so weird, cause you tell it to do

(Unit - Change ownership of (Matching unit) to (Matching player) and Change color)


i think you want to do this:

Then - Actions
If Sheep is from Neutral Passive
>then: Trigger - Run this trigger checking conditions (so it starts the trigger over again, if it has again a Neutral Passive sheep it will start again and again untill it has a player controlled sheep, that will be teleported to centre)
>else (so if you have a player controlled sheep): teleport Sheep to centre

you could send me the map, if it doesnt works

 

[squorpion]

i made seperate triggers for each player now. and each trigger removes the sheep that is change ownership for them from the unit group sheeps which is the unit selection in randomsheep. and i only want it to change ownership of a sheep that is controlled by nuetral passive.

 

[Dirac]

Why instead of a 0.01 loop use the A player leaves the game event?

 

[garion992]

this:

"and each trigger removes the sheep that is change ownership for them from the unit group sheeps which is the unit selection in randomsheep."

 

[squorpion]

Why instead of a 0.01 loop use the A player leaves the game event?

i have no idea what your talking about.
read all of the posted replys and it will probable clarify some thigs up

 

[squorpion]

this:

"and each trigger removes the sheep that is change ownership for them from the unit group sheeps which is the unit selection in randomsheep."

you see the part of the trigger that removes the matching unit from unit group sheep? that is the part i was explaining there.

 

[garion992]

sec

so this:

If ((Owner of RandomSheep) Equal to Neutral Passive) then do (Unit - Change ownership of (Matching unit) to (Matching player) and Change color) else do (Do nothing)

does not only changes your Neutral Passive units but also player bleus's or red's sheeps to another player and color??

 

[squorpion]

sec

so this:

If ((Owner of RandomSheep) Equal to Neutral Passive) then do (Unit - Change ownership of (Matching unit) to (Matching player) and Change color) else do (Do nothing)

does not only changes your Neutral Passive units but also player bleus's or red's sheeps to another player and color??

why would it change red or blues sheeps? that what the condition is for. remember i have the sheeps in a unit group sheeps and then i have sheeps set in a trigger not what your saying but i think reading the variables that i posted in original post would help

my explorer closed and i didnt notice what i typed was still in the box when i reopened.

 

[garion992]

Trigger - Run (This trigger) (checking conditions)
this should work then, if you replace it with (----blahblah----)

edit: XD

 

[squorpion]

Trigger - Run (This trigger) (checking conditions)
this should work then, if you replace it with (----blahblah----)

edit: XD

so use the original trigger just replace the comment with run this trigger checking conditions??? should i make it 1 trigger so reduce lag and just make a player vairable array for each player and +1 the array after each trigger for it runs itfor each play? do you think that would work?

 

[squorpion]

here is the trigger now.

Randomize spawn red
    Events
        Time - Elapsed game time is 0.01 seconds
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                ((Player 1 (Red) slot status) Equal to Is playing) and ((Player 1 (Red) controller) Equal to User)
            Then - Actions
                If ((Owner of RandomSheep) Equal to Neutral Passive) then do (Unit - Change ownership of (Matching unit) to Player 1 (Red) and Change color) else do (Trigger - Run (This trigger) (checking conditions))
            Else - Actions
                Unit - Remove (Random unit from Sheeps) from the game

im having a differnt trigger move all the units in sheeps to the center of the map so don't worry about that missing

 

[squorpion]

lol game closes as soon as map hits 0.01 seconds. prob because its a cuntinues loop and keeps on repeating. how do i end the loop?

 

[garion992]

wait is see it i think

Then - Actions
If ((Owner of RandomSheep) Equal to Neutral Passive) then do (Unit - Change ownership of (Matching unit) to Player 1 (Red) and Change color and Trigger -Run this trigger checking conditions) else do <move sheep>or<nothing>