Need Help Resolving a Fatal Error

T

Taishaku

New Member
Reaction score
9
FatalError.jpg


=(

It occurs sporadically on Battle.net. I think I got all of the memory leaks (besides, it once occured within the first five minutes). Infinite loop? Bad model? I don't know what to look for though, can anyone help?

EDIT: Currently have attempted to consolidate all events into the same triggers and stuttering their timing. I also changed the variable names of commonly repeating dummy casters.
 

Attachments

  • Crucis Zone Control 1.01e.w3x
    291.3 KB · Views: 180
demotry241

demotry241

Don't Ever Categorize Yourself.
Reaction score
105
thats alot of triggers with the same events!, well.. somewhat so so.


suggest:

hide a back up, combine most triggers that has same event

example

event
30 seconds
condition
action
if
then
(all actions in trigger 1(example)
else
do nothing

if
then
(all actions in trigger 2(example)
else
do nothing..

and so so on.
 
T

Taishaku

New Member
Reaction score
9
I assume you refer to the Zones. Does that really cause errors? I just built them separately so I can tell them apart.

And er... all of them are different... it spawns a unit in a different zone based on a different spawning building... for five different races. Wouldn't clustering them together not work?
 
demotry241

demotry241

Don't Ever Categorize Yourself.
Reaction score
105
Taishaku said:
I assume you refer to the Zones. Does that really cause errors? I just built them separately so I can tell them apart.

And er... all of them are different... it spawns a unit in a different zone based on a different spawning building.
Click to expand...

they have same events ..xD

that is why you can combine them using if/then/else multiple.. (and just copy paste the actions on the then without filling up the if, and put do nothing in else. (still...hide a backup.) use somewhat like this...

Code: 
WEe
    Events
        Time - Every 30.00 seconds of game time
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
            Then - Actions
                Set SWD1 = (Units in SWD1 <gen> matching ((Unit-type of (Matching unit)) Equal to Shipyard (Barbarian Horde)))
                Unit Group - Pick every unit in SWD1 and do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                ((Picked unit) is alive) Equal to True
                            Then - Actions
                                Set MyLocation = (Position of (Picked unit))
                                Set MyLocation2 = (MyLocation offset by (0.00, 0.00))
                                Custom script:   call RemoveLocation(udg_MyLocation)
                                Unit - Create 1 Barbarian Raiding Vessel I for (Owner of (Picked unit)) at MyLocation2 facing MyLocation
                                Unit - Order (Last created unit) to Attack-Move To (Rally-Point of (Picked unit) as a point)
                                Custom script:   call RemoveLocation(udg_MyLocation2)
                            Else - Actions
                                Do nothing
                Custom script:   call DestroyGroup (udg_SWD1)
                Set SWD1 = (Units in SWD1 <gen> matching ((Unit-type of (Matching unit)) Equal to Shipyard (Inquisition)))
                Unit Group - Pick every unit in SWD1 and do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                ((Picked unit) is alive) Equal to True
                            Then - Actions
                                Set MyLocation = (Position of (Picked unit))
                                Set MyLocation2 = (MyLocation offset by (0.00, 0.00))
                                Custom script:   call RemoveLocation(udg_MyLocation)
                                Unit - Create 1 Inquisition Corvette I for (Owner of (Picked unit)) at MyLocation2 facing MyLocation
                                Unit - Order (Last created unit) to Attack-Move To (Rally-Point of (Picked unit) as a point)
                                Custom script:   call RemoveLocation(udg_MyLocation2)
                            Else - Actions
                                Do nothing
                Custom script:   call DestroyGroup (udg_SWD1)
                Set SWD1 = (Units in SWD1 <gen> matching ((Unit-type of (Matching unit)) Equal to Shipyard (Pirate Fleet)))
                Unit Group - Pick every unit in SWD1 and do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                ((Picked unit) is alive) Equal to True
                            Then - Actions
                                Set MyLocation = (Position of (Picked unit))
                                Set MyLocation2 = (MyLocation offset by (0.00, 0.00))
                                Custom script:   call RemoveLocation(udg_MyLocation)
                                Unit - Create 1 Pirate Fleet Frigate I for (Owner of (Picked unit)) at MyLocation2 facing MyLocation
                                Unit - Order (Last created unit) to Attack-Move To (Rally-Point of (Picked unit) as a point)
                                Custom script:   call RemoveLocation(udg_MyLocation2)
                            Else - Actions
                                Do nothing
                Custom script:   call DestroyGroup (udg_SWD1)
                Set SWD1 = (Units in SWD1 <gen> matching ((Unit-type of (Matching unit)) Equal to Shipyard (Royal Navy)))
                Unit Group - Pick every unit in SWD1 and do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                ((Picked unit) is alive) Equal to True
                            Then - Actions
                                Set MyLocation = (Position of (Picked unit))
                                Set MyLocation2 = (MyLocation offset by (0.00, 0.00))
                                Custom script:   call RemoveLocation(udg_MyLocation)
                                Unit - Create 1 Royal Navy Frigate I for (Owner of (Picked unit)) at MyLocation2 facing MyLocation
                                Unit - Order (Last created unit) to Attack-Move To (Rally-Point of (Picked unit) as a point)
                                Custom script:   call RemoveLocation(udg_MyLocation2)
                            Else - Actions
                                Do nothing
                Custom script:   call DestroyGroup (udg_SWD1)
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
            Then - Actions
                Set NWD1 = (Units in NWD1 <gen> matching ((Unit-type of (Matching unit)) Equal to Shipyard (Barbarian Horde)))
                Unit Group - Pick every unit in NWD1 and do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                ((Picked unit) is alive) Equal to True
                            Then - Actions
                                Set MyLocation = (Position of (Picked unit))
                                Set MyLocation2 = (MyLocation offset by (0.00, 0.00))
                                Custom script:   call RemoveLocation(udg_MyLocation)
                                Unit - Create 1 Barbarian Raiding Vessel I for (Owner of (Picked unit)) at MyLocation2 facing MyLocation
                                Unit - Order (Last created unit) to Attack-Move To (Rally-Point of (Picked unit) as a point)
                                Custom script:   call RemoveLocation(udg_MyLocation2)
                            Else - Actions
                                Do nothing
                Custom script:   call DestroyGroup (udg_NWD1)
                Set NWD1 = (Units in NWD1 <gen> matching ((Unit-type of (Matching unit)) Equal to Shipyard (Inquisition)))
                Unit Group - Pick every unit in NWD1 and do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                ((Picked unit) is alive) Equal to True
                            Then - Actions
                                Set MyLocation = (Position of (Picked unit))
                                Set MyLocation2 = (MyLocation offset by (0.00, 0.00))
                                Custom script:   call RemoveLocation(udg_MyLocation)
                                Unit - Create 1 Inquisition Corvette I for (Owner of (Picked unit)) at MyLocation2 facing MyLocation
                                Unit - Order (Last created unit) to Attack-Move To (Rally-Point of (Picked unit) as a point)
                                Custom script:   call RemoveLocation(udg_MyLocation2)
                            Else - Actions
                                Do nothing
                Custom script:   call DestroyGroup (udg_NWD1)
                Set NWD1 = (Units in NWD1 <gen> matching ((Unit-type of (Matching unit)) Equal to Shipyard (Pirate Fleet)))
                Unit Group - Pick every unit in NWD1 and do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                ((Picked unit) is alive) Equal to True
                            Then - Actions
                                Set MyLocation = (Position of (Picked unit))
                                Set MyLocation2 = (MyLocation offset by (0.00, 0.00))
                                Custom script:   call RemoveLocation(udg_MyLocation)
                                Unit - Create 1 Pirate Fleet Frigate I for (Owner of (Picked unit)) at MyLocation2 facing MyLocation
                                Unit - Order (Last created unit) to Attack-Move To (Rally-Point of (Picked unit) as a point)
                                Custom script:   call RemoveLocation(udg_MyLocation2)
                            Else - Actions
                                Do nothing
                Custom script:   call DestroyGroup (udg_NWD1)
                Set NWD1 = (Units in NWD1 <gen> matching ((Unit-type of (Matching unit)) Equal to Shipyard (Royal Navy)))
                Unit Group - Pick every unit in NWD1 and do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                ((Picked unit) is alive) Equal to True
                            Then - Actions
                                Set MyLocation = (Position of (Picked unit))
                                Set MyLocation2 = (MyLocation offset by (0.00, 0.00))
                                Custom script:   call RemoveLocation(udg_MyLocation)
                                Unit - Create 1 Royal Navy Frigate I for (Owner of (Picked unit)) at MyLocation2 facing MyLocation
                                Unit - Order (Last created unit) to Attack-Move To (Rally-Point of (Picked unit) as a point)
                                Custom script:   call RemoveLocation(udg_MyLocation2)
                            Else - Actions
                                Do nothing
                Custom script:   call DestroyGroup (udg_NWD1)
            Else - Actions

i combined 2 triggers w/ same event
 
T

Taishaku

New Member
Reaction score
9
demotry241 said:
they have same events ..xD

that is why you can combine them using if/then/else multiple.. (and just copy paste the actions on the then without filling up the if, and put do nothing in else. (still...hide a backup.)
Click to expand...

But look at the way it's set up... if I copy and paste into Actions, the wrong units spawn. Before and after example?
 
T

Taishaku

New Member
Reaction score
9
By the way, I use WC3 Map Optimizer. Are there any things I should be careful of, now that you've seen my map?
 
demotry241

demotry241

Don't Ever Categorize Yourself.
Reaction score
105
they say something bad in widjetoptimizer... something like that... i just use optimize.. and unchecks all other options such as tweaks.
 
T

Taishaku

New Member
Reaction score
9
Is it any slower than if I don't? I personally doubt it gets much faster, especially since I ain't too heavy in JASS.
 
T

Taishaku

New Member
Reaction score
9
Okay, tried it with 12 players, it still fatals at around 5 minutes.

Does it matter if two triggers use the same variable at same time?
 
Jeeyo

Jeeyo

New Member
Reaction score
3
it also happens to me everytime i click the model file and icon of thrall and tauren chieftain
 
demotry241

demotry241

Don't Ever Categorize Yourself.
Reaction score
105
no, because it runs trigger by trigger, 1 at a time.


something must be really wrong.
 
T

Taishaku

New Member
Reaction score
9
I found something peculiar. One of my triggers stops working after I create a Town Hall units. It's meant to control the number of creeps that you can control.

Here is the crowd control trigger:

Code: 
Removal
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Set MyPlayerGroup = (All players)
        Player Group - Pick every player in MyPlayerGroup and do (Actions)
            Loop - Actions
                Set MyUnitGroup = (Units owned by (Picked player) matching ((Supply used by (Matching unit)) Equal to 1))
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Number of units in MyUnitGroup) Greater than ((Picked player) Food cap)
                    Then - Actions
                        Unit - Remove (Random unit from MyUnitGroup) from the game
                    Else - Actions
                        Do nothing
        Custom script:   call DestroyGroup(udg_MyUnitGroup)

It is cancelled out by this trigger:

Code: 
Create HQ and CC
    Events
        Unit - A unit Sells a unit
    Conditions
        ((Sold unit) is A Hero) Equal to True
        (Unit-type of (Triggering unit)) Equal to Hero Selector
    Actions
        Set MyLocation = (Position of (Triggering unit))
        Unit - Remove (Triggering unit) from the game
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Unit-type of (Sold unit)) Equal to Archmagus
            Then - Actions
                Unit - Create 1 Apprentices' Laboratory I for (Owner of (Triggering unit)) at MyLocation facing Default building facing degrees
                Unit - Create 1 Guild Engineered Merman for (Owner of (Triggering unit)) at MyLocation facing Default building facing degrees
                Set GuildWarning = (Owner of (Triggering unit))
                Set MyPlayerGroup = (Player group(GuildWarning))
                Game - Display to MyPlayerGroup the text: |cffff0000WARNING!|...
                Custom script:   call DestroyForce (udg_MyPlayerGroup)
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Unit-type of (Sold unit)) Equal to Warchief
            Then - Actions
                Unit - Create 1 Tribal Hall I for (Owner of (Triggering unit)) at MyLocation facing Default building facing degrees
                Unit - Create 1 Salvaged Construction Craft for (Owner of (Triggering unit)) at MyLocation facing Default building facing degrees
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Unit-type of (Sold unit)) Equal to High Inquisitor
            Then - Actions
                Unit - Create 1 Local Tribunal I for (Owner of (Triggering unit)) at MyLocation facing Default building facing degrees
                Unit - Create 1 Rented Construction Craft for (Owner of (Triggering unit)) at MyLocation facing Default building facing degrees
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Unit-type of (Sold unit)) Equal to Pirate Lord
            Then - Actions
                Unit - Create 1 Littoral Hideout I for (Owner of (Triggering unit)) at MyLocation facing Default building facing degrees
                Unit - Create 1 Stolen Construction Craft for (Owner of (Triggering unit)) at MyLocation facing Default building facing degrees
            Else - Actions
                Do nothing
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Unit-type of (Sold unit)) Equal to Admiral
            Then - Actions
                Unit - Create 1 Colonial Headquarters I for (Owner of (Triggering unit)) at MyLocation facing Default building facing degrees
                Unit - Create 1 Construction Craft for (Owner of (Triggering unit)) at MyLocation facing Default building facing degrees
            Else - Actions
                Do nothing
        Custom script:   call RemoveLocation(udg_MyLocation)
        Custom script:   call DestroyForce (udg_MyPlayerGroup)

EDIT: Solved it by using different variables. Maybe that's my problem...
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      No members online now.
      Online now:
      204 (members: 1, guests: 203)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top