Need help with system

TheLegend

New Member
Reaction score
10
I have a problem with my system that obviously doesn't work... I added display text calls o see what is done and what not... THE PROBLEM IS THAT NOTHING SEEMS TO WORK here is the system (please focus only on public functions)
JASS:
library AdvancedStatus initializer init
globals
    private constant real Period = 0.15
    private force f
    private group unitsofsystem = CreateGroup()
    private integer index
    private trigger combat = CreateTrigger()
endglobals

private struct unitdatabase
    unit u
    unit attacktarget
    integer i
    integer strength
    integer skill
    integer agility
    integer constitution
    integer charisma
    integer inteligence
    integer defence
    integer mindamage
    integer maxdamage
endstruct

globals
    unitdatabase array datau
endglobals

private function databasecheck takes unit testunit returns integer
    local integer testinteger = 0
    loop
        set testinteger = testinteger +1
        exitwhen (testunit == datau[testinteger].u)
    endloop
    return testinteger
endfunction

private function unitsetvalues takes unit setedunit returns nothing
    local integer unitindex
    set unitindex = databasecheck(setedunit)
    set datau[unitindex].mindamage = R2I(datau[unitindex].strength/10)
    set datau[unitindex].maxdamage = 10 + R2I(datau[unitindex].strength/10)
    call SetUnitLifePercentBJ(setedunit,(datau[unitindex].constitution * 25.*100)/GetUnitStateSwap(UNIT_STATE_MAX_LIFE, setedunit))
endfunction

private function unitperiodicfilter takes nothing returns nothing
    if (GetPlayerController(GetOwningPlayer(GetEnumUnit())) == MAP_CONTROL_USER) and (IsUnitInGroup(GetEnumUnit(),unitsofsystem)== false) then
        call GroupAddUnit(unitsofsystem,GetEnumUnit())
        set index = index + 1
        set datau[index].i = index
        set datau[index].u = GetEnumUnit()
        set datau[index].strength = 5
        set datau[index].skill = 5
        set datau[index].agility = 5
        set datau[index].constitution = 5
        set datau[index].charisma = 5
        set datau[index].inteligence = 5
        set datau[index].defence = 10
        set datau[index].mindamage = 0
        set datau[index].maxdamage = 10
        call unitsetvalues(GetEnumUnit())
        call TriggerRegisterUnitEvent(combat, GetEnumUnit(),EVENT_UNIT_DAMAGED )
    endif
endfunction

private function unitperiodicadd takes nothing returns nothing
    local group unitinmap = GetUnitsInRectAll(GetPlayableMapRect())
    call ForGroupBJ(unitinmap, function unitperiodicfilter)
    call DestroyGroup(unitinmap)
endfunction

private function unitattackaction takes nothing returns nothing
    local integer idattacker
    local integer idattacked
    local integer damage
    local integer hitchance
    local integer critinflictchance
    local integer critdodgechance
    local integer crit
    local unit attacker
    local unit attacked
    set attacker = GetEventDamageSource()
    set idattacker = databasecheck(attacker)
    set attacked = datau[idattacker].attacktarget
    set idattacked = databasecheck(attacked)
    call SetUnitLifeBJ(attacked, GetUnitStateSwap(UNIT_STATE_LIFE, attacked) + GetEventDamage())
    if idattacked > 0 then
        set critinflictchance = datau[idattacker].skill /(10 * (GetUnitLevel(attacker)+1))
        set critdodgechance = datau[idattacked].agility /(10 * (GetUnitLevel(attacked)+1))
        if (GetRandomInt(0,100) <= critinflictchance) and not(GetRandomInt(0,100) <= critdodgechance) then
            set crit = 2
        else 
            set crit = 1
        endif
        set hitchance = (datau[idattacker].skill)/(datau[idattacked].skill + datau[idattacked].agility)
        set damage = GetRandomInt(datau[idattacker].mindamage, datau[idattacker].maxdamage)*crit - (datau[idattacked].defence /10)
        if (damage >= 0) and (GetRandomInt(0, 100)<=hitchance) then
            call SetUnitLifeBJ(attacked, GetUnitStateSwap(UNIT_STATE_LIFE, attacked) - damage)
            call DisplayTextToPlayer(GetOwningPlayer(attacked),0,0,"Your unit took " + I2S(damage) + " damage.")
            call DisplayTextToPlayer(GetOwningPlayer(attacker),0,0,"Your unit dealt " + I2S(damage) + " damage.")
        else
            call DisplayTextToPlayer(GetOwningPlayer(attacked),0,0,"You took no damage in this attack")
            call DisplayTextToPlayer(GetOwningPlayer(attacker),0,0,"You either missed or your attack was absorbed")
        endif
    else
        call ForceAddPlayer(f,GetOwningPlayer(attacker))
        call QuestMessageBJ(f,bj_QUESTMESSAGE_WARNING,"Cannot target units that are not in system")
        call ForceClear(f)
    endif
endfunction

public function display takes player pl, unit plu returns nothing
    local integer p
    call ForceAddPlayer (f,pl)
    set p = databasecheck(plu)
    call DisplayTextToForce( f, "Strength " + I2S(datau[p].strength) )
    call DisplayTextToForce( f, "Skill " + I2S(datau[p].skill) )
    call DisplayTextToForce( f, "Agility " + I2S(datau[p].agility) )
    call DisplayTextToForce( f, "Constitution " + I2S(datau[p].constitution) )
    call DisplayTextToForce( f, "Charisma " + I2S(datau[p].charisma) )
    call DisplayTextToForce( f, "Inteligence " + I2S(datau[p].inteligence) )
    call DisplayTextToForce( f, "Unit id " + I2S(datau[p].i) )
    call ForceClear(f)
endfunction

private function attackset takes nothing returns nothing
    local integer attackerindex
    set attackerindex = databasecheck(GetAttacker())
    set datau[attackerindex].attacktarget = GetAttackedUnitBJ()
endfunction

private function init takes nothing returns nothing
    local trigger t
    set t = CreateTrigger()
    call TriggerRegisterTimerEventPeriodic(t, Period)
    call TriggerAddAction(t, function unitperiodicadd)
    call TriggerAddAction(combat, function unitattackaction)
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddAction(t, function attackset)
    set t = null
endfunction

endlibrary

and the caller/checker
Trigger:
  • INFO DISPLAY
    • Events
    • Conditions
    • Actions
      • Custom script: local group selected = GetUnitsSelectedAll(GetTriggerPlayer())
      • Custom script: call DisplayTextToForce( GetPlayersAll(), GetPlayerName(GetTriggerPlayer()) + " has requested to see his units status")
      • Unit Group - Pick every unit in (selected) and do (Actions)
        • Loop - Actions
          • Custom script: call AdvancedStatus_display(GetTriggerPlayer(),GetEnumUnit())
      • Custom script: call DestroyGroup(selected)

and at last the init
Trigger:
  • Melee
    • Events
      • Map initialization
    • Conditions
    • Actions
      • Do Multiple ActionsFor each (Integer A) from 1 to 12, do (Actions)
        • Loop - Actions
          • Trigger - Add to INFO DISPLAY <gen> the event (Player - (Player((Integer A))) types a chat message containing INFO as An exact match)


You do understand that I cannot continue my work until I know the database indexing works
 

TheLegend

New Member
Reaction score
10
OMG How could I make that mistake:banghead: Thank you man :D
EDIT
I fixed that but it still doesn't work... not one of the text displays shows ... (only the one in DISPLAY INFO works)
 

TheLegend

New Member
Reaction score
10
I almost completed the system but it still doesn't get registered. Its like the library doesn't exist at all. Copy it and test it... IT DOES NOTHING WHAT IT IS SUPPOSED TO DO. Here is the library i updated
JASS:

library AdvancedStatus initializer init
globals
    private constant real Period = 0.15
    private force f
    private group unitsofsystem = CreateGroup()
    private integer index
    private trigger combat = CreateTrigger()
endglobals

private struct unitdatabase
    unit u
    unit attacktarget
    integer i
    integer strength
    integer skill
    integer agility
    integer constitution
    integer charisma
    integer inteligence
    integer defence
    integer mindamage
    integer maxdamage
endstruct

globals
    unitdatabase array datau
endglobals

private function databasecheck takes unit testunit returns integer
    local integer testinteger = 0
    loop
        set testinteger = testinteger +1
        exitwhen (testunit == datau[testinteger].u)
    endloop
    return testinteger
endfunction

private function unitsetvalues takes unit setedunit returns nothing
    local integer unitindex
    set unitindex = databasecheck(setedunit)
    set datau[unitindex].mindamage = R2I(datau[unitindex].strength/10)
    set datau[unitindex].maxdamage = 10 + R2I(datau[unitindex].strength/10)
    call SetUnitLifePercentBJ(setedunit,(datau[unitindex].constitution * 25.*100)/GetUnitStateSwap(UNIT_STATE_MAX_LIFE, setedunit))
endfunction

private function unitperiodicfilter takes nothing returns nothing
    if (GetPlayerController(GetOwningPlayer(GetEnumUnit())) == MAP_CONTROL_USER) and (IsUnitInGroup(GetEnumUnit(),unitsofsystem)== false) then
        call GroupAddUnit(unitsofsystem,GetEnumUnit())
        set index = index + 1
        set datau[index].i = index
        set datau[index].u = GetEnumUnit()
        set datau[index].strength = 5
        set datau[index].skill = 5
        set datau[index].agility = 5
        set datau[index].constitution = 5
        set datau[index].charisma = 5
        set datau[index].inteligence = 5
        set datau[index].defence = 10
        set datau[index].mindamage = 0
        set datau[index].maxdamage = 10
        call unitsetvalues(GetEnumUnit())
        call TriggerRegisterUnitEvent(combat, GetEnumUnit(),EVENT_UNIT_DAMAGED )
    endif
endfunction

private function unitperiodicadd takes nothing returns nothing
    local group unitinmap = GetUnitsInRectAll(GetPlayableMapRect())
    call ForGroupBJ(unitinmap, function unitperiodicfilter)
    call DestroyGroup(unitinmap)
endfunction

private function unitattackaction takes nothing returns nothing
    local integer idattacker
    local integer idattacked
    local integer damage
    local integer hitchance
    local integer critinflictchance
    local integer critdodgechance
    local integer crit
    local unit attacker
    local unit attacked
    set attacker = GetEventDamageSource()
    set idattacker = databasecheck(attacker)
    set attacked = datau[idattacker].attacktarget
    set idattacked = databasecheck(attacked)
    call SetUnitLifeBJ(attacked, GetUnitStateSwap(UNIT_STATE_LIFE, attacked) + GetEventDamage())
    if idattacked > 0 then
        set critinflictchance = datau[idattacker].skill /(10 * (GetUnitLevel(attacker)+1))
        set critdodgechance = datau[idattacked].agility /(10 * (GetUnitLevel(attacked)+1))
        if (GetRandomInt(0,100) <= critinflictchance) and not(GetRandomInt(0,100) <= critdodgechance) then
            set crit = 2
        else 
            set crit = 1
        endif
        set hitchance = (datau[idattacker].skill)/(datau[idattacked].skill + datau[idattacked].agility)
        set damage = GetRandomInt(datau[idattacker].mindamage, datau[idattacker].maxdamage)*crit - (datau[idattacked].defence /10)
        if (damage >= 0) and (GetRandomInt(0, 100)<=hitchance) then
            call SetUnitLifeBJ(attacked, GetUnitStateSwap(UNIT_STATE_LIFE, attacked) - damage)
            call DisplayTextToPlayer(GetOwningPlayer(attacked),0,0,"Your unit took " + I2S(damage) + " damage.")
            call DisplayTextToPlayer(GetOwningPlayer(attacker),0,0,"Your unit dealt " + I2S(damage) + " damage.")
        else
            call DisplayTextToPlayer(GetOwningPlayer(attacked),0,0,"You took no damage in this attack")
            call DisplayTextToPlayer(GetOwningPlayer(attacker),0,0,"You either missed or your attack was absorbed")
        endif
    else
        call ForceAddPlayer(f,GetOwningPlayer(attacker))
        call QuestMessageBJ(f,bj_QUESTMESSAGE_WARNING,"Cannot target units that are not in system")
        call ForceClear(f)
    endif
endfunction

public function display takes player pl, unit plu returns nothing
    local integer p
    call ForceAddPlayer (f,pl)
    set p = databasecheck(plu)
    call DisplayTextToForce( f, "Strength " + I2S(datau[p].strength) )
    call DisplayTextToForce( f, "Skill " + I2S(datau[p].skill) )
    call DisplayTextToForce( f, "Agility " + I2S(datau[p].agility) )
    call DisplayTextToForce( f, "Constitution " + I2S(datau[p].constitution) )
    call DisplayTextToForce( f, "Charisma " + I2S(datau[p].charisma) )
    call DisplayTextToForce( f, "Inteligence " + I2S(datau[p].inteligence) )
    call DisplayTextToForce( f, "Unit id " + I2S(datau[p].i) )
    call ForceClear(f)
endfunction

private function attackset takes nothing returns nothing
    local integer attackerindex
    set attackerindex = databasecheck(GetAttacker())
    set datau[attackerindex].attacktarget = GetAttackedUnitBJ()
endfunction

private function init takes nothing returns nothing
    local trigger t
    set t = CreateTrigger()
    call TriggerRegisterTimerEventPeriodic(t, Period)
    call TriggerAddAction(t, function unitperiodicadd)
    call TriggerAddAction(combat, function unitattackaction)
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddAction(t, function attackset)
    set t = null
endfunction

endlibrary
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top