One Tiny Leap For Kershbob

Kershbob

Kershbob

New Member
Reaction score
30
Yay me! It may have included a lot of change to custom text and tinkering but I made a big old working JASS trigger. I'm so proud.

Code: 
function Trig_DragonSpell_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A000' ) ) then
        return false
    endif
    return true
endfunction

function Trig_DragonSpell_Func007Func006001003001 takes nothing returns boolean
    return ( IsPlayerAlly(GetOwningPlayer(GetSpellAbilityUnit()), GetOwningPlayer(GetFilterUnit())) == false )
endfunction

function Trig_DragonSpell_Func007Func006001003002 takes nothing returns boolean
    return ( IsUnitType(GetFilterUnit(), UNIT_TYPE_HERO) == true )
endfunction

function Trig_DragonSpell_Func007Func006001003 takes nothing returns boolean
    return GetBooleanAnd( Trig_DragonSpell_Func007Func006001003001(), Trig_DragonSpell_Func007Func006001003002() )
endfunction

function Trig_DragonSpell_Func007Func006A takes nothing returns nothing
    call UnitAddAbilityBJ( 'A004', GetEnumUnit() )
endfunction

function Trig_DragonSpell_Func007C takes nothing returns boolean
    if ( not ( udg_TempInt <= 2 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DragonSpell_Func008Func003001002001 takes nothing returns boolean
    return ( IsPlayerAlly(GetOwningPlayer(GetSpellAbilityUnit()), GetOwningPlayer(GetFilterUnit())) == false )
endfunction

function Trig_DragonSpell_Func008Func003001002002001 takes nothing returns boolean
    return ( IsUnitType(GetFilterUnit(), UNIT_TYPE_MECHANICAL) == false )
endfunction

function Trig_DragonSpell_Func008Func003001002002002 takes nothing returns boolean
    return ( IsUnitType(GetFilterUnit(), UNIT_TYPE_UNDEAD) == false )
endfunction

function Trig_DragonSpell_Func008Func003001002002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DragonSpell_Func008Func003001002002001(), Trig_DragonSpell_Func008Func003001002002002() )
endfunction

function Trig_DragonSpell_Func008Func003001002 takes nothing returns boolean
    return GetBooleanAnd( Trig_DragonSpell_Func008Func003001002001(), Trig_DragonSpell_Func008Func003001002002() )
endfunction

function Trig_DragonSpell_Func008Func003A takes nothing returns nothing
    local location TempPoint3 = GetUnitLoc(GetSpellAbilityUnit())
    local location TempPoint = GetUnitLoc(GetSpellTargetUnit())
    local location TempPoint2 = PolarProjectionBJ(TempPoint3, 120.00, GetUnitFacing(GetSpellAbilityUnit()))
    set udg_TempPoint = GetUnitLoc(GetEnumUnit())
    call CreateNUnitsAtLocFacingLocBJ( 1, 'n006', GetOwningPlayer(GetSpellAbilityUnit()), TempPoint2, udg_TempPoint )
    call IssueTargetOrderBJ( GetLastCreatedUnit(), "deathcoil", GetEnumUnit() )
    call RemoveLocation( udg_TempPoint )
endfunction

function Trig_DragonSpell_Func008C takes nothing returns boolean
    if ( not ( udg_TempInt == 3 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DragonSpell_Func009C takes nothing returns boolean
    if ( not ( udg_TempInt == 4 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DragonSpell_Func010C takes nothing returns boolean
    if ( not ( udg_TempInt == 5 ) ) then
        return false
    endif
    return true
endfunction

function Trig_DragonSpell_Actions takes nothing returns nothing
    local unit dragon = GetSpellAbilityUnit()
    local location TempPoint3 = GetUnitLoc(GetSpellAbilityUnit())
    local location TempPoint = GetUnitLoc(GetSpellTargetUnit())
    local location TempPoint2 = PolarProjectionBJ(TempPoint3, 120.00, GetUnitFacing(GetSpellAbilityUnit()))
    local location TempPoint4 = PolarProjectionBJ(TempPoint3, -120.00, GetUnitFacing(GetSpellAbilityUnit()))
    set udg_TempInt = GetRandomInt(1, 5)
    if ( Trig_DragonSpell_Func007C() ) then
        call CreateNUnitsAtLocFacingLocBJ( 1, 'n005', GetOwningPlayer(GetSpellAbilityUnit()), TempPoint2, TempPoint )
        call IssuePointOrderLocBJ( GetLastCreatedUnit(), "silence", TempPoint2 )
        set bj_wantDestroyGroup = true
        set udg_TempPoint = GetUnitLoc(GetSpellAbilityUnit())
        call ForGroupBJ( GetUnitsInRangeOfLocMatching(700.00, udg_TempPoint, Condition(function Trig_DragonSpell_Func007Func006001003)), function Trig_DragonSpell_Func007Func006A )
        call RemoveLocation( udg_TempPoint )
        return
    else
    endif
    if ( Trig_DragonSpell_Func008C() ) then
        set bj_wantDestroyGroup = true
        call ForGroupBJ( GetUnitsInRectMatching(gg_rct_BossAreaDragon, Condition(function Trig_DragonSpell_Func008Func003001002)), function Trig_DragonSpell_Func008Func003A )
        return
    else
    endif
    if ( Trig_DragonSpell_Func009C() ) then
        set udg_TempUnit = GetSpellAbilityUnit()
        call TriggerExecute( gg_trg_Rage_Up )
        call CreateNUnitsAtLocFacingLocBJ( 1, 'n007', GetOwningPlayer(GetSpellAbilityUnit()), TempPoint2, TempPoint3 )
        call IssueTargetOrderBJ( GetLastCreatedUnit(), "bloodlust", GetSpellAbilityUnit() )
        return
    else
    endif
    if ( Trig_DragonSpell_Func010C() ) then
            call PauseUnitBJ( true, dragon )
            call SetUnitAnimation( GetLastCreatedUnit(), "spell slam" )
            call TriggerSleepAction( 0.50 )
            call CreateNUnitsAtLoc( 1, 'n008', GetOwningPlayer(dragon), TempPoint4, bj_UNIT_FACING )
            call IssueImmediateOrderBJ( GetLastCreatedUnit(), "creepthunderclap" )
            call TriggerSleepAction( 0.75 )
            call PauseUnitBJ( false, dragon )
        return
    else
    endif
endfunction

//===========================================================================
function InitTrig_DragonSpell takes nothing returns nothing
    set gg_trg_DragonSpell = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_DragonSpell, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_DragonSpell, Condition( function Trig_DragonSpell_Conditions ) )
    call TriggerAddAction( gg_trg_DragonSpell, function Trig_DragonSpell_Actions )
endfunction

Someone please tell me all the stuff wrong with it if there is anything.
 
AceHart

AceHart

Your Friendly Neighborhood Admin
Reaction score
1,495
For starters:

Code: 
function Trig_DragonSpell_Func008C takes nothing returns boolean
    if ( not ( udg_TempInt == 3 ) ) then
        return false
    endif
    return true
endfunction

    if ( Trig_DragonSpell_Func008C() ) then

Should be:
Code: 
If udg_TempInt == 3 then

Given the "Temp" part of that variable, wouldn't it be better to use a local?
 
C

CryptWizard

Guest
You should take advantages of the advantages JASS has over GUI:
- Understandable function names
- Logical conditions (No bullshit like "if (not(this)) return false else return true") (you already have this in your first function, replace it with "return (GetSpellAbilityId() == 'A000')" (no quotes))
- No need to use globals
 
S

SFilip

Gone but not forgotten
Reaction score
634
also take note that all handle locals leak if not set to null.
for example your main function should contain these lines at the end:
Code: 
    set dragon = null
    set TempPoint3 = null
    set TempPoint = null
    set TempPoint2 = null
    set TempPoint4 = null
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • WildTurkey WildTurkey:
    is there a stephen green in the house?
     +1
  • The Helper The Helper:
    What is up WildTurkey?
  • The Helper The Helper:
    Looks like Google fixed whatever mistake that made the recipes on the site go crazy and we are no longer trending towards a recipe site lol - I don't care though because it motivated me to spend alot of time on the site improving it and at least now the content people are looking at is not stupid and embarrassing like it was when I first got back into this like 5 years ago.
  • The Helper The Helper:
    Plus - I have a pretty bad ass recipe collection now! That section of the site is 10 thousand times better than it was before
  • The Helper The Helper:
    We now have a web designer at my job. A legit talented professional! I am going to get him to redesign the site theme. It is time.
  • Varine Varine:
    I got one more day of community service and then I'm free from this nonsense! I polished a cop car today for a funeral or something I guess
  • Varine Varine:
    They also were digging threw old shit at the sheriff's office and I tried to get them to give me the old electronic stuff, but they said no. They can't give it to people because they might use it to impersonate a cop or break into their network or some shit? idk but it was a shame to see them take a whole bunch of radios and shit to get shredded and landfilled
  • The Helper The Helper:
    whatever at least you are free
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?

      The Helper Discord

      Members online

      No members online now.
      Online now:
      287 (members: 1, guests: 286)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top