Picking every unit that doesn't have a specific order

[Devrak]

Hi everyone, got a quick question.

• Down Arrow 1
  • Events
    • Player - Player 1 (Red) Presses the Down Arrow key
  • Conditions
  • Actions
    • Set P1DoubleArrow = (P1DoubleArrow + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • P1DoubleArrow Equal to 1
      • Then - Actions
        • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Issued order) Not equal to (Order(hold position))) and ((Owner of (Picked unit)) Equal to Player 1 (Red)))) and do (Actions)
          • Loop - Actions
            • Unit - Order (Picked unit) to Attack-Move To (Random point in P1 Spawnpoint <gen>)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • P1DoubleArrow Equal to 2
          • Then - Actions
            • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Issued order) Not equal to (Order(hold position))) and ((Owner of (Picked unit)) Equal to Player 1 (Red)))) and do (Actions)
              • Loop - Actions
                • Unit - Order (Picked unit) to Move To (Random point in P1 Spawnpoint <gen>)
          • Else - Actions
    • Wait 0.15 seconds
    • Set P1DoubleArrow = 0

So this is my trigger, and what I am trying to do is to move everyone that hasn't be ordered to hold position, but obviously it doesn't work. So, I was wondering what's wrong with my pretty trigger.

Would be grateful for your help,

Devrak

 

[Dinowc]

there is no issued order and you must put matching unit, but it wont make any difference since your triggers are really messed up...

 

[Ouguiya]

Well what I can say from this first look at the trigger, is that there are some problems:

First, whenever someone presses the down key, the variable is set to x+1. In the beginning, I am asuming that the variable is 0, so, after pressing the down key once, it would be 1.

However, then the variable can ONLY be 1, since it is immediatly set to 0 again, thus the "Else" function is worthless.

The next problem also is with the "issued order". This causes a lot of confusion, but the issued order is not specified to a specific unit, thus the program will probably use the issued order of the triggering unit, but there is no such unit, so the program does nothing.

The third error I found was that you used "Picked unit" when you should have used "Matching unit".

Give it a try

PS: A slight hint is, next time, post your trigger with the WC3 tag, instead of the CODE tag. This makes it much easier to read.

Yours,

Ouguiya

 

[Devrak]

First, whenever someone presses the down key, the variable is set to x+1. In the beginning, I am asuming that the variable is 0, so, after pressing the down key once, it would be 1.

However, then the variable can ONLY be 1, since it is immediatly set to 0 again, thus the "Else" function is worthless.
Ouguiya

Yes, that's because you need to double-click on it to make it work.

The next problem also is with the "issued order". This causes a lot of confusion, but the issued order is not specified to a specific unit, thus the program will probably use the issued order of the triggering unit, but there is no such unit, so the program does nothing.

The third error I found was that you used "Picked unit" when you should have used "Matching unit".
Ouguiya

Ah, yes, silly me. That solved the problem, it works perfectly now, thanks alot for taking your time to help me!

PS: A slight hint is, next time, post your trigger with the WC3 tag, instead of the CODE tag. This makes it much easier to read.
Ouguiya

Ah, will do it next time, didn't know I could do that.

 

[Devrak]

Hum, now I got another problem, the units wont move if they weren't moving at first with the 'stop' order, but if they were moving at first it works fine.

Does anyone have a clue what the error could be?

• Down Arrow 1
  • Events
    • Player - Player 1 (Red) Presses the Down Arrow key
  • Conditions
  • Actions
    • Set P1DoubleArrow = (P1DoubleArrow + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • P1DoubleArrow Equal to 1
      • Then - Actions
        • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Current order of (Matching unit)) Not equal to (Order(hold position))) and ((Owner of (Matching unit)) Equal to Player 1 (Red)))) and do (Actions)
          • Loop - Actions
            • Unit - Order (Picked unit) to Attack-Move To (Random point in P1 Spawnpoint <gen>)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • P1DoubleArrow Equal to 2
          • Then - Actions
            • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Current order of (Matching unit)) Not equal to (Order(hold position))) and ((Owner of (Matching unit)) Equal to Player 1 (Red)))) and do (Actions)
              • Loop - Actions
                • Unit - Order (Picked unit) to Move To (Random point in P1 Spawnpoint <gen>)
          • Else - Actions
    • Wait 0.15 seconds
    • Set P1DoubleArrow = 0

Thanks,

Devrak

 

[pixartist]

there is no issued order and you must put matching unit, but it wont make any difference since your triggers are really messed up...

how is anything messed up there?