Problem with making a semi-MUI spell

[Erkki2]

I'm trying to make a spell that creates a dummy unit at 90% chance to cast stun spell (sleep) to target. After 2-10 seconds (random) the buff should be removed from target unit. There may be several units casting this ability at the same time, but never more than 100. I'm using wait function so I must save target unit into a variable. But how can I do that? Is it possible using arrays?

 

[skyblader]

Er, ill whip up a trigger fer u.

ability
    Events
        Unit - A unit Is attacked
    Conditions
        (Attacking unit) Equal to UnitVariable
    Actions
        Set intergerVar = (Random integer number between 1 and 10)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                intergerVar Less than or equal to 9
            Then - Actions
                Unit - Create 1 Dummy for (owner of (attacking unit)) at (position of (attacking unit)) facing Default building facing degrees
                Set UnitVariable = (Last created unit)
                Unit - Add Sleep to UnitVariable
                Unit - Order UnitVariable to Undead Dreadlord - Sleep (Triggering unit)
                Unit - Remove UnitVariable
            Else - Actions

Ok, all this does is, if u hit an enemy, 90% chance , a dummy will spawn and cast sleep on the unit and will be destroyed.
U have to create 2 unit variables, and 1 interger variable. If more than 1 of this happens at a type, dummy units might not go away, of course its ok, but it makes lag and so on.(and may not have a chance to cast sleep.) To solve this, u can get help from someone to loop this. Idk how. And also, at the start of the game, please set UnitVariable 1, to the hero. Lets say:

Event - A unit enters playable map area
condition - Unit type of triggering unit is so and so
Actions - Set unitvariable 1 to triggering unit

This works for if the hero can only be selected once. er if not, get help to loop(again). Its something like set variable, and then, set it to var+1, but it must be in a loop. Hope i helped.

 

[darkbeer]

@ skyblade: dont use teh remove function for the dummy, your way it will be removed before it even gets the cahcne to cast a spell, use a expiration timer instead much simpler.

easiest way are as often locals^^

ability
    Events
        Unit - Starts the effect of an ability
    Conditions
        Ability being cast == "whatever"
    Actions
        Custom script: local unit u = GetSpellTargetUnit()
        Set intergerVar = (Random integer number between 1 and 10)
        Set TempPoint = Position of (triggering unit)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                intergerVar Less than or equal to 9
            Then - Actions
                Unit - Create 1 Dummy for (owner of (triggering unit)) at TempPoint facing Default building facing degrees
                Unit - Add Sleep to UnitVariable
                Unit - Order UnitVariable to Undead Dreadlord - Sleep (Triggering unit)
                Unit - Add 2 second generic expiration timer to Last created unit
                Custom script: call RemoveLocation(udg_TempPoint)
                Wait - Random integer between 2 and 10
                Custom script: set TempUnit = u
                Unit - Remove buff "UR BUFF" from TempUnit
            Else - Actions

 

[skyblader]

Lol my bad at the remove part but, idk how to use custom scripts so, lol.

 

[Erkki2]

I thought locals couldn't be used in if-then-else-functions. I tried it and it works perfectly. Thank you very much!

 

[vypur85]

Pseudo-locals cannot be used in conditions. But there's workaround. You can globalise it back and then use it.

    Actions
        Custom script: local unit u = GetSpellTargetUnit()
        Set intergerVar = (Random integer number between 1 and 10)
        Set TempPoint = Position of (triggering unit)
        [B]Set u = TempUnit[/B]
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                [B]TempUnit is alive Equal to True[/B]
                intergerVar Less than or equal to 9
            Then - Actions
        ....

This'll work. Anyway, this is just for future references since it's not related to the trigger you want .

 

[MoonSlinger]

Shorter way which makes it totally MUI.

Object Editor
Make your dummy's spell have 9 levels (more if you need)
Lv1 - sleep 1s
Lv2 - sleep 2s
Lv3 - sleep 3s
etc... etc...

Trigger:

    Actions
        Set intergerVar = (Random integer number between 1 and 10)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                intergerVar equal to 10
            Then - Actions
            Else - Actions
                Set TempPoint = Position of (triggering unit)
                Unit - Create 1 Dummy for (owner of (triggering unit)) at TempPoint facing Default building facing degrees
                Unit - Add Sleep to (Last created unit)
                Unit - Set level of Sleep for (Last created unit) to intergerVar 
                Unit - Order (Last created unit) to Undead Dreadlord - Sleep (Triggering unit)
                Unit - Add 2 second generic expiration timer to (Last created unit)
                Custom script: call RemoveLocation(udg_TempPoint)

 

[Erkki2]

Thanks for replies. Now I'm making a similar spell but AOE. There are only 1 vs 1 battles on my map, so I can set t to random enemy unit in the area of spell effect. I get an error:

Custom script:   set t = GroupPickRandomUnit(GetUnitsInRangeOfLocMatching(200.00, GetSpellTargetLoc(), Condition( IsPlayerEnemy(GetFilterPlayer(), GetOwningPlayer(GetTriggerUnit())) == true )

"Invalid argument type (boolean)"
I don't see any reason for the error. What's wrong?

 

[AceHart]

> What's wrong?

Plenty of things...
Your condition for example.

function IsEnemy takes nothing returns boolean
    return IsPlayerEnemy(GetOwningPlayer(GetTriggerUnit()), GetOwningPlayer(GetFilterUnit()))
endfunction

local boolexpr filter = Condition(function IsEnemy)
local group g = GetUnitsInRangeOfLocMatching(200.0, GetSpellTargetLoc(), filter)
local unit u = GroupPickRandomUnit(g)

There are better versions...

 

[Erkki2]

Thanks, I made it in jass and got it work.

Edit: I guess locals can't be used in loops?