revive trigger not compiling

PrisonLove

Hard Realist
Reaction score
78
Okay so the goal here was to revive a unit (make a new one) when the old unit dies. If the player has lumber, the unit is revived at the location the old one died after 1 second, otherwise it will be revived after five seconds in one of many predetermined spots. I get an 'Expected a function name' error on a random line and don't know why. Here is the code:

JASS:
function PlayerReviveConditions takes nothing returns boolean
    local integer id = GetUnitTypeId(GetTriggerUnit())
    call BJDebugMsg("Dead unit Id is " + I2S(id))  //debugging
    return (id == 'h000' or id == 'h001' or id == 'h002' or id == 'h003')
endfunction


function PlayerReviveCallback takes nothing returns nothing
    local timer t = GetExpiredTimer()
    local integer id = GetHandleId(t)
    local unit u = LoadUnitHandle(udg_hash, id, 0)
    local real ux = LoadReal(udg_hash, id, 1)
    local real uy = LoadReal(udg_hash, id, 2)
    local boolean xtraLife = LoadBoolean(udg_hash, id, 3)
    local player p = GetOwningPlayer(u)
    local integer uid = GetUnitTypeId(u)
    local integer randomInt = GetRandomInt(1, udg_ReviveZoneMax)
    local real xmin = GetRectMinX(udg_ReviveZoneArray[randomInt])
    local real xmax = GetRectMaxX(udg_ReviveZoneArray[randomInt])
    local real ymin = GetRectMinY(udg_ReviveZoneArray[randomInt])
    local real ymax = GetRectMaxY(udg_ReviveZoneArray[randomInt])
    local real x = GetRandomReal(xmin, xmax)
    local real y = GetRandomReal(ymin, ymax)

    call BJDebugMsg("Callback entered")  //debugging

    if (xtraLife) then
        set x = ux
        set y = uy
    endif

    call DestroyEffect(AddSpecialEffect("Abilities\\Spells\\Human\\ReviveHuman\\ReviveHuman.mdl", x, y))
    call CreateUnit(p, uid, x, y, 270)
    call SelectUnitForPlayerSingle(GetLastCreatedUnit(), p)
    call PanCameraToForPlayer(p, x, y)
    call FlushChildHashtable(udg_hash, id)

    call BJDebugMsg("Hashtable flushed")  //debugging

    call PauseTimer(t)
    call DestroyTimer(t)
    set t = null
    set u = null
endfunction


function PlayerReviveActions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local player p = GetOwningPlayer(u)
    local integer i = GetPlayerId(p) + 1
    local real x = GetUnitX(u)
    local real y = GetUnitY(u)
    local timer t = CreateTimer()
    local real timeout = 5
    local integer id = GetHandleId(t)
    local integer playerLumber = GetPlayerState(p, PLAYER_STATE_RESOURCE_LUMBER)
    local boolean xtraLife = false

    set udg_damageAmount<i> = 20
    set udg_attackRange<i> = 100
    set udg_offsetRange<i> = 50

    if (playerLumber &gt;= 1) then
        call SetPlayerState(p, PLAYER_STATE_RESOURCE_LUMBER, playerLumber - 1)
        set timeout = 1
        set xtraLife = true
    endif

    call SaveUnitHandle(udg_hash, id, 0, u)
    call SaveReal(udg_hash, id, 1, x)
    call SaveReal(udg_hash, id, 2, y)
    call SaveBoolean(udg_hash, id, 3, xtraLife)

    call BJDebugMsg(&quot;Values saved&quot;)  //debugging

    call TimerStart(t, timeout, false, function PlayerReviveCallback)

    set u = null
    set p = null
    set t = null
endfunction

//===========================================================================
function InitTrig_PlayerRevive takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddCondition( t, Condition( function PlayerReviveConditions ) )
    call TriggerAddAction( t, function PlayerReviveActions )
    set t = null
endfunction
</i></i></i>
 

the Immortal

I know, I know...
Reaction score
51
[ljass]function PlayerReviveConiditions takes nothing returns boolean[/ljass]

[ljass]PlayerReviveConiditions[/ljass]

[ljass]Coniditions[/ljass]

Simply a misstyped function name, I suppose.
 

PrisonLove

Hard Realist
Reaction score
78
My god, how did I not see that, lol. Thanks, good catch.

Now it compiles but it doesn't work. Can anyone see why? All of the global variables are properly initialized.
 

hgkjfhfdsj

Active Member
Reaction score
55
add bjdebugmsg. (the usual :p)

are you reviving normal units?
test by adding either getunitname or unittypeid in callback.

if you are, save player into hashtable and use that as reference (rather than the null unit)
 

PrisonLove

Hard Realist
Reaction score
78
So after adding debug messages to the code, I have found that it enters the callback function and flushes the hashtable, but the unit is never revived. Any ideas why?

Edit: okay I got the unit to revive, it turns out since the unit has no decay I couldn't reference it after the 5 seconds were up. Now the unit revives and the camera pans, but the unit isn't selected. Is there a reason for this? lol

Edit 2: never mind, I got it working. Thanks for the help.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top