Spellpack Ring Of Fire, Lightning Wall

[shadowvzs]

noobish diablo spell (but not have perfect design the lightning wall)
this spells is only a ideea

Trigger:

Fire Ring
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Summon Water Elemental
    Actions
        Set DummyUnit = Phoenix
        Set Point[0] = (Position of (Casting unit))
        For each (Integer A) from 1 to 72, do (Actions)
            Loop - Actions
                Set DummyAngle = (DummyAngle + 5.00)
                Set Point[1] = (Point[0] offset by 300.00 towards DummyAngle degrees)
                Unit - Create 1 DummyUnit for (Owner of (Casting unit)) at Point[1] facing Default building facing degrees
                Custom script:   call RemoveLocation(udg_Point[1])
        Custom script:   call RemoveLocation(udg_Point[0])

Lightning Wall
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to Chain Lightning
    Actions
        Set DummyUnit = Lightning
        Set Point[0] = (Position of (Casting unit))
        Set Point[2] = (Position of (Target unit of ability being cast))
        Set DummyAngle = ((Angle from Point[0] to Point[2]) + 90.00)
        Unit - Create 1 DummyUnit for (Owner of (Casting unit)) at Point[2] facing DummyAngle degrees
        Set DummyX = 0.00
        For each (Integer A) from 1 to 30, do (Actions)
            Loop - Actions
                Set DummyX = (DummyX + 50.00)
                Set Point[1] = (Point[2] offset by (DummyX - 750.00) towards DummyAngle degrees)
                Unit - Create 1 DummyUnit for (Owner of (Casting unit)) at Point[1] facing DummyAngle degrees
                Custom script:   call RemoveLocation(udg_Point[1])
        Custom script:   call RemoveLocation(udg_Point[0])
        Custom script:   call RemoveLocation(udg_Point[2])

The Demo Map

 

[waaaks!]

hey, youve post so many spells....

nice enough! and keep helping people!

+rep

 

[Ryuu]

My opinions

Very well done. The Ring of Fire is excellent, but one note : does it incinerates, immolates, or simply damages the enemies entering the ring?

On the other hand, Lightning Wall is bad. Real bad. It's just my opinion, no offends

 

[LegACy99]

Fire ring>

Set Point[0] = (Position of [b](Casting unit)[/b])
Unit - Create 1 DummyUnit for (Owner of [B](Casting unit)[/B]) at Point[1] facing Default building facing degrees

It'll be faster if u use 'triggering unit' instead...
I don't think you should destroy location variable every loop, just destroy it at the end of the trigger. And also:

Set DummyAngle = (DummyAngle + 5.00)

why don't you just use: dummyangle = 5 x integer(A) ??

Lightning wall>
again, use 'triggering unit':

Set Point[0] = (Position of [B](Casting unit)[/B])

And there's several other mistake too, I'm too lazy to write them ^^

 

[emjlr3]

those are not leaks, from the code you posted it actually looks fine to me

 

[Rheias]

Nice spell, altough both have been done before.

Triggering unit is better then casting unit always. It is faster and safer, I suggest changing all those "casting unit".

Fire Ring:

Looks good, there is one problem only though, it is hard to modify this spell, say if you want to change the circle's radius you'll need to modify the loop as well... Maybe add an equation? Also 72 dummies is a bit much, making the units bigger and reducing the amount of them created should be better.

Lightning Wall:

Nice loop there, although again 30 dummies is a bit much.

Edit: LegACy99, what are you talking about? His spells are leakless. Read the leaks tutorials (I believe only in this site there are over 6 of them).

 

[LegACy99]

Goddamit. I forgot that unit doesn't leak! Sorry, my bad. it's been my habit to make anything that has function into a variable, like 'target of ability being cast = spell_target', etc

Sorry!

 

[Omni]

fire should not have a shadow, because it's a light source
... remove the shadows !

 

[Sim]

You have to create new custom abilities. These spells are meant to be shared, don't use Water Elemental when the spell is Fire Ring!

Same for the dummyunit, Phoenix. It has to be a custom unit.

I had a problem with the spells, I don't know why. Lightning wall dealt damage while Ring of Fire dealt none. But they share the same immolation ability. I suggest reseting the values as they were before editing and change only the damage. Also, Ring of fire lags.

----------------------------

They look nice but are pretty straight-forward. Goes through a simple loop.