Spell Targeting Problems

Ellimistrox

New Member
Reaction score
10
Ok, I'm pretty new to Jass, only started recently, and mainly self taught. I've made a spell in GUI, Static Electricity, then tried converting it to Jass, filling with locals where required and removed as many BJ's as I could. However No matter what I seem to do when in Jass it hits only one unit, dealing damage and stunning, whereas it is meant to hit one in five units. (Used random integer condition, integer is set between 1-100, if equal to or below 20 the unit is stunned and damaged for 10 times the current mana of the caster.)

Also it IS meant to remove all mana from the unit.

PS It DID work in GUI form. :banghead:

JASS:
function Trig_Static_Electricity_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A005'   
endfunction

function Trig_Static_Electricity_Func001Func001Func004C takes nothing returns boolean
    if ( not ( GetRandomInt(1, 100) <= 20 ) ) then
        return false
    endif
    return true
endfunction

function Trig_Static_Electricity_Func001Func001C takes nothing returns boolean
    if ( not ( IsUnitType(GetEnumUnit(), UNIT_TYPE_STRUCTURE) == false ) ) then
        return false
    endif
    if ( not ( IsUnitEnemy(GetEnumUnit(), GetOwningPlayer(GetSpellAbilityUnit())) == true ) ) then
        return false
    endif
    if ( not ( IsUnitAliveBJ(GetEnumUnit()) == true ) ) then
        return false
    endif
    return true
endfunction

function Trig_Static_Electricity_Func001A takes nothing returns nothing
    
  local unit u = GetSpellAbilityUnit()
  local player p = GetOwningPlayer(u)
  local real x
  local real y
  local unit e
  local unit d
  local real r = ( GetUnitStateSwap(UNIT_STATE_MANA, GetSpellAbilityUnit()) * 10.00 )
  
    
    if ( Trig_Static_Electricity_Func001Func001C() ) then
        if ( Trig_Static_Electricity_Func001Func001Func004C() ) then
            set e = GetEnumUnit()
            set x = GetUnitX(e)
            set y = GetUnitY(e)
            set d = CreateUnit( p, 'h006', x, y, bj_UNIT_FACING )
            call UnitAddAbility( d, 'A006' )
            call IssueTargetOrder( d, "thunderbolt", e )
            call UnitApplyTimedLife( d, 'BTLF', 0.50 )
            call UnitDamageTarget( u, e, r, false, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_WHOKNOWS )
            
        else
        endif
        
    else
    endif
    
endfunction

function Trig_Static_Electricity_Actions takes nothing returns nothing

    local group g = GetUnitsInRectAll(GetEntireMapRect())
    
    call ForGroup(g, function Trig_Static_Electricity_Func001A )
    call SetUnitManaPercentBJ( GetSpellAbilityUnit(), 0.00 )
    
    call PolledWait(2.50)
    
    call DestroyGroup(g)
endfunction

function InitTrig_Static_Electricity takes nothing returns nothing
    set gg_trg_Static_Electricity = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Static_Electricity, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Static_Electricity, Condition( function Trig_Static_Electricity_Conditions ) )
    call TriggerAddAction( gg_trg_Static_Electricity, function Trig_Static_Electricity_Actions )
endfunction
 

cleeezzz

The Undead Ranger.
Reaction score
268
JASS:
scope Spell initializer Init

globals
    unit Caster
endglobals

private function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'A005'   
endfunction

private function Shock takes nothing returns nothing
    
  local unit u = Caster
  local player p = GetOwningPlayer(u)
  local real x
  local real y
  local unit e
  local unit d
  local real r = GetUnitState(u, UNIT_STATE_MANA) * 10.00 
    
  if IsUnitType(GetEnumUnit(), UNIT_TYPE_STRUCTURE) == false and IsUnitEnemy(GetEnumUnit(), GetOwningPlayer(u)) == true and GetUnitState(GetEnumUnit(), UNIT_STATE_LIFE) > .405 then
        if GetRandomInt(1, 100) <= 20 then
            set e = GetEnumUnit()
            set x = GetUnitX(e)
            set y = GetUnitY(e)
            set d = CreateUnit( p, 'h006', x, y, bj_UNIT_FACING )
            call UnitAddAbility( d, 'A006' )
            call IssueTargetOrder( d, "thunderbolt", e )
            call UnitApplyTimedLife( d, 'BTLF', 0.50 )
            call UnitDamageTarget( u, e, r, false, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_WHOKNOWS )
        endif
    endif 
endfunction

private function Actions takes nothing returns nothing
    local group g = GetUnitsInRectAll(GetEntireMapRect())
    set Caster = GetTriggerUnit()
    call ForGroup(g, function Shock )
    call SetUnitManaPercentBJ( GetSpellAbilityUnit(), 0.00 )
    call PolledWait(2.50)
    call DestroyGroup(g)
endfunction

private function Init takes nothing returns nothing
    local trigger trig = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( trig, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( trig, Condition( function Conditions ) )
    call TriggerAddAction( trig, function Actions )
endfunction

endscope

try that, you need newgen btw

(I think your problem was trying to use GetSpellAbilityUnit() in the ForGroup loop, but since the ForGroup is a completely separate function, it doesn't carry over, im a bit rusty so im not sure)
 

saw792

Is known to say things. That is all.
Reaction score
280
Name the scope, too. And add the initialiser bit.
 

Squll2

je'ne sais pas
Reaction score
76
OK first off, hes obviously programming in normal jass, why the hell would u give a Vjass answer? thats just stupid, he wants to learn not have you blast some code in his face and make him go dl some other program that he might not even know about?

THINK people, and Globals? from that looks of it this guy wants the spell to be MUI otherwise he would have used globals himself.

________

Other then that, im not really sure what the problem is with the code, or how its a code in the first place :( its not really making sense to me right now, but its still early and im not awake yet :p
 

cleeezzz

The Undead Ranger.
Reaction score
268
its still mui.. just cuz it contains a global doesn't mean its not mui, nothing in the code uses the global AFTER the wait 2 seconds so its fine.

and i dont know normal jass so i dont use it, i learned vjass from the start

and its been awhile so yea i forgot to name the scope

JASS:
scope Spell initializer Init


and newgen is like a must for map makers, even if you dont use jass
 

Squll2

je'ne sais pas
Reaction score
76
Ok i Apologize, long time since i Jassed = Me thinking all globals mean non MUI :p
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top