This item stacking system isnt working =(

a j j bones

a j j bones

New Member
Reaction score
3
I got this system from Mr.Zero but its not working, it works off the level of the item and that is how much it should stack, but there not stacking.

JASS:
function ISS_Set_Charges takes nothing returns nothing
    local integer i = 0
    local item a = GetManipulatedItem()
    local unit b = GetManipulatingUnit()
    if (GetItemCharges(a)>=1) then
        loop
            exitwhen i>5
            if (((UnitItemInSlot(b,i)!=a)and(GetItemTypeId(UnitItemInSlot(b,i))==GetItemTypeId(a)))and(GetItemCharges(UnitItemInSlot(b,i))<GetItemLevel(a))) then
                if ((GetItemCharges(UnitItemInSlot(b,i))+GetItemCharges(a))<=GetItemLevel(a)) then
                    call SetItemCharges(UnitItemInSlot(b,i),(GetItemCharges(UnitItemInSlot(b,i))+GetItemCharges(a)))
                    call RemoveItem(a)
                    set i = 5
                else
                    call SetItemCharges(a, ((GetItemCharges(UnitItemInSlot(b, i)) + GetItemCharges(a))) - GetItemLevel(a))
                    call SetItemCharges(UnitItemInSlot(b, i), GetItemLevel(a))
                    call UnitAddItem(b, a)
                    set i = 5
                endif
            endif
            set i = i + 1
        endloop
    endif
    set a = null
    set b = null
    return
endfunction

function ISS_Remove_Charges takes nothing returns nothing
    local integer i
    local integer b = GetIssuedOrderId()
    local unit c = GetOrderedUnit()
    local location d = GetUnitLoc(c)
    local location e = Location(GetLocationX(d) + 80.00 * Cos(GetUnitFacing(c) * (3.14159/180.0)),GetLocationY(d) + 80.00 * Sin(GetUnitFacing(c) * (3.14159/180.0)))
    local item f = GetOrderTargetItem()
    local item g = UnitItemInSlot(c, (b - 852002))
    if ((((b >= 852002) and (b <= 852007)) and (GetItemCharges(f) != 0) and (g != null))) then
        if (f == g) then
            set g = CreateItem(GetItemTypeId(f), GetLocationX(e), GetLocationY(e))
            set i = GetItemCharges(g)
            call RemoveItem(g)
            if (GetItemCharges(f) > i) then
                call SetItemCharges(f, (GetItemCharges(f) - i))
                set g = CreateItem(GetItemTypeId(f), GetLocationX(e), GetLocationY(e))
                call SetItemCharges(g, i)
                set i = 0
                loop
                    exitwhen i > 5
                    if ( UnitItemInSlot(c, i) == null) then
                        call DisableTrigger(gg_trg_Item_Stacking_System)
                        call UnitAddItem(c, g)
                        call EnableTrigger(gg_trg_Item_Stacking_System)
                        set i = 5
                    endif
                    set i = i + 1
                endloop
            else
                call UnitRemoveItem(c, f)
                call SetItemPosition(f, GetLocationX(e), GetLocationY(e))
            endif
        else
            if (((GetItemTypeId(f) == GetItemTypeId(g)) and (f != g)) and (GetItemCharges(f) < GetItemLevel(f))) then
                if ((GetItemCharges(f) + GetItemCharges(g)) <= GetItemLevel(f)) then
                    call SetItemCharges(f, (GetItemCharges(f) + GetItemCharges(g)))
                    call RemoveItem(g)
                else
                    call SetItemCharges(g, ((GetItemCharges(f) + GetItemCharges(g))) - GetItemLevel(f))
                    call SetItemCharges(f, GetItemLevel(f))
                endif
            endif
        endif
    endif
    set c = null
    set f = null
    set g = null
    call RemoveLocation(d)
    call RemoveLocation(e)
    return
endfunction

//===========================================================================
function InitTrig_Item_Stacking_System takes nothing returns nothing
    local integer i = 0
    local trigger ISS_Remove_Charges_Trigger = CreateTrigger()
    set gg_trg_Item_Stacking_System = CreateTrigger()
    loop
        exitwhen i == bj_MAX_PLAYER_SLOTS
        call TriggerRegisterPlayerUnitEvent(gg_trg_Item_Stacking_System, Player(i), EVENT_PLAYER_UNIT_PICKUP_ITEM, null)
        call TriggerRegisterPlayerUnitEvent(ISS_Remove_Charges_Trigger, Player(i), EVENT_PLAYER_UNIT_ISSUED_TARGET_ORDER, null)
        set i = i + 1
    endloop
    call TriggerAddAction(gg_trg_Item_Stacking_System, function ISS_Set_Charges)
    call TriggerAddAction(ISS_Remove_Charges_Trigger, function ISS_Remove_Charges)
    set ISS_Remove_Charges_Trigger = null
endfunction
 
PurgeandFire

PurgeandFire

zxcvmkgdfg
Reaction score
509
Did you use those functions? Where is your trigger?

Just so you know, it doesn't automatically make items stack. You have to use those custom-defined functions yourself to make it stack. Those are just to simplify the work used to make them stack, it doesn't do all of the work for you. I'm pretty sure of myself. :p

If you need help, you can post here or ask Mr. Zero since he is the creator. :)
 
a j j bones

a j j bones

New Member
Reaction score
3
it says in his system thread the only work you have to do is change the level of he item to the stacking limit and thats it, and mr zero doesnt go on these forums anymore
 
S

SFilip

Gone but not forgotten
Reaction score
634
> but there not stacking
Doesn't work at all or doesn't stack correctly?

Anyway you're always welcome to use my stacking system (one topic above Mr. Zero's) :)
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      No members online now.
      Online now:
      113 (members: 1, guests: 112)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top