Trigger to create a square pattern, but something is wrong :S

Komaqtion

You can change this now in User CP.
Reaction score
469
Hi !

Ok, so I'm trying to create a pattern on the terrain on Map Init using special effects created a set range between eachother, with columns and rows...

Ok, so this is only supposed to create the vertical stuff atm, but something is wrong XD

It only creates one single "row" with the first big loop (But I'd believe it still puts the right amount of SFXs in those 24 lines, meaning that it isn't changing row...), and then it creates some random pattern with the other big loop (They cross the SFXs from the first loop sometimer, horizontally I mean, and create crosses and stuff)

Any ideas on why this is happening ? :S

JASS:
scope BorderInit initializer Init

    globals
        private constant integer COLUMNS = 12
        private constant integer ROWS = 12
        
        private constant integer BORDER_RES = 15          // How many effect the border for each square will consist of !
        private constant real SQUARE_HEIGHT = 480.
        private constant real SQUARE_WIDTH = 480.
        private constant real SQUARE_HD = SQUARE_HEIGHT / BORDER_RES
        private constant real SQUARE_WD = SQUARE_WIDTH / BORDER_RES
        
        private constant string SFX_PATH = "Abilities\\Weapons\\SpiritOfVengeanceMissile\\SpiritOfVengeanceMissile.mdl"
    endglobals
    
    globals
        //private effect array Border_SFX
    endglobals

    private function Init takes nothing returns nothing
        local integer r = 0
        local integer c
        local real x = 0
        local real y = 0
        
        local integer i = 0
        
        loop
            exitwhen i >= 12
            call FogModifierStart( CreateFogModifierRect( Player( i ), FOG_OF_WAR_VISIBLE, bj_mapInitialPlayableArea, true, true ) )
            
            set i = i + 1
        endloop
        
        loop
            exitwhen r >= ROWS
            set c = 0
            
            loop
                exitwhen c >= COLUMNS
                set y = r * SQUARE_HD
                set x = c * SQUARE_WIDTH
                
                loop
                    exitwhen y >= ( r * SQUARE_HD ) + SQUARE_HEIGHT
                    call AddSpecialEffect( SFX_PATH, x, y )
                    
                    set y = y + SQUARE_HD
                endloop
                
                set c = c + 1
            endloop
            
            set c = 1
            
            loop
                exitwhen c > COLUMNS
                set y = r * ( -( SQUARE_HD ) )
                set x = c * ( -SQUARE_WIDTH )
                
                loop
                    exitwhen y <= ( -( r * SQUARE_HD ) ) - SQUARE_HEIGHT
                    call AddSpecialEffect( SFX_PATH, x, y )
                    
                    set y = y - ( SQUARE_HD )
                endloop
                
                set c = c + 1
            endloop
            
            set r = r + 1
        endloop
        
        set r = 0
        set c = 0
        
        loop
            exitwhen c >= COLUMNS
            set r = 0
            
            loop
                exitwhen r >= ROWS
                set x = c * SQUARE_WD
                set y = r * SQUARE_HEIGHT
                
                loop
                    exitwhen x >= ( c * SQUARE_WD ) + SQUARE_WIDTH
                    call AddSpecialEffect( SFX_PATH, x, y )
                    
                    set x = x + SQUARE_WD
                endloop
                
                set r = r + 1
            endloop
            
            set r = 1
            
            loop
                exitwhen r > ROWS
                set x = c * ( -( SQUARE_WD ) )
                set y = r * ( -SQUARE_HEIGHT )
                
                loop
                    exitwhen x <= ( -( c * SQUARE_WD ) ) - SQUARE_WIDTH
                    call AddSpecialEffect( SFX_PATH, x, y )
                    
                    set x = x - ( SQUARE_WD )
                endloop
                
                set r = r + 1
            endloop
            
            set c = c + 1
        endloop
        
    endfunction

endscope
 

No_exit

Regular User (What is Custom User Title?)
Reaction score
40
Hej,
Can you please post a clear picture of what pattern you are expecting to see? It's hard to find out what you are doing wrong when we don't know what it is supposed to do.
 

the Immortal

I know, I know...
Reaction score
51
Most probably hitting the operation limit. Ysee, its impossible to execute over ~45k statements in a single thread (varying, read the post for more details, though it's completely untested/etc)


So you gotta spread the actions in the loops over several functions and do func.execute() in the main loop. It will slow down the exec speed.. but it's the only viable solution afaik.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top