Trigger to create a square pattern, but something is wrong :S

Komaqtion

You can change this now in User CP.
Reaction score
469
Hi !

Ok, so I'm trying to create a pattern on the terrain on Map Init using special effects created a set range between eachother, with columns and rows...

Ok, so this is only supposed to create the vertical stuff atm, but something is wrong XD

It only creates one single "row" with the first big loop (But I'd believe it still puts the right amount of SFXs in those 24 lines, meaning that it isn't changing row...), and then it creates some random pattern with the other big loop (They cross the SFXs from the first loop sometimer, horizontally I mean, and create crosses and stuff)

Any ideas on why this is happening ? :S

JASS:
scope BorderInit initializer Init

    globals
        private constant integer COLUMNS = 12
        private constant integer ROWS = 12
        
        private constant integer BORDER_RES = 15          // How many effect the border for each square will consist of !
        private constant real SQUARE_HEIGHT = 480.
        private constant real SQUARE_WIDTH = 480.
        private constant real SQUARE_HD = SQUARE_HEIGHT / BORDER_RES
        private constant real SQUARE_WD = SQUARE_WIDTH / BORDER_RES
        
        private constant string SFX_PATH = "Abilities\\Weapons\\SpiritOfVengeanceMissile\\SpiritOfVengeanceMissile.mdl"
    endglobals
    
    globals
        //private effect array Border_SFX
    endglobals

    private function Init takes nothing returns nothing
        local integer r = 0
        local integer c
        local real x = 0
        local real y = 0
        
        local integer i = 0
        
        loop
            exitwhen i >= 12
            call FogModifierStart( CreateFogModifierRect( Player( i ), FOG_OF_WAR_VISIBLE, bj_mapInitialPlayableArea, true, true ) )
            
            set i = i + 1
        endloop
        
        loop
            exitwhen r >= ROWS
            set c = 0
            
            loop
                exitwhen c >= COLUMNS
                set y = r * SQUARE_HD
                set x = c * SQUARE_WIDTH
                
                loop
                    exitwhen y >= ( r * SQUARE_HD ) + SQUARE_HEIGHT
                    call AddSpecialEffect( SFX_PATH, x, y )
                    
                    set y = y + SQUARE_HD
                endloop
                
                set c = c + 1
            endloop
            
            set c = 1
            
            loop
                exitwhen c > COLUMNS
                set y = r * ( -( SQUARE_HD ) )
                set x = c * ( -SQUARE_WIDTH )
                
                loop
                    exitwhen y <= ( -( r * SQUARE_HD ) ) - SQUARE_HEIGHT
                    call AddSpecialEffect( SFX_PATH, x, y )
                    
                    set y = y - ( SQUARE_HD )
                endloop
                
                set c = c + 1
            endloop
            
            set r = r + 1
        endloop
        
        set r = 0
        set c = 0
        
        loop
            exitwhen c >= COLUMNS
            set r = 0
            
            loop
                exitwhen r >= ROWS
                set x = c * SQUARE_WD
                set y = r * SQUARE_HEIGHT
                
                loop
                    exitwhen x >= ( c * SQUARE_WD ) + SQUARE_WIDTH
                    call AddSpecialEffect( SFX_PATH, x, y )
                    
                    set x = x + SQUARE_WD
                endloop
                
                set r = r + 1
            endloop
            
            set r = 1
            
            loop
                exitwhen r > ROWS
                set x = c * ( -( SQUARE_WD ) )
                set y = r * ( -SQUARE_HEIGHT )
                
                loop
                    exitwhen x <= ( -( c * SQUARE_WD ) ) - SQUARE_WIDTH
                    call AddSpecialEffect( SFX_PATH, x, y )
                    
                    set x = x - ( SQUARE_WD )
                endloop
                
                set r = r + 1
            endloop
            
            set c = c + 1
        endloop
        
    endfunction

endscope
 

No_exit

Regular User (What is Custom User Title?)
Reaction score
40
Hej,
Can you please post a clear picture of what pattern you are expecting to see? It's hard to find out what you are doing wrong when we don't know what it is supposed to do.
 

the Immortal

I know, I know...
Reaction score
51
Most probably hitting the operation limit. Ysee, its impossible to execute over ~45k statements in a single thread (varying, read the post for more details, though it's completely untested/etc)


So you gotta spread the actions in the loops over several functions and do func.execute() in the main loop. It will slow down the exec speed.. but it's the only viable solution afaik.
 
General chit-chat
Help Users
  • No one is chatting at the moment.

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top