[vJass] Command system issue.

[Xorifelse]

I'm trying to make a command system but I'm stuck on something.
The reason is because you're not allowed to have "code" arrays.

Now I need a work around on this issue, otherwise the script doesnt know which code to execute for which command.

library Commands requires UserData, Triggers

    globals
        constant string COMMANDS_PREFIX = "-"
    endglobals
    
    struct command
        trigger t
        string  command
        string  toExecute
        
        static method onCommandEvent takes nothing returns nothing
            local command c = GetTriggerData( GetTriggeringTrigger() )
            local integer i = StringLength( COMMANDS_PREFIX )
            local integer l = StringLength( c.command )
            local string  s = GetEventPlayerChatString()
            local string  a = ""
            
            if SubString( s, i, i + l ) == c.command then
                // It all works until here..
                // Since I can't have code arrays, the only 2 ways I can think of is a "return bug", and a ExecuteFunc( "str" )
                // However, for the return bug I need I2H, and ExecuteFunc is a bit.. not easy for the end user.
            endif
        endmethod
        
    endstruct
    
    function registerCommandForUser takes user u, string cmdstr, string toExecute returns nothing
        local command cmd = 0
        
        if u.isPlayingUser then
            set cmd.          = command.create()
            set cmd.t         = NewTrigger()
            set cmd.command   = cmdstr
            set cmd.toExecute = toExecute
            call SetTriggerData( cmd.t, cmd )
                
            call TriggerRegisterPlayerChatEvent( cmd.t, u.p, COMMANDS_PREFIX + cmdstr, false )
            call TriggerAddAction( cmd.t, function command.onCommandEvent )
        endif
    endfunction
        
    function registerCommand takes string cmdstr, string toExecute returns nothing
        local command cmd = command.create()
        local user    u   = 0

        set cmd.t = NewTrigger()
        set cmd.command = cmdstr
        set cmd.toExecute = toExecute
        call SetTriggerData( cmd.t, cmd )
            
        loop
            exitwhen integer(u) > 11
                
            if u.isPlaying then
                call TriggerRegisterPlayerChatEvent( cmd.t, u.p, COMMANDS_PREFIX + cmdstr, false )
            endif
                
            set u = integer(u) + 1
        endloop
        
        call TriggerAddAction( cmd.t, function command.onCommandEvent )
    endfunction
    
endlibrary

This is how I intended to make commands:

scope testCommands initializer init

    private function codeToExecute takes nothing returns nothing
    endfunction

    private function anotherCodeToExecute takes nothing returns nothing
    endfunction
    
    private function init takes nothing returns nothing
        call registerCommandForPlayer( 0, "whatCmd", function codeToExecute )
        call registerCommand( "cmdWhat", function anotherCodeToExecute )
    endfunction
    
endscope

Does anyone have a workaround this issue?

 

[Flare]

You could have a boolexpr array, add the boolexpr to a static trigger with TriggerAddCondition, call TriggerEvaluate, and remove the boolexpr from the trigger with TriggerRemoveCondition?

 

[Xorifelse]

I'm not sure what you mean, how can this allow me to call different function for each command?

 

[Darthfett]

He means instead of code, you can use boolexpr's, and then instead of executing the function, you evaluate the condition after you add it to a trigger.

 

[Xorifelse]

Thanks guys for the help, Although I found a better solution.
I was just about to post that I did, but my Internet dropped out on my, so that's why the late response.

The fix was simple, too simple. Although I didn't knew you could add an action to a trigger if the code is below the call.