Weird Skill Lag

SkyXyden

SkyXyden

New Member
Reaction score
3
I'm having some problem with a skill I created, it create lag whenever it is used even though I already tried to find for leaks..

Skill Description
Thrust forward at amazing speed, stabbing through enemies and comes back right at them, dealing damage each hit.

Code: 
ZEN Boomerang Step
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to ZEN 2 Boomerang Step 
    Actions
        Set BStepUnit = (Triggering unit)
        Set BStepPoint[1] = (Position of BStepUnit)
        Set BStepPoint[2] = ((Position of BStepUnit) offset by 1200.00 towards (Angle from (Position of (Triggering unit)) to (Target point of ability being cast)) degrees)
        Set BStepPoint[3] = (Target point of ability being cast)
        Unit - Pause BStepUnit
        Unit - Hide BStepUnit
        Unit - Make BStepUnit Invulnerable
        -------- --- --------
        Unit - Create 1 Dummy Unit for (Owner of BStepUnit) at BStepPoint[1] facing Default building facing degrees
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        Animation - Change (Last created unit)'s size to (140.00%, 140.00%, 140.00%) of its original size
        Special Effect - Create a special effect at BStepPoint[1] using Abilities\Spells\Human\Thunderclap\ThunderClapCaster.mdl
        Special Effect - Destroy (Last created special effect)
        Unit - Add ZEN 2 Boomerang Step (Blast Point) to (Last created unit)
        Unit - Set level of ZEN 2 Boomerang Step (Blast Point) for (Last created unit) to (Level of ZEN 2 Boomerang Step  for (Triggering unit))
        Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave BStepPoint[3]
        -------- --- --------
        Set Temp_Point = (Center of Heroic Ground <gen>)
        Unit - Create 1 Dummy Unit (Sight Giver) for (Owner of BStepUnit) at Temp_Point facing Default building facing degrees
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        Unit - Turn collision for (Last created unit) Off
        Unit - Move (Last created unit) instantly to BStepPoint[1]
        Custom script:   call RemoveLocation(udg_Temp_Point)
        Custom script:   call RemoveLocation(udg_BStepPoint[1])
        Wait 0.40 game-time seconds
        -------- --- --------
        Unit - Create 1 Dummy Unit for (Owner of (Triggering unit)) at BStepPoint[2] facing Default building facing degrees
        Animation - Change (Last created unit)'s size to (140.00%, 140.00%, 140.00%) of its original size
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        Special Effect - Create a special effect at BStepPoint[2] using Abilities\Spells\Human\Thunderclap\ThunderClapCaster.mdl
        Special Effect - Destroy (Last created special effect)
        Unit - Add ZEN 2 Boomerang Step (Blast Point) to (Last created unit)
        Unit - Set level of ZEN 2 Boomerang Step (Blast Point) for (Last created unit) to (Level of ZEN 3 Intense Blade  for (Triggering unit))
        Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave BStepPoint[3]
        -------- --- --------
        Set Temp_Point = (Center of Heroic Ground <gen>)
        Unit - Create 1 Dummy Unit (Sight Giver) for (Owner of BStepUnit) at Temp_Point facing Default building facing degrees
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        Unit - Turn collision for (Last created unit) Off
        Unit - Move (Last created unit) instantly to BStepPoint[2]
        Custom script:   call RemoveLocation(udg_Temp_Point)
        Custom script:   call RemoveLocation(udg_BStepPoint[2])
        Custom script:   call RemoveLocation(udg_BStepPoint[3])
        Wait 0.40 game-time seconds
        Unit - Unpause BStepUnit
        Unit - Unhide BStepUnit
        Unit - Make BStepUnit Vulnerable
        Selection - Add (Triggering unit) to selection for (Owner of (Triggering unit))

Helps for this? I would gladly add your rep if you can save this skill.
 
Darthfett

Darthfett

Aerospace/Cybersecurity Software Engineer
Reaction score
615
Code: 
ZEN Boomerang Step
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to ZEN 2 Boomerang Step 
    Actions
        [b][del]Set BStepUnit = (Triggering unit)[/del][/b]
        Set BStepPoint[1] = (Position of BStepUnit)
        [b]Set BStepPoint[3] = (Target point of ability being cast)[/b]
        [b]Set BStepPoint[4] = (Position of (Triggering unit))[/b]
        Set BStepPoint[2] = ([b]BStepPoint[1][/b] offset by 1200.00 towards (Angle from [b]BStepPoint[4][/b] to [b]BStepPoint[3][/b]) degrees)
        [b][del]Set BStepPoint[3] = (Target point of ability being cast)[/del][/b]
        Unit - Pause BStepUnit
        Unit - Hide BStepUnit
        Unit - Make BStepUnit Invulnerable
        -------- --- --------
        Unit - Create 1 Dummy Unit for (Owner of [b](Triggering unit)[/b]) at BStepPoint[1] facing Default building facing degrees
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        Animation - Change (Last created unit)'s size to (140.00%, 140.00%, 140.00%) of its original size
        Special Effect - Create a special effect at BStepPoint[1] using Abilities\Spells\Human\Thunderclap\ThunderClapCaster.mdl
        Special Effect - Destroy (Last created special effect)
        Unit - Add ZEN 2 Boomerang Step (Blast Point) to (Last created unit)
        Unit - Set level of ZEN 2 Boomerang Step (Blast Point) for (Last created unit) to (Level of ZEN 2 Boomerang Step  for (Triggering unit))
        Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave BStepPoint[3] 
        -------- --- --------
        Set Temp_Point = (Center of Heroic Ground <gen>)
        Unit - Create 1 Dummy Unit (Sight Giver) for (Owner of [b](Triggering unit)[/b]) at Temp_Point facing Default building facing degrees
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        Unit - Turn collision for (Last created unit) Off
        Unit - Move (Last created unit) instantly to BStepPoint[1]
        Custom script:   call RemoveLocation(udg_Temp_Point)
        Custom script:   call RemoveLocation(udg_BStepPoint[1])
        Wait 0.40 game-time seconds
        -------- --- --------
        Unit - Create 1 Dummy Unit for (Owner of (Triggering unit)) at BStepPoint[2] facing Default building facing degrees
        Animation - Change (Last created unit)'s size to (140.00%, 140.00%, 140.00%) of its original size
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        Special Effect - Create a special effect at BStepPoint[2] using Abilities\Spells\Human\Thunderclap\ThunderClapCaster.mdl
        Special Effect - Destroy (Last created special effect)
        Unit - Add ZEN 2 Boomerang Step (Blast Point) to (Last created unit)
        Unit - Set level of ZEN 2 Boomerang Step (Blast Point) for (Last created unit) to (Level of ZEN 3 Intense Blade  for (Triggering unit))
        Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave BStepPoint[3] 
        -------- --- --------
        [b]-------- Below: Temp_Point must be destroyed before it can be set to a new point --------[/b]
        Set Temp_Point = (Center of Heroic Ground <gen>)
        Unit - Create 1 Dummy Unit (Sight Giver) for (Owner of [b](Triggering unit)[/b]) at Temp_Point facing Default building facing degrees
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        Unit - Turn collision for (Last created unit) Off
        Unit - Move (Last created unit) instantly to BStepPoint[2]
        Custom script:   call RemoveLocation(udg_Temp_Point)
        Custom script:   call RemoveLocation(udg_BStepPoint[2])
        Custom script:   call RemoveLocation(udg_BStepPoint[3])[b]
        Custom script:   call RemoveLocation(udg_BStepPoint[4])[/b]
        Wait 0.40 game-time seconds
        Unit - Unpause [b](Triggering unit)[/b]
        Unit - Unhide [b](Triggering unit)[/b]
        Unit - Make [b](Triggering unit)[/b] Vulnerable
        Selection - Add (Triggering unit) to selection for (Owner of (Triggering unit))

You missed a few places where you should have replaced Position of (UNIT) with a variable (In the beginning). All changes are bolded.

In this case, Triggering unit is better than BStepUnit, because it is MUI, whereas a global variable is not. (It may run a bit slower, but that shouldn't matter too much).

Leaks are gone now.

You could also try preloading the dummy units, and ability as well, to reduce first-cast lag (by preplacing them on the map, and removing them at map initialization). Take a look at my tutorial Reducing Lag (click on the Archive link in my signature and find "Reducing Lag" under tutorials).
 
SkyXyden

SkyXyden

New Member
Reaction score
3
Thanks for the help, although the fixes you did have some errors there, but it does point out my leaks. I already found out the real cause of the lag, after discovering some terrain deforms after using the spell, I found out that the base skill shockwave (non-hero, neutral ability) is having problems. I rechanged the base ability of both skills and now it doesn't lag anymore.

Rep up for the help anyway :D

Edit: Oh... erm... How do you up a rep here? I can't find the button =\
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Staff online

      Members online

      Online now:
      123 (members: 2, guests: 121)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top