Will adding events to a trigger the whole game cause a leak

[bugbear]

I'm working on a damage detection system and the first trigger to add a target to the damage detection trigger is:

Detect Unit 1
Events
Unit - A unit Is attacked
Conditions
Actions
Trigger - Add to Crit <gen> the event (Unit - (Triggering unit) Takes damage)



In theory this seems as if it would continue to add events every time a unit is attacked. Is this considered a leak or would it cause lag later on?

 

[darkbeer]

your trigger will be running multiple times, if you add the same event for the same unit multiple times.

meaning
the actions would appear multiple times on the same unit

to prevent it, add the unit to a group and check if its already in it when adding the event.

 

[bugbear]

So there's no need to remove a unit from the group at any point, or remove the unit form the event as long as I run a unit group check?

 

[AceHart]

No need to remove anything there...

 

[bugbear]

How would I put a condition in the other trigger to ensure that the damage caused was from a regular attack, not a skill.