Arguments --> local or not?

[wellwish3r]

I was just wondering when you pass arguments to a function are those arguments handled like locals, or do they get overwritten if the function is called again?
Does it depend if the variable that is used to pass the argument is a global or a local?
Do you have to Remove/Null/Destroy them if they are location,groups,....?

 

[Flare]

Arguments are local to the function, but handle-type arguments don't have to be nulled (I think)

Do you have to Remove/Null/Destroy them if they are location,groups,....?

Remove/Destroy? It depends - can you guarantee that the location won't be used elsewhere e.g.

function MyFunc takes location l returns nothing
...
call RemoveLocation (l)
endfunction

function Test takes nothing returns nothing
local location loc = ...
call MyFunc (loc)
... //are you 100% sure that loc will never be used again below the MyFunc call?
endfunction

I'm fairly sure that will destroy loc correctly if you called RemoveLocation within MyFunc

Just to make certain, you should destroy locals in the same function in which they were declared i.e.

function MyFunc takes location l returns nothing
...
endfunction

function Test takes nothing returns nothing
local location l = ...
call MyFunc (l)
call RemoveLocation (l)
set l = null
endfunction

It'd probably make leak-checking a whole lot easier (since the declaration and removal will be close to each other so you don't have to go back and forth between various functions)

 

[Viikuna]

Arguments are local to the function, but handle-type arguments don't have to be nulled (I think)

Yep, they are local and you dont have to null them.


For example:

function Test takes unit u returns nothing
    local real x=GetUnitX(u)
    local real y=GetUnitY(u)
    call KillUnit(u)
    set u=CreateUnit(Player(0),'dumy',x,y,0.0)
    call AddSpecialEffectTarget(SomeString,u,"chest")
endfunction

 

[kingkingyyk3]

Warcraft will automatically clean them.