How to store damage done?

[DsD)Core(]

Hey, I'm trying to make a ''damage meter'' for my map. What I got right now is:

Spoiler

Globalsys damage meter
    Events
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                ((Attacking unit) belongs to an ally of Player 1 (Red)) Equal to True
                ((Attacked unit) belongs to an ally of Player 1 (Red)) Equal to True
            Then - Actions
                Unit - Order (Attacking unit) to Stop
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        ((Attacking unit) belongs to an ally of Player 6 (Orange)) Equal to True
                        ((Attacked unit) belongs to an ally of Player 6 (Orange)) Equal to True
                    Then - Actions
                        Unit - Order (Attacking unit) to Stop
                    Else - Actions
                        Set DmgDealt_Total[(Player number of (Owner of (Damage source)))] = (DmgDealt_Total[(Player number of (Owner of (Damage source)))] + (Damage taken))
                        Set DmgDealt_Round[(Player number of (Owner of (Damage source)))] = (DmgDealt_Round[(Player number of (Owner of (Damage source)))] + (Damage taken))

And some commands that will call it. But they always say 0, so it seems like the damage is somehow not stored. Am I doing anything wrong?

Thanks!

 

[denmax]

Attacking unit only refers to the event "Is attacked"..

Triggering Unit refers to the unit taking the damage and Damage Source refers to the unit dealing the damage..

 

[DsD)Core(]

So what would you suggest? I'm making the order unit to stop attacking seperate trigger on unit is attacked, that's for sure. How about the plain damage gain?

 

[DsD)Core(]

I still didn't solve this ;( can anyone tell me?

 

[X-maul]

you need an event named

Unit - A Unit Is attacked

 

[Flare]

That event won't help. There's no Damage Taken with that event, since it fires long before you make contact (it fires around the start of the animation)

 

[Draphoelix]

Pick every unit in your map, later make an action like : Add the event (Picked Unit) takes damage to trigger Trigger

 

[denmax]

So what would you suggest? I'm making the order unit to stop attacking seperate trigger on unit is attacked, that's for sure. How about the plain damage gain?

Separate the Anti-Ally attack trigger and that trigger from the plain damage gain..

 

[warden13]

Please share your map with this triggers. I need it too, thanks.

 

[DsD)Core(]

denmax, I did that.
Now I have this:

Spoiler

Globalsys dmg catch
    Events
    Conditions
    Actions
        Set DmgDealt_Total[(Player number of (Owner of (Damage source)))] = (DmgDealt_Total[(Player number of (Owner of (Damage source)))] + (Damage taken))
        Set DmgDealt_Round[(Player number of (Owner of (Damage source)))] = (DmgDealt_Round[(Player number of (Owner of (Damage source)))] + (Damage taken))

And it's still not working for some reason.. This is my trigger to call the damage done:

Spoiler

Arenasys endsys
    Events
    Conditions
    Actions
        Game - Display to (All players) the text: |c00FCD116Damage do...
        Unit Group - Pick every unit in (Units in (Playable map area) matching (((Triggering unit) is A Hero) Equal to True)) and do (Actions)
            Loop - Actions
                Game - Display to (All players) the text: (Player_Colors[(Player number of (Picked player))] + ((Name of (Picked player)) + (|r:  + (String(DmgDealt_Round[(Player number of (Picked player))])))))

(this event is called by a different trigger upon the ending of the round, and it shows a whole list of 0.0 0.0 0.0 0.0 0.0)
What am I doing wrong? ;(

 

[Artificial]

Could you show the trigger that adds the events to the 'Globalsys dmg catch'? Or do you even have one?

 

[Tiber]

I'm fairly sure this can only be done in JASS.

 

[DsD)Core(]

I dont have any event that triggers this, just this event

 

[DsD)Core(]

Alright, actually I just found it somewhere. It's working now and for the other curious people, the combination of these 2 triggers make a succesfull damage done storage:

Detect unit

Spoiler

Globalsys unit catch
    Events
        Unit - A unit enters (Playable map area)
    Conditions
    Actions
        Trigger - Add to Globalsys dmg catch <gen> the event (Unit - (Triggering unit) Takes damage)

Catch damage

Spoiler

Globalsys dmg catch
    Events
    Conditions
    Actions
        Set DmgDealt_Total[(Player number of (Owner of (Damage source)))] = (DmgDealt_Total[(Player number of (Owner of (Damage source)))] + (Damage taken))
        Set DmgDealt_Round[(Player number of (Owner of (Damage source)))] = (DmgDealt_Round[(Player number of (Owner of (Damage source)))] + (Damage taken))

Thanks for the help, and gl to the others using it ;p

PS. I use a round and total variable for a total damage done and one that resets after every round. Just a total for example would be enough.

 

[Draphoelix]

Pick every unit in your map, later make an action like : Add the event (Picked Unit) takes damage to trigger Trigger

-.-''

 

[Flare]

You can look for Chocobo's tutorial on making your own damage detection, or just copy-paste the triggers from this. If you don't particularly need physical damage detection, just copy the two init triggers, and the all damage trigger (and delete any actions relating to the Damage Detection spellbook, and the Physical/Spell damage triggers)

@Tiber: It can be done without JASS, but it's not the most efficient way of doing it

 

[DsD)Core(]

Sorry, I actually didn't realize that. But I didn't understand what you said there until I saw the actual trigger posted somewhere. But you're right.

 

[DsD)Core(]

Yeah thanks, I actually got it from that guide
<3

EDIT: I just want to catch the damage into a variable to show it to players with a command, the overhead text would be a bit confusing for my arena map ;p