[Spell] Counter Strike

[Corleone]

custom script : local location CS_HeroPosition
custom script : CS_HeroPosition = null

is it correct?

I wouldn't use that one. There's no point in setting it to null. You might aswell use

call RemoveLocation ( udg_CS_HeroPosition )

 

[lh2705]

You would have to use both, Removing location first then nulling it.

 

[IKilledKEnny]

Nice, but I would have added those lines:

Unit - Make (Attacked unit) face (Attacking unit) over 0.15 seconds
Animation - Play (Attacked unit)'s attack animation

Makes it look better, like the unit is actually attacking instead of bouncing the arrows off.

 

[ayumilove]

thanks kenny and the rest! btw, if i used this animation, wouldn't the priestess of the moon will do the moon walk like michael jackson?

 

[Steel]

I wouldn't use that one. There's no point in setting it to null. You might aswell use

call RemoveLocation ( udg_CS_HeroPosition )

Aye, as LH said you need to nullify it. Anyone who's taken programming should know this. The variable might not be able to be reference but it is still allocated within the memory.

Nice spell.

 

[Chocobo]

Aye, as LH said you need to nullify it. Anyone who's taken programming should know this. The variable might not be able to be reference but it is still allocated within the memory.

Nice spell.

No. If you are saying that, then :

local integer i=null

should be legal, whereas it isn't.

It is safer to remove location + null, someone should test that which is the best.

 

[SFilip]

I'm sorry, but I can't approve this...
The spell is far too simple, it would rather belong in the Free Trigger Code for instance.
I do like how it looks while archers are attacking though. But it is kind of weird that the arrows are flying out of nowhere...

 

[IKilledKEnny]

I'm sorry, but I can't approve this...
The spell is far too simple, it would rather belong in the Free Trigger Code for instance.
I do like how it looks while archers are attacking though. But it is kind of weird that the arrows are flying out of nowhere...

That's why I suggested to add this:

Unit - Make (Attacked unit) face (Attacking unit) over 0.15 seconds
Animation - Play (Attacked unit)'s attack animation

, Believe me, the spell is much nicer.

SFilip, I don't need you need to disapprove a spell becuase it's too simple, I believe that the simpler (thus leaks the less and of course less work) is better, but it's up to you of course.

However, I would suggest making the spell much weaker, lol 1 hero kill about 15 archers while not doing anything.

Also I got another suggestion, try to make it so when you channel a spell this ability would be disabled.

Just my 2 cents!

 

[emjlr3]

i agree with Filip, nothing more to say