Does my code Leak?

N

newtonrox

Member
Reaction score
2
Ok, guys... So, i made this code to order all selected units to blink together, to the same spot, once any of them(selected units) blinks.
In a breath, if one blinks, everybody blinks.


JASS:
function Group_Blink_Stalker_Order takes nothing returns nothing

local unit U = GetEnumUnit()
local location L =  GetSpellTargetLoc()
local real X = GetLocationX(L) 
local real Y = GetLocationY(L) 


  if ( GetUnitTypeId(U) == 'n00U' ) then
 
   call IssuePointOrder( U, "blink", X,Y )


    set U = null
    call RemoveLocation(L)
    set L = null

    set udg_RecursiveUnit = GetEnumUnit()
    call DisableTrigger( GetTriggeringTrigger() )
  endif







endfunction


function Group_Blink_Stalker_Actions takes nothing returns nothing
local unit U = GetTriggerUnit()

    set udg_ALLMAP =  GetUnitsSelectedAll(GetOwningPlayer(U))


    call GroupRemoveUnit(udg_ALLMAP, U)
    if ( ( GetUnitTypeId(U) == 'n00U' ) and ( GetSpellAbilityId() == 'A004' ) ) then

         call ForGroupBJ( udg_ALLMAP, function Group_Blink_Stalker_Order)

    endif



    call DisplayTextToForce( GetPlayersAll(), "aaaaaaaaaa" )

    call DestroyGroup(udg_ALLMAP)

    set U = null

endfunction

//===========================================================================
function InitTrig_Group_Blink_Stalker takes nothing returns nothing
    set gg_trg_Group_Blink_Stalker = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Group_Blink_Stalker, EVENT_PLAYER_UNIT_SPELL_CAST)
    call TriggerAddAction( gg_trg_Group_Blink_Stalker, function Group_Blink_Stalker_Actions )
endfunction






this next trigger prevents recursive calls from " gg_trg_Group_Blink_Stalker" trigger:

JASS:
function Group_Blink_Stalker_On_Actions takes nothing returns nothing
local unit U = GetTriggerUnit()

    if ( ( U == udg_RecursiveUnit) and ( GetSpellAbilityId() == 'A004' ) ) then


    call EnableTrigger( gg_trg_Group_Blink_Stalker )
    set udg_RecursiveUnit = null

    endif

    set U = null


endfunction

//===========================================================================
function InitTrig_Group_Blink_Stalker_On takes nothing returns nothing
    set gg_trg_Group_Blink_Stalker_On = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Group_Blink_Stalker_On, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddAction( gg_trg_Group_Blink_Stalker_On, function Group_Blink_Stalker_On_Actions )
endfunction


Do I have a group leak or something else?
Will the second trigger respond in time for another player trying to blink?

thx for reply.
 
Narks

Narks

Vastly intelligent whale-like being from the stars
Reaction score
90
use the jass tags to make it more readable:

(JASS)(/JASS)
 
E

emjlr3

Change can be a good thing
Reaction score
395
you're first function leaks a unit and a location if the unitid isn't correct

you are not using any groups
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/
  • The Helper The Helper:
    New recipe is Cheeseburger Pie! https://www.thehelper.net/threads/recipe-cheeseburger-pie.194191/
  • The Helper The Helper:
    Latest recipe is Honey Chipolte Chicken Crispers https://www.thehelper.net/threads/recipe-honey-chipotle-chicken-crispers.194210/

      The Helper Discord

      Staff online

      Members online

      Online now:
      199 (members: 3, guests: 196)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top