Spell Fire Nova

[Lifee]

Hi everybody, well that is my first spell and i think it's very good and i decide to show you xD

Spell name : Fire Nova
Custom model used? : Yes
GUI ? : Yes
Screenshot ? : Yes

Spoiler

Trigger 1 :

• Fire Nova
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Fire Nova
  • Actions
    • Set Fire_Nova_Caster = (Triggering unit)

Trigger 2 :

• Fire Nova Loop
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Set Fire_Nova_Group = (Units in (Playable map area) matching (((Matching unit) has buff Fire Nova) Equal to True))
    • Unit Group - Pick every unit in Fire_Nova_Group and do (Actions)
      • Loop - Actions
        • Unit - Cause Fire_Nova_Caster to damage (Picked unit), dealing 50.00 damage of attack type Spells and damage type Normal
    • Custom script: call DestroyGroup (udg_Fire_Nova_Group)

A very simple spell

Please Comments xD


Credit For Custom model : JetFangInferno
Big thanks to HeX.16 for helping me to update my spell.


Edit 1 : Showing trigger

Edit 2 : Updated

 

[Komaqtion]

Please, post the code here so we don't need to open up the map to see if there are any leaks or if tweaks can be made

 

[Lifee]

You mean the trigger ?

 

[Komaqtion]

Yeah, do you know how to copy the code ? :S


EDIT: 4000th POST !!!!!!!!!!!!!!

 

[Lifee]

Ok done :thup:

 

[HeX.16]

Well lots of improvements can be made. Such as a loop rather than waits and also the groups leak.

 

[Chaos_Knight]

• Unit Group - Pick every unit in (Units within 700.00 of (Position of (Triggering unit)) matching (((Matching unit) belongs to an enemy of Player 1 (Red)) Equal to True)) and do (Unit - Cause (Triggering unit) to damage (Picked unit), dealing 50.00 damage of attack type Spells and damage type Universal)

USE VARIABLES. NOT MUI. :thdown:

 

[HeX.16]

• Unit Group - Pick every unit in (Units within 700.00 of (Position of (Triggering unit)) matching (((Matching unit) belongs to an enemy of Player 1 (Red)) Equal to True)) and do (Unit - Cause (Triggering unit) to damage (Picked unit), dealing 50.00 damage of attack type Spells and damage type Universal)

USE VARIABLES. NOT MUI. :thdown:

Its his first spell. He didnt say its MUI so rather than make useless comments suggest how to make a variable and how to code it better...

 

[Chaos_Knight]

SO you mean, i can come here with a spell that isnt MUI and coding sucks hard? :nuts:

 

[HeX.16]

For help why not? Im sure its not in the rules... Besides even my coding sucks some people just want to learn. Mocking someone doesnt help at all now does it. How many mistakes did you make in your Moving Strikes spell that people helped you with.

 

[Chaos_Knight]

A spell doesn't have to be MUI (Multi-Unit Instanceable), but make sure you clearly state if this is the case. For all those who don't know, MUI means that a spell can be safely casted by two units at the same time. This is usually impossible if you use global variables along with waits, timers, or periodic events as one variable will change its value when some other unit casts the spell.

See.. Doesnt have to be MUI, but it has to be told so.

Anyways, some constructive critics:

• Dont use waits.
• Create group variables instead and then use
  • call DestroyGroup(udg_YourGroup)
• Use loops

 

[Nherwyziant]

Is that leaky? And using waits. Enemy of player 1? This is going to graveyard

EDIT: Ah you changed your trigger. But still have leaks. And casting the spell will give your hero infinite killing area aura.

 

[Lifee]

I Updated !! Check it now

 

[Chaos_Knight]

Can just Player 1(Red) cast this spell

@HeX.16

You are true. My "vJASS" spell sux. But i dont leak in it( at to moment ).

 

[HeX.16]

Check the new code.

 

[Chaos_Knight]

Where does it add the buff?

 

[Lifee]

Where does it add the buff?

To the the enemys that are burning after the nova hit them !

 

[HeX.16]

Its based on thunder clap so its as the spell is cast. Its not MUI because the one unit will damage all of them and steal gold xD

 

[Chaos_Knight]

Where do you start the other Trigger?

 

[HeX.16]

Where do you start the other Trigger?

What "other trigger"?