Snippet GetRandomEven()

[dare2care]

>integer result
>should not compile.
>should be
>Jass:
>integer

Didn't understand

___

Updated so when 2 odd equal integers are given it returns as 0.

 

[SerraAvenger]

function ABC takes integer stuff returns [B]integer[/B]
  local integer a = stuff * 5
  return a
endfunction

function IsEven takes integer number returns boolean
    // when dividing by a real, it automatically converts the type
    return [B]( number / 2 ) *2 == number[/B]
endfunction

function GetRandomEven takes integer min, integer max returns [B]integer[/B]
    if min == max and[B] IsEven(min) [/B]then
    [B]    return min[/B]
    elseif max < min then
        return GetRandomInt( [B](max+1) / 2[/B], [B](min+1) / 2[/B] ) * 2       
    else
        return GetRandomInt( [B](min+1) / 2[/B], [B](max+1) / 2[/B] ) * 2
    endif
    [B]return 0[/B]
endfunction

I bolded everything I changed.

 

[dare2care]

function ABC takes integer stuff returns [B]integer[/B]
  local integer a = stuff * 5
  return a
endfunction

Fixed.

Does it compile for you?

EDIT: Updated..

 

[SerraAvenger]

My eyes say it does. Don't have Anything to check here though, so I can't tell.

EDIT: Plz also read my last post.

 

[dare2care]

My eyes say it does. Don't have Anything to check here though, so I can't tell.

EDIT: Plz also read my last post.

Already did and updated.

EDIT: If I put in 1,1 it outputs 2.

EDIT2: Fixed

function IsEven takes integer number returns boolean
    return ( number / 2 ) * 2 == number
endfunction

function GetRandomEven takes integer min, integer max returns integer
    if min == max and IsEven(min) then
        return min
    elseif max < min then
        return GetRandomInt((max + 1) / 2, (min + 1) / 2 ) * 2       
    elseif (min != max) then // this
        return GetRandomInt((min + 1) / 2, (max + 1) / 2 ) * 2
    endif
    return 0
endfunction

 

[SerraAvenger]

The line was correct, but the fix doesn't seem. shouldn't it be

    elseif (min < max) then // this line

instead?

EDIT: Missread. I read something overly complicated

 

[dare2care]

The line was correct, but the fix doesn't seem. shouldn't it be

    elseif (min < max) then // this line

instead?

No need? It functions properly as is.

 

[JerseyFoo]

Shows you how to get a random even integer.

function IsEven takes integer number returns boolean
    return ( number / 2 ) * 2 == number
endfunction

function GetRandomEven takes integer min, integer max returns integer
    if min == max and IsEven(min) then
        return min
    elseif max < min then
        return GetRandomInt((max + 1) / 2, (min + 1) / 2 ) * 2       
    elseif min != max then
        return GetRandomInt((min + 1) / 2, (max + 1) / 2 ) * 2
    endif
    return 0
endfunction

Examples

GetRandomEven(1, 1) //outputs 0
GetRandomEven(9, 10) // ouputs 10
GetRandomEven(6, 8) // outputs 6 or 8
GetRandomEven(8, 6) // ouputs 6 or 8

function GetRandomEven takes integer min, integer max returns integer
    set min = GetRandomInt( min, max )
    return ModuloInteger( min + ModuloInteger( min, 2 ), max + ModuloInteger( max, 2 ) )
endfunction

Let illegal operations be illegal?

 

[dare2care]

GetRandomEven(1, 3) // outputs 2 or 4 (wait wut?)

uhh I got a problem

 

[SerraAvenger]

(max+1) / 2) * 2

The bigger one needs to be rounded down.
Remove the second +1

 

[TheDamien]

Mother of all random range functions:

function GetRandomModRange takes integer lowBound, integer highBound, integer divisor, integer lowR, integer highR returns integer
    local integer d = highBound - lowBound
    
    if (d < highR - lowR) then
        set highR = lowR + d
        set lowR = lowBound - (lowBound / divisor) * divisor
        if (lowR < 0) then
            set lowR = lowR + divisor
        endif
    endif
    
    set lowR = GetRandomInt(lowR, highR)
    set lowBound = (lowBound + (divisor-1)) - lowR
    set highBound = highBound - lowR
    
    set d = lowBound / divisor
    if (d < 0 and d * divisor != lowBound) then
        set lowBound = d - 1
    else
        set lowBound = d
    endif
    
    set d = highBound / divisor
    if (d < 0 and d * divisor != highBound) then
        set highBound = d - 1
    else
        set highBound = d
    endif

    return GetRandomInt(lowBound, highBound) * divisor + lowR
endfunction

function GetRandomEven takes integer lowBound, integer highBound returns integer
    return GetRandomModRange(lowBound, highBound, 2, 0, 0)
endfunction

function GetRandomOdd takes integer lowBound, integer highBound returns integer
    return GetRandomModRange(lowBound, highBound, 2, 1, 1)
endfunction