GroupPointOrder Help

[svenski]

Is there a better way of doing this, and does this leak at all? I'm new to Jass editing, but the trigger seems to be working fine.

function Trig_Pathing1_Actions takes nothing returns nothing
    local group pathers = GetUnitsInRectOfPlayer(gg_rct_Somewhere, Player(11))
    call GroupPointOrder( pathers, "attack", 500, 500 )
    set pathers = null
endfunction

Would it be more appropriate to call DestroyGroup(pathers) rather than setting the variable to null, or is that essentially doing the same thing?


Thanks for any help

 

[Azlier]

In order for a handle to be recycled, it must be destroyed and nulled. Even if you destroy and null groups, however, if you actually use the group and run it through a filter, it leaks some. If you don't supply a filter, it leaks a boolexpr. The only answers are a global group or a group stack like GroupUtils.

 

[RaiJin]

it must be destroyed and nulled

and btw im pretty sure you need to create a group

local group VARNAME = CreateGroup()

 

[Azlier]

No, he's using a BJ that automagically creates and fills the group.

 

[RaiJin]

ah BJ's Ftl

 

[svenski]

how bout something more like this:

function Trig_Pathing1_Actions takes nothing returns nothing
    set udg_tempgroup1 = GetUnitsInRectOfPlayer(gg_rct_bad_guys_spawn, Player(11))
    call GroupPointOrder( udg_tempgroup1, "attack", -2442, 239 )
    call DestroyGroup(udg_tempgroup1)

where obviously tempgroup1 is a [EDIT]global variable

 

[RaiJin]

if it is a LOCAL variable then why are u using udg_ ?? it looks so ugly.. if its a global then yes thats how u clear the leak

 

[Azlier]

I see no local in what svenski provided. It still leaks minorly, though. Dynamically created groups and timers are to be feared.

 

[svenski]

lol oops see edit^^^^^

And thx

 

[Darthfett]

In order for a handle to be recycled, it must be destroyed and nulled. Even if you destroy and null groups, however, if you actually use the group and run it through a filter, it leaks some. If you don't supply a filter, it leaks a boolexpr. The only answers are a global group or a group stack like GroupUtils.

This is the correct answer. Destroy and then null your group.

It is also worth noting that GetUnitsInRectOfPlayer leaks as well, as it does not null the group it returns:

function GetUnitsInRectOfPlayer takes rect r, player whichPlayer returns group
    local group g = CreateGroup()
    set bj_groupEnumOwningPlayer = whichPlayer
    call GroupEnumUnitsInRect(g, r, filterGetUnitsInRectOfPlayer)
    return g
endfunction

Therefore, you are best off doing these actions on your own:

function Trig_Pathing1_Actions takes nothing returns nothing
    local group pathers = CreateGroup()
    set bj_groupEnumOwningPlayer = Player(11)
    call GroupEnumUnitsInRect(pathers,gg_rct_Somewhere, filterGetUnitsInRectOfPlayer)
    call GroupPointOrder( pathers, "attack", 500, 500 )
    call DestroyGroup(pathers)
    set pathers = null
endfunction

It's always good to look at a bj function to see what it's doing. If it's not useful or it leaks, in-line the actions into your function instead of wasting the function call.

 

[emjlr3]

if you are doing this often just use a global group so there is not need to keep creating/destroying one