Having duplicates of items in the same inventory help

D

DarkKnightML

New Member
Reaction score
1
So apparently making it so you can't pick up two of the same items out of a group of specific items is a lot harder than I'd thought? Or at least I've been going about it the wrong way for the past few hours. I recently made a system so that you could have only one of four items at one time in your inventory for my hero, and you would purchase this item from the shop, however while I was testing with a friend he simply put down one of the items, bought a different one(and it could have even been the same one..) and then simply picked up the old one, thus giving him two of those items, and this could work for multiple instances as well, he could potentially fill his inventory with the item with this bug. So would anyone know how to fix this? I've tried multiple ways but I just wound up deleting the triggers I had out of frustration, however I can post what I have for the buy trigger.

Code: 
Cloak of Archimonde
    Events
        Unit - A unit Acquires an item
    Conditions
        (Item-type of (Item being manipulated)) Equal to Tome of Archimonde
    Actions
        Set ShepNumber = (Player number of (Owner of (Hero manipulating item)))
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Or - Any (Conditions) are true
                    Conditions
                        ((Triggering unit) has an item of type Cloak of Ner'zhul) Equal to True
                        ((Triggering unit) has an item of type Cloak of Archimonde) Equal to True
                        ((Triggering unit) has an item of type Cloak of Sargeras) Equal to True
                        ((Triggering unit) has an item of type Cloak of Kil'jaeden) Equal to True
            Then - Actions
                Set PlayerGroupArray[27] = (Player group((Owner of (Hero manipulating item))))
                Game - Display to (Player group((Random player from PlayerGroupArray[27]))) for 10.00 seconds the text: Only one cloak per ...
                Item - Remove (Item being manipulated)
                Player - Add 100 to (Owner of (Hero manipulating item)) Current gold
            Else - Actions
                Set CloakAmountShep[ShepNumber] = (CloakAmountShep[ShepNumber] + 1)
                Hero - Create Cloak of Archimonde and give it to (Hero manipulating item)

And you can see that I have some of how I tried to fix the issue still in here.
 
F

futeki

Active Member
Reaction score
4
Just a little advice for future postings, try not to post such a huge blob of text. First things first, why are you removing the item?

Why not just make them drop it like so?:
Trigger:
  • Actions
    • Hero - Drop (Item carried by (Triggering unit) of type Tome of Archimonde) from (Triggering unit)


And although I may be misunderstanding you, I think what you're looking for is rather simple:
Trigger:
  • Only One Item
    • Events
      • Unit - A unit Acquires an item
    • Conditions
      • (Item-type of (Item being manipulated)) Equal to Tome of Archimonde
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • ((Triggering unit) has an item of type Tome of Archimonde) Equal to True
        • Then - Actions
          • Game - Display to (Owner of(Triggering unit)) the text: You can only carry one of those!
          • Hero - Drop (Item carried by (Triggering unit) of type Tome of Experience) from (Triggering unit)
        • Else - Actions
 
inevit4ble

inevit4ble

Well-Known Member
Reaction score
38
You can do this even easier.
Just use classes.


Code: 
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    If - Conditions
        (Item-class of (Item being manipulated)) Equal to Purchasable<---//You make all cloaks purchasables, shields artifacts
    Then - Actions
        For each (Integer A) from 1 to 6, do (Actions)<------------------//6 Slots in inventory
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Item-class of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to (Item-class of (Item being manipulated))
                        (Item carried by (Hero manipulating item) in slot (Integer A)) Not equal to (Item being manipulated)
                    Then - Actions
                        Hero - Drop the item from slot (Integer A) of (Hero manipulating item)
                        Quest - Display to (Player group((Owner of (Hero manipulating item)))) the Warning message: Weapon Switched!  O...
                    Else - Actions
    Else - Actions
 
D

DarkKnightML

New Member
Reaction score
1
Well with a little bit of my own intuition I've made this work...and dear god. Well here's my final product if anyone needs any help on this issue as well.

<A BUY TRIGGER>
Code: 
Cloak of Archimonde
    Events
        Unit - A unit Acquires an item
    Conditions
        (Item-type of (Item being manipulated)) Equal to Tome of Archimonde
    Actions
        Set ShepNumber = (Player number of (Owner of (Hero manipulating item)))
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                Or - Any (Conditions) are true
                    Conditions
                        ((Triggering unit) has an item of type Cloak of Ner'zhul) Equal to True
                        ((Triggering unit) has an item of type Cloak of Archimonde) Equal to True
                        ((Triggering unit) has an item of type Cloak of Sargeras) Equal to True
                        ((Triggering unit) has an item of type Cloak of Kil'jaeden) Equal to True
            Then - Actions
                Set PlayerGroupArray[27] = (Player group((Owner of (Hero manipulating item))))
                Game - Display to (Player group((Random player from PlayerGroupArray[27]))) for 10.00 seconds the text: Only one cloak per ...
                Item - Remove (Item being manipulated)
                Player - Add 100 to (Owner of (Hero manipulating item)) Current gold
            Else - Actions
                Hero - Create Cloak of Archimonde and give it to (Hero manipulating item)
                Set CloakAmountShep[ShepNumber] = 2
                Game - Display to (All players) for 5.00 seconds the text: (String(CloakAmountShep[ShepNumber]))

<Upon picking a cloak up>
Code: 
One Cloak P2
    Events
        Unit - A unit Loses an item
    Conditions
        Or - Any (Conditions) are true
            Conditions
                (Item-type of (Item being manipulated)) Equal to Cloak of Kil'jaeden
                (Item-type of (Item being manipulated)) Equal to Cloak of Sargeras
                (Item-type of (Item being manipulated)) Equal to Cloak of Ner'zhul
                (Item-type of (Item being manipulated)) Equal to Cloak of Archimonde
    Actions
        Set CloakAmountShep[ShepNumber] = 1
        Game - Display to (All players) for 5.00 seconds the text: (String(CloakAmountShep[ShepNumber]))

<Upon dropping a cloak>
Code: 
One Cloak P2
    Events
        Unit - A unit Loses an item
    Conditions
        Or - Any (Conditions) are true
            Conditions
                (Item-type of (Item being manipulated)) Equal to Cloak of Kil'jaeden
                (Item-type of (Item being manipulated)) Equal to Cloak of Sargeras
                (Item-type of (Item being manipulated)) Equal to Cloak of Ner'zhul
                (Item-type of (Item being manipulated)) Equal to Cloak of Archimonde
    Actions
        Set CloakAmountShep[ShepNumber] = 1
        Game - Display to (All players) for 5.00 seconds the text: (String(CloakAmountShep[ShepNumber]))

<The Enforcement Rule Trigger>
Code: 
One Cloak
    Events
        Unit - A unit Acquires an item
    Conditions
        CloakAmountShep[ShepNumber] Greater than or equal to 2
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Item-class of (Item being manipulated)) Equal to Purchasable
            Then - Actions
                For each (Integer A) from 1 to 6, do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Item-class of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to (Item-class of (Item being manipulated))
                                (Item carried by (Hero manipulating item) in slot (Integer A)) Not equal to (Item being manipulated)
                            Then - Actions
                                Hero - Drop the item from slot (Integer A) of (Hero manipulating item)
                            Else - Actions
            Else - Actions

Anyways +rep and thanks man, I was getting pretty frustrated at this one..as I don't have a ton of experience with items.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1

      The Helper Discord

      Members online

      No members online now.
      Online now:
      81 (members: 0, guests: 81)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top