Help with memory leak

Feralex

Active Member
Reaction score
4
This trigger works as intended but when a unit owned by player 5 is ordered an order many many time over it causes the game to lag after a while but i cant see why. The Point variable is destroyed and as far as i can see its the only thing that possibly can cause a memory leak. "CenterofMap" is a point variable created at the initialization of the map.

Code:
YellowRing
    Events
        Advanced - Any Unit is Issued Any Order
    Conditions
        (Owner of (Ordered unit)) Equal to Player 5 (Yellow)
    Actions
        Wait 0.01 seconds
        Set Yellowunitpoint = (CenterofMap offset by (YellowRX[(Custom value of (Ordered unit))], YellowRY[(Custom value of (Ordered unit))]))
        Unit - Move (Ordered unit) instantly to Yellowunitpoint, facing YellowRangle[(Custom value of (Ordered unit))] degrees
        Point - Remove Yellowunitpoint

I dont know if this is necasary to show but its connected to the previous trigger. Its basically a slightly remade respawning-trigger to save the position and facing of all units owned by player 5.

Code:
YellowR
    Events
        Map initialization
    Conditions
    Actions
        Set YellowRgroup = (Units owned by Player 5 (Yellow))
        Unit Group - Pick every unit in YellowRgroup and do (Actions)
            Loop - Actions
                Set YellowRint = (YellowRint + 1)
                Unit - Set the custom value of (Picked unit) to YellowRint
                Custom script: set udg_YellowRX[udg_YellowRint] = GetUnitX(GetEnumUnit())
                Custom script: set udg_YellowRY[udg_YellowRint] = GetUnitY(GetEnumUnit())
                Set YellowRangle[YellowRint] = (Facing of (Picked unit))
        Unit Group - Destroy unit group YellowRgroup
 

the_ideal

user title
Reaction score
61
Try replacing ordered unit with triggering unit. This may not be the problem, but ordered unit can get lost in a trigger. Whenever possible, use triggering. Other than that, I can't see what's going wrong. (I'm not much of an expert on leaks, though)
 

Feralex

Active Member
Reaction score
4
thanks for the tip but as you said it didnt help the leak.
Still need help!
 

vypur85

Hibernate
Reaction score
803
Code:
YellowRing
    Events
        Advanced - Any Unit is Issued Any Order
    Conditions
        (Owner of (Ordered unit)) Equal to Player 5 (Yellow)
    Actions
        Trigger - Turn off (This trigger)
        Set Yellowunitpoint = (CenterofMap offset by (YellowRX[(Custom value of (Ordered unit))], YellowRY[(Custom value of (Ordered unit))]))
        Unit - Move (Ordered unit) instantly to Yellowunitpoint, facing YellowRangle[(Custom value of (Ordered unit))] degrees
        Point - Remove Yellowunitpoint
        Trigger - Turn on (This trigger)

Remove the wait. Then turn the trigger on and off. It lagged because everytime you move a unit to a position, the unit will be autamatically ordered to 'stop' which in this case, fires the event again. (If you didn't add the wait, I think it would cause error. But since you added the wait, it only caused extreme lag).
 

Feralex

Active Member
Reaction score
4
Ive tried that now in every possible combination but it either doesnt do anything at all or it causes the game to crash. Like you said, when i remove the wait it causes the game to instantly crash because it loops infinatly.
So the problem still remains
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +1
  • V-SNES V-SNES:
    Happy Friday!
    +1

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top