Hero select, leak

[slayer]

Hello!
I am currently trying to get rid of and remove leaks from my map. This trigger does not work after removing the leak from it, why?

Improved one:

Alchemist
Events
Unit - A unit enters HEROAlchemist <gen>
Conditions
(Unit-type of (Triggering unit)) Equal to Hero Select
Actions
Set L = (Center of HeroStartPoint <gen>)
Unit - Create 1 Alchemist for (Triggering player) at L facing Default building facing degrees
Unit - Remove (Triggering unit) from the game
Custom script: call RemoveLocation(udg_L)

Although, when I last checked with leak checker, it still says "Location variable has not been removed" What seems to be the problem there? (btw, thanks for leak checker Im_On_56k :thup: )

Original one with leak that does work:

Alchemist
Events
Unit - A unit enters HEROAlchemist <gen>
Conditions
(Unit-type of (Triggering unit)) Equal to Hero Select
Actions
Unit - Create 1 Alchemist for (Triggering player) at L facing Default building facing degrees
Unit - Remove (Triggering unit) from the game

 

[s3rius]

I guess leak checker tells you that the leak is still there because you haven't nulled L. But that isn't necessary because it'll override itself on the next use.

No idea why the trigger doesn't work. I've made a swift test myself and it worked fine. Does the whole trigger not execute? Or is it only a part (e.g. the Triggering Unit doesn't get removed, but the hero spawns)?

 

[131ackout]

Well, I copied this from a tutorial.

Choose Hero 1
    Events
        Unit - A unit enters Hero 1 Region 
    Conditions
        ((Unit-type of (Triggering unit)) Equal to Wisp) and (Pick_Taken[1] Equal to 0)
    Actions
        Set Pick_Taken[1] = 1
        Unit - Hide Demon Hunter 0001
        Unit - Create 1 Demon Hunter for (Owner of (Triggering unit)) at (Center of Start Region ) facing Default building facing degrees
        Camera - Pan camera for (Owner of (Triggering unit)) to (Center of Start Region ) over 0.00 seconds
        Unit - Remove (Triggering unit) from the game

Choose Hero 2
    Events
        Unit - A unit enters Hero 2 Region 
    Conditions
        ((Unit-type of (Triggering unit)) Equal to Wisp) and (Pick_Taken[2] Equal to 0)
    Actions
        Set Pick_Taken[2] = 1
        Unit - Hide Sorceress 0002
        Unit - Create 1 Sorceress for (Owner of (Triggering unit)) at (Center of Start Region ) facing Default building facing degrees
        Camera - Pan camera for (Owner of (Triggering unit)) to (Center of Start Region ) over 0.00 seconds
        Unit - Remove (Triggering unit) from the game

The variable Pick_Taken and "Hide" are what you don't need..

 

[slayer]

I guess leak checker tells you that the leak is still there because you haven't nulled L. But that isn't necessary because it'll override itself on the next use.

No idea why the trigger doesn't work. I've made a swift test myself and it worked fine. Does the whole trigger not execute? Or is it only a part (e.g. the Triggering Unit doesn't get removed, but the hero spawns)?

Yeah thats funny actually, the 'hero select' unit is removed, but no hero appear.

 

[AdamGriffith]

There is no Triggering player.

You should use owner of triggering unit.

 

[131ackout]

> AdamGriffith'

Again.. Luckily, there is "Triggering Player"....

It's based on the conditions or events, w/e.

Look for it.

 

[slayer]

There is no Triggering player.

Alchemist
Events
Unit - A unit enters HEROAlchemist <gen>
Conditions
(Unit-type of (Triggering unit)) Equal to Hero Select
Actions
Unit - Create 1 Alchemist for (Triggering player) at L facing Default building facing degrees
Unit - Remove (Triggering unit) from the game

this one does work, although it is leaking, isnt that weird?

 

[AdamGriffith]

Change it to owned of triggering unit.
And then test it.

 

[s3rius]

Got it.

Unit - Create 1 Alchemist for (Triggering player) at L facing Default building facing degrees

is wrong. It must be

Unit - Create 1 Alchemist for Owner of (Triggering player) at L facing Default building facing degrees

Damn, second D:

 

[slayer]

Well, I copied this from a tutorial.

Choose Hero 1
    Events
        Unit - A unit enters Hero 1 Region 
    Conditions
        ((Unit-type of (Triggering unit)) Equal to Wisp) and (Pick_Taken[1] Equal to 0)
    Actions
        Set Pick_Taken[1] = 1
        Unit - Hide Demon Hunter 0001
        Unit - Create 1 Demon Hunter for (Owner of (Triggering unit)) at (Center of Start Region ) facing Default building facing degrees
        Camera - Pan camera for (Owner of (Triggering unit)) to (Center of Start Region ) over 0.00 seconds
        Unit - Remove (Triggering unit) from the game

Choose Hero 2
    Events
        Unit - A unit enters Hero 2 Region 
    Conditions
        ((Unit-type of (Triggering unit)) Equal to Wisp) and (Pick_Taken[2] Equal to 0)
    Actions
        Set Pick_Taken[2] = 1
        Unit - Hide Sorceress 0002
        Unit - Create 1 Sorceress for (Owner of (Triggering unit)) at (Center of Start Region ) facing Default building facing degrees
        Camera - Pan camera for (Owner of (Triggering unit)) to (Center of Start Region ) over 0.00 seconds
        Unit - Remove (Triggering unit) from the game

The variable Pick_Taken and "Hide" are what you don't need..

thanks, but if I remove Pick_Taken and "Hide", isn't it the same script then?

 

[AdamGriffith]

@ s3rius
Congratulations.
You can copy what I said.

Just change it to owner of triggering unit please.

Also, what is L in this trigger?

Original one with leak that does work:

Alchemist
Events
Unit - A unit enters HEROAlchemist <gen>
Conditions
(Unit-type of (Triggering unit)) Equal to Hero Select
Actions
Unit - Create 1 Alchemist for (Triggering player) at L facing Default building facing degrees
Unit - Remove (Triggering unit) from the game

 

[131ackout]

Don't worry, the "Pick_Taken" is just a variable you don't know, so just create like this:

Choose Hero 1
    Events
        Unit - A unit enters Hero 1 Region 
    Conditions
        ((Unit-type of (Triggering unit)) Equal to Wisp) and (Pick_Taken[1] Equal to 0)
    Actions
        Unit - Create 1 Demon Hunter for (Owner of (Triggering unit)) at (Center of Start Region ) facing Default building facing degrees
        Camera - Pan camera for (Owner of (Triggering unit)) to (Center of Start Region ) over 0.00 seconds
        Unit - Remove (Triggering unit) from the game

The person who made this wanted to have their OWNED hero arena to be hided and working on the Pick_Taken variable.

 

[slayer]

Got it.

Unit - Create 1 Alchemist for (Triggering player) at L facing Default building facing degrees

is wrong. It must be

Unit - Create 1 Alchemist for Owner of (Triggering player) at L facing Default building facing degrees

Damn, second D:

thanks man! +rep

 

[AdamGriffith]

lol.
So you listen when he says it.
But not when I say it?

Last time I help you.

 

[131ackout]

I helped him, too..

Lol, let's not do the offtopic.

 

[slayer]

lol.
So you listen when he says it.
But not when I say it?

Last time I help you.

haha sorry dude, didn't see you was first when I was updating, of course you will have +rep as well fro helping me out

 

[slayer]

lol.
So you listen when he says it.
But not when I say it?

Last time I help you.

srry dude, I did not see when I was updating, but of course you will have +rep for helping me out as well

 

[AdamGriffith]

Quote:
Originally Posted by AdamGriffith View Post
There is no Triggering player.
Alchemist
Events
Unit - A unit enters HEROAlchemist <gen>
Conditions
(Unit-type of (Triggering unit)) Equal to Hero Select
Actions
Unit - Create 1 Alchemist for (Triggering player) at L facing Default building facing degrees
Unit - Remove (Triggering unit) from the game

this one does work, although it is leaking, isnt that weird?
Reply With Quote

But you didn't read it so how did you post that reply?
I wonder?
Sorry,
Cyar

 

[131ackout]

> AdamGriffth
What do you mean, and who's Cyar?

Slayer I helped.. too.

 

[Exide]

But you didn't read it so how did you post that reply?
I wonder?
Sorry,
Cyar

I dunno who wrote that trigger originally, but there is no (Triggering Player) in that trigger.
(Post number 18)