is there any way to make this trigger a little simpler? :)

soulmaka

New Member
Reaction score
2
okay, i have been making a quest trigger for an hour now, but it seems that making a quest trigger for me is quite hard,.. xD I've been making Spell triggers and Hero taverns, dialogues, etc..

haha, i hate making quest triggers, because ...

1. I always click, (player number(owner of(triggering/buying/attacking unit))), is there anyway to make this simple? man I'm TIRED of clicking.. xD

2. Can I use loops for the no.1? xD

3. Here's my code.. :D yeah, there might be leaks right now, but the hell I care for that now, i can fix that later, i just want how to make things on making quest trigger simpler.. :D

code for quest finish/claiming rewards .. :D
Trigger:
  • Quests Market
    • Events
      • Unit - A unit comes within 200.00 of |cff00ffffQuest Market|r 0026 <gen>
      • Unit - A unit comes within 200.00 of |cff00ffffQuest Market|r 0027 <gen>
    • Conditions
      • (Triggering unit) Equal to QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Triggering unit) Equal to QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]
          • QuestsCreepsKill[(Player number of (Owner of (Buying unit)))] Equal to 30
          • (QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))] has QuestKillCreeps_Item[(Player number of (Owner of (Buying unit)))]) Equal to True
        • Then - Actions
          • Set QuestsCreepsKill[(Player number of (Owner of (Buying unit)))] = 0
          • Item - Remove QuestKillCreeps_Item[(Player number of (Owner of (Buying unit)))]
          • Player - Add 2500 to (Owner of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]) Current gold
          • Hero - Add 1000 experience to QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))], Show level-up graphics
          • Game - Display to (Player group((Owner of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]))) for 10.00 seconds the text: Thanks you for help...
        • Else - Actions
          • Game - Display to (Player group((Owner of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]))) for 10.00 seconds the text: Go !! Fullfil your ...



Code for Quest inquiry :D
Trigger:
  • Quest Kill Creeps
    • Events
      • Unit - A unit Sells an item (from shop)
    • Conditions
      • (Item-type of (Sold Item)) Equal to Quest: Kill Creeps
    • Actions
      • Set QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))] = (Buying unit)
      • Set QuestKillCreeps_Item[(Player number of (Owner of (Buying unit)))] = (Sold Item)
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Level of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]) Less than or equal to 30
        • Then - Actions
          • Set QuestsCreepsKill[(Player number of (Owner of (Buying unit)))] = 0
        • Else - Actions
          • Item - Remove QuestKillCreeps_Item[(Player number of (Owner of (Buying unit)))]
          • Player - Add 500 to (Owner of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]) Current gold
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Level of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]) Greater than 30
        • Then - Actions
        • Else - Actions


Code for Quest in action.. :)
Trigger:
  • Quest Kill Creeps p2
    • Events
      • Unit - A unit Dies
    • Conditions
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Owner of (Triggering unit)) Equal to Neutral Hostile
          • ((Triggering unit) is A Hero) Equal to False
          • (Killing unit) Equal to QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]
          • QuestsCreepsKill[(Player number of (Owner of (Buying unit)))] Less than 30
          • (QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))] has QuestKillCreeps_Item[(Player number of (Owner of (Buying unit)))]) Equal to True
        • Then - Actions
          • Set QuestsCreepsKill[(Player number of (Owner of (Buying unit)))] = (QuestsCreepsKill[(Player number of (Owner of (Buying unit)))] + 1)
          • Game - Display to (Player group((Owner of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]))) the text: ((Name of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]) + ( has killed + ((String(QuestsCreepsKill[(Player number of (Owner of (Buying unit)))])) + Creeps!)))
        • Else - Actions
          • Game - Display to (Player group((Owner of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]))) the text: You already have co...
 

esb

Because none of us are as cruel as all of us.
Reaction score
329
Right off the bat, for the first trigger, Quests Market, the event is Unit enters region. Yet your Condition and Actions say "Buying unit". Fix it. (Triggering unit should work fine).

You don't have to use variables for every action. For example:
Player - Add 2500 to (Owner of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]) Current gold
Can be
Player - Add 2500 to (Owner of (Buying unit)) Current gold
 

Romek

Super Moderator
Reaction score
964
> I always click, (player number(owner of(triggering/buying/attacking unit))), is there anyway to make this simple? man I'm TIRED of clicking.. xD
That's just what GUI is, really. If you want to code faster, learn JASS. :p

> Can I use loops for the no.1? xD
You'll realise you can use loops when you find you're repeating the same code with only a minor difference such as a player number.
 

soulmaka

New Member
Reaction score
2
Right off the bat, for the first trigger, Quests Market, the event is Unit enters region. Yet your Condition and Actions say "Buying unit". Fix it. (Triggering unit should work fine).

You don't have to use variables for every action. For example:
Player - Add 2500 to (Owner of QuestCreepsKill_TU[(Player number of (Owner of (Buying unit)))]) Current gold
Can be
Player - Add 2500 to (Owner of (Buying unit)) Current gold

thanks!! xD that makes it easier for me right? :D

> I always click, (player number(owner of(triggering/buying/attacking unit))), is there anyway to make this simple? man I'm TIRED of clicking.. xD
That's just what GUI is, really. If you want to code faster, learn JASS. :p

> Can I use loops for the no.1? xD
You'll realise you can use loops when you find you're repeating the same code with only a minor difference such as a player number.

Is it really easy to learn JASS? i mean, Computer Science is my course in college now.. xD is there a big difference between the two? the C programming and JASS? xD
 

SouLEDGE

Damn you advanced calculus
Reaction score
75
Jass isn't that difficult to learn, I read up and practice when I have free time (which is hardly ever - damn projects)
and I can get some pretty basic things done that took long to click for in GUI
The concept of Jass will be easier to learn if you're doing programming, but it is a lil different.
 

tommerbob

Minecraft. :D
Reaction score
110
Is it really easy to learn JASS? i mean, Computer Science is my course in college now.. xD is there a big difference between the two? the C programming and JASS? xD

As a recent GUI > Jass switcher who has no programming experience, I attest that learning Jass is not overly difficult, it just takes some patience and practice. Once you get it, GUI starts looking like poop. (sorry for the tasteful analogy :D.) If you already have some programming experience, it will be that much easier for you to learn.
 

soulmaka

New Member
Reaction score
2
haha.. which means, i must start learning JASS? xD but i dunno how to have a JASS on my trigger, i know about the conversion, but i think it's kinda boring? because you Write JASS code in just white background? O_O and black color fonts.. >_<
 

Ayanami

칼리
Reaction score
288
haha.. which means, i must start learning JASS? xD but i dunno how to have a JASS on my trigger, i know about the conversion, but i think it's kinda boring? because you Write JASS code in just white background? O_O and black color fonts.. >_<

If you have NewGen, it won't be just black and white. You have blue for keywords, purple for natives, etc.

In my honest opinion, you should learn vJASS. I used to be a GUI user (for more than 2 years). GUI itself is inefficient and there are some things in which only JASS can achieve. Learning JASS wasn't easy in my opinion. Had no knowledge of programming what-so-ever. But I still picked up JASS after a few weeks.

Plus, thanks to JASS, learning Java in classes is simple as ABC :D
 

tommerbob

Minecraft. :D
Reaction score
110
haha.. which means, i must start learning JASS? xD but i dunno how to have a JASS on my trigger, i know about the conversion, but i think it's kinda boring? because you Write JASS code in just white background? O_O and black color fonts.. >_<

Like Ayanami said, NewGen WE is awesome for Jass coding, because it is (1) color-coded for the different functions, plus it includes all the functions, so you don't have to memorize everything.
 

soulmaka

New Member
Reaction score
2
Like Ayanami said, NewGen WE is awesome for Jass coding, because it is (1) color-coded for the different functions, plus it includes all the functions, so you don't have to memorize everything.

how will I know that my WE is NewGen? cause there's this guy said that i can only edit Maximum mana cost if i have NewGen.. but it seems that I can even exceed 99999 Mana Cost.. :D
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +1
  • V-SNES V-SNES:
    Happy Friday!
    +1

      The Helper Discord

      Staff online

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top