JASS problem ..

[iNsaNe]

im making a function that returns a certain number of randomly picked units in a unit group. The problem is, when I call the function nothing happens.

here's my jass (im new to jass by the way)

function FirePitChoose takes integer NumberOfPits returns group

     local unit RUnit
     local group Pits = GetUnitsOfTypeIdAll ( 'n001' )
     local group ReturnPits

     local integer Index = 1

     loop

         exitwhen Index > NumberOfPits
         set RUnit = GroupPickRandomUnit ( Pits )
         call GroupAddUnitSimple ( RUnit, ReturnPits )
         call GroupRemoveUnitSimple ( RUnit , Pits )
         set RUnit = null
         set Index = Index + 1

     endloop

     call DestroyGroup ( Pits )
     return ReturnPits

endfunction

and this is how i attempt to use it (so i get 10 units back in the unit group):

set udg_HeatPits = FirePitChoose ( 10 )

and of course udg_HeatPits is a unit group variable

edit:

when i say nothing happens i mean, the code doesn't execute for the function FirePitChoose. The map doesn't freeze, but it's like the code does.

 

[phyrex1an]

local group ReturnPits = CreateGroup()

But you might as well use GetRandomSubGroup.

 

[SerraAvenger]

and btw you might want to replace the redundant bj calls:

call GroupAddUnitSimple ( RUnit, ReturnPits )
call GroupRemoveUnitSimple ( RUnit , Pits )

should be

call GroupAddUnit( ReturnPits, RUnit )
call GroupRemoveUnit( Pits, RUnit)

Thats two calls less * the number of units you wanna have.


greets davey

 

[substance]

btw, iNsaNe, use JASS tags instead of code tags.