Leaks

[kallieblakie]

anyone know what are ALL the things that you would have to remove? My map is causing some leaks and I don't know what else to remove other than unitgroups and locations.


HELP !


EDIT:


Figured it out eventually. Used too much locations, causing lag.

SOLVED!

 

[ReVolver]

Read this:

http://www.thehelper.net/forums/showthread.php?t=27219

 

[kallieblakie]

Special Effects
Groups
Points
Units
Regions
Forces
Lightning Effects
Floating Text
Countdown Timers

that's all? but i removed them, and it still lags ! how !

 

[ReVolver]

Make sure your don't have a lot of units created and make sure you don't have a trigger running every 0.01-2 seconds of the game.

 

[Trollvottel]

and make sure you dont usw too much eyecandy

 

[~GaLs~]

>>that's all? but i removed them, and it still lags ! how !
You are using Jass, aren't you?
Forgoten to null handles?

 

[Builder Bob]

Special Effects
Groups
Points
Units
Regions
Forces
Lightning Effects
Floating Text
Countdown Timers

When on the topic of all things that can leak... I've wondered a long time about this. Does BoolExpr leak if not destroyed, or do they not create a new handle? Like when used in GroupEnumUnitsOfWhatever() functions.

 

[Uberplayer]

You probably don't want to destroy a boolexpr. If you do so, then the condition is gone.

 

[Builder Bob]

Edit2 after some tests:
GroupEnumUnits[...]() use the boolexpr only once, so call DestroyBoolExpr() does not stop the function from working. I'm pretty sure it will leak if not destroyed in this case.
However Destroying boolexpr used in TriggerAddCondition() functions will make the function stop working.

So I guess it depends on if the boolexpr is going to be called once or many times.


On topic:
Are you using many heavy loops and timers that run often? They can cause massive lag if not used with care.

 

[kallieblakie]

>>that's all? but i removed them, and it still lags ! how !
You are using Jass, aren't you?
Forgoten to null handles?

yeah i nulled handles and effects. nulled bollexpr too. what else? anyone can remind me of something?


I do have triggers running every 0.02 seconds, movement triggers (sliding). does that cause alot of lag? I mainly need to remove the leaks caused by these triggers, right?

 

[Builder Bob]

yeah i nulled handles and effects. nulled bollexpr too. what else? anyone can remind me of something?


I do have triggers running every 0.02 seconds, movement triggers (sliding). does that cause alot of lag? I mainly need to remove the leaks caused by these triggers, right?

Does your map lag at the very beginning? If yes, then no matter how much or little your map leak, it's not gonna help you to only clear up the leaks. You will need to refine your code to do more with less effort.

A leak is when you use some of your memory, but you don't clean after yourself. At first you won't notice anything since you have so much memory, but after a while it's gonna get quite crowded, and everything is gonna take much longer time to get done. That's when you notice your map leaks.

 

[kallieblakie]

the map doesn't lag at the begining. it begins to lag after the game gets played longer. doesn't happen when i used GUI, but happened when i convereted it to jass to make it MUI. but now I don't know how to clean up the mess.

 

[Builder Bob]

Some of the BJ functions leak by not nulling variables. You could check that.

Additions to your list:
Rects
Triggers if created dynamically in your other triggers.

 

[~GaLs~]

>>Some of the BJ functions leak by not nulling variables. You could check that.
O rly?
BJ functions do leak? Which function?

>>but happened when i convereted it to jass to make it MUI
Well, just converting a GUI to Jass won't make any different in speed/lag. Did you done some fatal edit on the code?

 

[kallieblakie]

ok thanks alot.

it still lags, i don't know why.

i used local variables:

timer
unit
real
integer
location
boolexpr
group
effect.

i only null units, group, effect, location, timer. Didn't null integer and reals. could they be the cause?

EDIT:

Just to check, the code for nulling handles is

call FlushHandleLocals(<name>)

right?

 

[kallieblakie]

i changed the scripting from GUI "2 triggers" to JASS "1 trigger", meaning i completely rewrote the whole trigger, changing from global variables to local variables.

 

[~GaLs~]

>>Just to check, the code for nulling handles is
False.
Syntax:

set <HandleName> = null

>>i changed the scripting from GUI "2 triggers" to JASS "1 trigger", meaning i completely rewrote the whole trigger, changing from global variables to local variables.
Nothing I can help unless you post your code.

 

[Builder Bob]

>>Some of the BJ functions leak by not nulling variables. You could check that.
O rly?
BJ functions do leak? Which function?

Here's one where the variable g is not nulled:

function GetUnitsOfTypeIdAll takes integer unitid returns group
    local group   result = CreateGroup()
    local group   g      = CreateGroup()
    local integer index

    set index = 0
    loop
        set bj_groupEnumTypeId = unitid
        call GroupClear(g)
        call GroupEnumUnitsOfPlayer(g, Player(index), filterGetUnitsOfTypeIdAll)
        call GroupAddGroup(g, result)

        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop
    call DestroyGroup(g)

    return result
endfunction

For the most part I've just read about people telling that BJ functions doesn't null variables. It wasn't hard to find this function though, so there are probably more.


For kallieblakie:

function PreventTimerLeak takes nothing returns nothing
	local timer t = CreateTimer()
	call DestroyTimer(t)
	set t = null
endfunction

function PreventGroupLeak takes nothing returns nothing
	local timer g = CreateGroup()
	call DestroyGroup(g)
	set g = null
endfunction

These two functions doesn't do anything other than create a timer/group, and then cleaning in the memory. Between the creation and destruction you can do whatever you want with them.
And no, integers, reals and booleans does not have to be nulled.

 

[kallieblakie]

function Arrow_Filter takes nothing returns boolean
    return IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) != true and GetWidgetLife(GetFilterUnit()) > 0.405 
endfunction

function Trig_Arrow_Elunes_Arrow_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'AOsh' ) ) then
        return false
    endif
    return true
endfunction

function DPP takes location locA, location locB returns real
    local real dx = GetLocationX(locB) - GetLocationX(locA)
    local real dy = GetLocationY(locB) - GetLocationY(locA)
    return SquareRoot(dx * dx + dy * dy)
endfunction

function Arrow_Move takes nothing returns nothing
    local timer Loop = GetExpiredTimer()
    local unit arrow = GetHandleUnit(Loop, "arrow")
    local unit caster = GetHandleUnit(Loop, "caster")
    local real angle = GetHandleReal(Loop, "angle")
    local integer Range = GetHandleInt(Loop, "Range")
    local integer Radius = GetHandleInt(Loop, "Radius")
    local real Speed = GetHandleReal(Loop, "Speed")
    local integer PlayerNo = GetHandleInt(Loop, "PlayerNo")
    local real distanceCurrent = GetHandleReal(Loop, "distanceCurrent")
    local location C = GetUnitLoc(arrow)
    local location Next
    local boolexpr b = Condition(function Arrow_Filter)
    local real x 
    local real y
    local group g = CreateGroup()
    local unit p
    local integer Number
    local location locA = GetUnitLoc(caster)
    local location locB = GetUnitLoc(arrow)
    if  (R2I(distanceCurrent) <= Range) then
       set distanceCurrent = distanceCurrent + Speed
       call SetHandleReal (Loop, "distanceCurrent", distanceCurrent)
       set x = GetLocationX(C) + Speed*Cos(angle*bj_DEGTORAD)
       set y = GetLocationY(C) + Speed*Sin(angle*bj_DEGTORAD)
       set Next = Location(x,y) 
       call SetUnitPositionLoc( arrow, Next )
       call GroupEnumUnitsInRangeOfLocCounted(g, Next, I2R(Radius), b, 1)
        set Number = CountUnitsInGroup(g)
        if Number > 0 then
           set p = FirstOfGroup(g)
              
             if ( ( UnitHasBuffBJ(p, 'BPSE') == true ) ) then
               call UnitDamageTarget(caster, p, 100000, false, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL, null)
               call RemoveUnit(arrow)
             elseif ( (IsUnitEnemy(p, GetOwningPlayer(caster)) == true)) then
               call RemoveUnit(arrow)
               call UnitDamageTarget(caster, p, udg_Damage[PlayerNo], false, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL, null)
       
            call CreateNUnitsAtLoc( 1, 'hfoo', GetOwningPlayer(caster), Next, 0.00 )
            call UnitAddAbilityBJ( 'ANsb', GetLastCreatedUnit() )
            call SetUnitAbilityLevelSwapped( 'ANsb', GetLastCreatedUnit(), udg_Stun[PlayerNo] )
            call IssueTargetOrderBJ( GetLastCreatedUnit(), "thunderbolt", p )
            call UnitApplyTimedLifeBJ( 2.00, 'BTLF', GetLastCreatedUnit() )

  call UnitDamageTarget (caster, p, (( I2R(udg_I_PrecisionLevel[PlayerNo]) * ( 0.06 * DPP(locA,locB)))+( ( 35000.00 * ( 0.40 * I2R(udg_I_bladeLevel[PlayerNo]) ) ) / DPP(locA,locB))),false,true, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_METAL_HEAVY_BASH )
          set arrow = null
          set caster = null
          set p = null
            call RemoveLocation (locA)
            call RemoveLocation (locB)
            call FlushHandleLocals(Loop)
            call PauseTimer(Loop)
            call DestroyTimer(Loop)
            call RemoveLocation (Next)
            call RemoveLocation (C)
    set x = 0.00
    set y = 0.00

    call DestroyBoolExpr(b)
    call DestroyGroup(g)
               endif

              

        endif
    call DestroyBoolExpr(b)
    call DestroyGroup(g)
            call RemoveLocation (Next)
            call RemoveLocation (C)        
    set x = 0.00
    set y = 0.00
          set arrow = null
          set caster = null
          set p = null
            call RemoveLocation (locA)
            call RemoveLocation (locB)


    elseif (R2I(distanceCurrent) > Range) then
       call KillUnit(arrow)
       call RemoveUnit(arrow)
       call PauseTimer(Loop) 
       call FlushHandleLocals(Loop)
       call DestroyTimer(Loop) 
    endif
    set x = 0.00
    set y = 0.00
    call RemoveLocation(C)
    call RemoveLocation(Next)
    set arrow = null
    call DestroyBoolExpr(b)
    call DestroyGroup(g)
          set caster = null
          set p = null
            call RemoveLocation (locA)
            call RemoveLocation (locB)
endfunction



function Trig_Arrow_Elunes_Arrow_Actions takes nothing returns nothing
    local timer Loop = CreateTimer()
    local unit caster = GetSpellAbilityUnit()    
    local location casterPosition = GetUnitLoc(caster)
    local location targetPosition = GetSpellTargetLoc()    
    local integer PlayerNo = GetConvertedPlayerId(GetOwningPlayer(GetSpellAbilityUnit()))
    local integer radius = udg_Radius[PlayerNo]
    local real angle = AngleBetweenPoints(casterPosition, targetPosition)
    local real x = GetLocationX(casterPosition) + (radius+2)*Cos(angle*bj_DEGTORAD)
    local real y = GetLocationY(casterPosition) + (radius+2)*Sin(angle*bj_DEGTORAD)    
    local real Scale = ( 100.00 * ( I2R(radius) / 80.00 ) )   
    local location shootPosition = Location(x,y) 

    local unit arrow = null
    local integer Range = udg_Range[PlayerNo]
    local real Speed = udg_Speed[PlayerNo]
    call CreateNUnitsAtLoc( 1, 'hpea', ConvertedPlayer(PlayerNo), shootPosition, angle)
    set arrow = GetLastCreatedUnit()
    call SetUnitScalePercent( arrow, Scale, Scale, Scale )
    call SetUnitPathing( arrow, false )
    call RemoveLocation(shootPosition)
    call RemoveLocation(casterPosition)
    call RemoveLocation(targetPosition)    
    set x = 0.00
    set y = 0.00

   call SetHandleHandle(Loop, "arrow", arrow)
   call SetHandleHandle(Loop, "caster", caster)
   call SetHandleReal(Loop,"angle",angle)
   call SetHandleInt(Loop, "Range", Range)
   call SetHandleReal(Loop, "Speed", Speed)
   call SetHandleInt(Loop, "Radius", radius)
   call SetHandleInt(Loop, "PlayerNo", PlayerNo) 
    call TimerStart(Loop, 0.03, true, function Arrow_Move)
endfunction




//===========================================================================
function InitTrig_Arrow_Elunes_Arrow takes nothing returns nothing
    set gg_trg_Arrow_Elunes_Arrow = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Arrow_Elunes_Arrow, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Arrow_Elunes_Arrow, Condition( function Trig_Arrow_Elunes_Arrow_Conditions ) )
    call TriggerAddAction( gg_trg_Arrow_Elunes_Arrow, function Trig_Arrow_Elunes_Arrow_Actions )
endfunction

this is my code. i'm desperate. someone help me check out where it leaks please?

for certain global variables, they are variables that records down each individual player's stats, recoreded in an array.

Please help ! it will be appreciated!

 

[SFilip]

> Does BoolExpr leak if not destroyed
No, they never leak.
And because of this destroying is a bad idea.